From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:51686) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIzhd-0008MP-UR for guix-patches@gnu.org; Mon, 30 Mar 2020 15:04:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIzhc-0008Nf-Hw for guix-patches@gnu.org; Mon, 30 Mar 2020 15:04:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51761) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIzhc-0008NK-5h for guix-patches@gnu.org; Mon, 30 Mar 2020 15:04:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jIzha-0000j8-EJ for guix-patches@gnu.org; Mon, 30 Mar 2020 15:04:03 -0400 Subject: [bug#40300] [PATCH] gnu: Add emacs-haskell-snippets. Resent-Message-ID: From: John Soo References: <87k1342cl1.fsf@asu.edu> <871rp97ofd.fsf@nicolasgoaziou.fr> <877dz1wxom.fsf@asu.edu> <87sghp6882.fsf@nicolasgoaziou.fr> Date: Mon, 30 Mar 2020 12:03:23 -0700 In-Reply-To: <87sghp6882.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Mon, 30 Mar 2020 19:52:29 +0200") Message-ID: <87tv25vf5w.fsf@asu.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nicolas Goaziou Cc: 40300@debbugs.gnu.org --=-=-= Content-Type: text/plain Nicolas Goaziou writes: > Hello, > > John Soo writes: > >> +(define-public emacs-haskell-snippets >> + (package >> + (name "emacs-haskell-snippets") >> + (version "0.1.0") > > Would it make sense to package HEAD instead. I'm looking in particular > at upstream's commit 9e41a53f8388f2a2cf2a1bb3163bc6de764099d5. I think so. Done. >> + (source >> + (origin >> + (method git-fetch) >> + (uri >> + (git-reference >> + (url "https://github.com/haskell/haskell-snippets") >> + (commit version))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 >> + "0b3d7rvqvvcsp51aqfhl0zg9zg8j0p6vlfvga6jp9xc7626vh6f6")))) > > Usual nitpick: please put string on the same line as `base32'. Done. >> + (inputs >> + `(("emacs-yasnippet" ,emacs-yasnippet))) >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (add-after 'install 'install-snippets >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let* ((out (assoc-ref outputs "out")) >> + (snippets >> + (string-append >> + out "/share/emacs/site-lisp/snippets/haskell-mode"))) >> + (mkdir-p snippets) >> + (copy-recursively "snippets/haskell-mode" snippets) >> + #t)))))) >> + (build-system emacs-build-system) > > Nitpick: could you move parts in this order: build-system -> > arguments -> inputs. Yes I can. Done. I also changed inputs -> propagated-inputs. Thanks again, John --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-emacs-haskell-snippets.patch Content-Description: add emacs-haskell-snippets. >From 1984fc60cc5045c50ae9f913b13ebbc93101f731 Mon Sep 17 00:00:00 2001 From: John Soo Date: Tue, 24 Mar 2020 07:21:35 -0700 Subject: [PATCH] gnu: Add emacs-haskell-snippets. * gnu/packages/emacs-xyz.scm (emacs-haskell-snippets): New variable. --- gnu/packages/emacs-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c029d1ed3d..1d46f540ad 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -21965,3 +21965,39 @@ enables modal editing and composition of commands, too. It combines ideas of other Editors like Vim or Kakoune and tries to align them with regular Emacs conventions.") (license license:gpl3+))) + +(define-public emacs-haskell-snippets + (let ((commit "07b0f460b946fd1be26c29652cb0468b47782f3a")) + (package + (name "emacs-haskell-snippets") + (version (git-version "0.1.0" "0" commit)) + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/haskell/haskell-snippets") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0a7y3awi9hcyahggf0ghsdwvsmrhr9yq634wy9lkqjzrm2hqj0ci")))) + (build-system emacs-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'install 'install-snippets + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (snippets + (string-append + out "/share/emacs/site-lisp/snippets/haskell-mode"))) + (mkdir-p snippets) + (copy-recursively "snippets/haskell-mode" snippets) + #t)))))) + (propagated-inputs + `(("emacs-yasnippet" ,emacs-yasnippet))) + (home-page "https://github.com/haskell/haskell-snippets") + (synopsis "Official collection of YASnippet Haskell snippets for Emacs") + (description "Haskell-Snippets is a collection of YASnippet Haskell +snippets for Emacs.") + (license license:expat)))) -- 2.26.0 --=-=-=--