Re: 11/12: gnu: Add libuemf.

Re: 11/12: gnu: Add libuemf.

[Caleb Ristvedt]

guix-commits@gnu.org writes:

> apteryx pushed a commit to branch master
> in repository guix.
>
> commit 3f1f98d9d8c4e7f5dfca921fe1957e4d53783e35
> Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> AuthorDate: Tue Jan 28 01:21:24 2020 -0500
>
>     gnu: Add libuemf.
>     
>     * gnu/packages/image.scm (libuemf): New variable.
> ---
>  gnu/packages/image.scm | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
>
> diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
> index 24f1b15..05b64dd 100644
> --- a/gnu/packages/image.scm
> +++ b/gnu/packages/image.scm
> @@ -25,6 +25,7 @@
>  ;;; Copyright © 2018 Rutger Helling <rhelling@mykolab.com>
>  ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul@autistici.org>
>  ;;; Copyright © 2020 R Veera Kumar <vkor@vkten.in>
> +;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;

<...>

> +    (description "The libUEMF library is a portable C99 implementation for
> +reading and writing @abbr{WFM, Windows Metafile}, @abbr{EMF, Enhanced
> +Metafile}, and @abbr{EMF+, Enhanced Metafile Plus} files.")
> +    (license license:gpl2+)))

Turns out guile's texinfo stuff chokes on @abbr:

--------------------------------
$ guix package -s libuemf
Backtrace:
           1 (primitive-load "/home/reepca/.config/guix/current/bin/guix")
In guix/ui.scm:
  1936:12  0 (run-guix-command _ . _)

guix/ui.scm:1936:12: In procedure run-guix-command:
Throw to key `parser-error' with args `(#f "Unknown command" abbr)'.
--------------------------------

guix/ui.scm:1936:12: In procedure run-guix-command:
Throw to key `parser-error' with args `(#f "Unknown command" abbr)'.

I don't know enough about texinfo to offer a solution, but figured it
should be mentioned. Currently this is causing tests/packages.sh to
fail.

- reepca

Re: 11/12: gnu: Add libuemf.

[Maxim Cournoyer]

Hello Caleb,

Caleb Ristvedt <caleb.ristvedt@cune.org> writes:

[...]

>> +    (description "The libUEMF library is a portable C99 implementation for
>> +reading and writing @abbr{WFM, Windows Metafile}, @abbr{EMF, Enhanced
>> +Metafile}, and @abbr{EMF+, Enhanced Metafile Plus} files.")
>> +    (license license:gpl2+)))
>
> Turns out guile's texinfo stuff chokes on @abbr:
>
> --------------------------------
> $ guix package -s libuemf
> Backtrace:
>            1 (primitive-load "/home/reepca/.config/guix/current/bin/guix")
> In guix/ui.scm:
>   1936:12  0 (run-guix-command _ . _)
>
> guix/ui.scm:1936:12: In procedure run-guix-command:
> Throw to key `parser-error' with args `(#f "Unknown command" abbr)'.
> --------------------------------
>
> guix/ui.scm:1936:12: In procedure run-guix-command:
> Throw to key `parser-error' with args `(#f "Unknown command" abbr)'.


> I don't know enough about texinfo to offer a solution, but figured it
> should be mentioned. Currently this is causing tests/packages.sh to
> fail.

On the current master branch,

--8<---------------cut here---------------start------------->8---
make check TESTS=tests/guix-package.sh

[...]

PASS: tests/guix-package.sh
============================================================================
Testsuite summary for GNU Guix 1.0.1.17120-e7b86a0
============================================================================
# TOTAL: 1
# PASS:  1
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
--8<---------------cut here---------------end--------------->8---

'guix lint libuemf' also passes, and 'guix show libuemf' renders the
description correctly here.

Maxim

Re: 11/12: gnu: Add libuemf.

[Caleb Ristvedt]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> On the current master branch,
>
> make check TESTS=tests/guix-package.sh
>
> [...]
>
> PASS: tests/guix-package.sh
> ============================================================================
> Testsuite summary for GNU Guix 1.0.1.17120-e7b86a0
> ============================================================================
> # TOTAL: 1
> # PASS:  1
> # SKIP:  0
> # XFAIL: 0
> # FAIL:  0
> # XPASS: 0
> # ERROR: 0
> ============================================================================
>
> 'guix lint libuemf' also passes, and 'guix show libuemf' renders the
> description correctly here.
>
> Maxim

Indeed, Tobias worked around it in
86a03090afa711dfa2f141caee820b66d7942bc3.

- reepca

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: 11/12: gnu: Add libuemf.

[Maxim Cournoyer]

Hi Caleb,

Caleb Ristvedt <caleb.ristvedt@cune.org> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>> On the current master branch,
>>
>> make check TESTS=tests/guix-package.sh
>>
>> [...]
>>
>> PASS: tests/guix-package.sh
>> ============================================================================
>> Testsuite summary for GNU Guix 1.0.1.17120-e7b86a0
>> ============================================================================
>> # TOTAL: 1
>> # PASS:  1
>> # SKIP:  0
>> # XFAIL: 0
>> # FAIL:  0
>> # XPASS: 0
>> # ERROR: 0
>> ============================================================================
>>
>> 'guix lint libuemf' also passes, and 'guix show libuemf' renders the
>> description correctly here.
>>
>> Maxim
>
> Indeed, Tobias worked around it in
> 86a03090afa711dfa2f141caee820b66d7942bc3.

Yay, thank you, Tobias!

Maxim