[bug#43972] [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.

[bug#43972] [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.

[Joseph LaFreniere]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

Patch file is attached.  There have been a couple of bugfix 
commits since the tagged 1.1.0, so I went ahead and just grabbed 
the current latest master.

--
Joseph LaFreniere

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-emacs-mixed-pitch-Update-to-1.1.0.patch --]
[-- Type: text/x-patch, Size: 2532 bytes --]

From 5528b14d163901fecf5358caaf5c00326115bfd0 Mon Sep 17 00:00:00 2001
From: Joseph LaFreniere <joseph@lafreniere.xyz>
Date: Tue, 13 Oct 2020 01:20:49 -0500
Subject: [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.

* gnu/packages/emacs-xyz.scm (emacs-mixed-pitch): Update to 1.1.0.
---
 gnu/packages/emacs-xyz.scm | 39 ++++++++++++++++++++------------------
 1 file changed, 21 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5909016422..b8b98020fe 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -16377,27 +16377,30 @@ decreasing the default font size in all GUI Emacs frames.")
       (license license:gpl3+))))
 
 (define-public emacs-mixed-pitch
-  (package
-    (name "emacs-mixed-pitch")
-    (version "1.0.1")
-    (source
-     (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://gitlab.com/jabranham/mixed-pitch.git")
-             (commit version)))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "1458sy5b6bis1i0k23jdqk6hfqg0ghk637r3ajql2g19ym48rf58"))))
-    (build-system emacs-build-system)
-    (home-page "https://gitlab.com/jabranham/mixed-pitch")
-    (synopsis "Mix variable- and fixed-pitch fonts in the same Emacs buffer")
-    (description
-     "@code{mixed-pitch-mode} is a minor mode that enables mixing
+  (let ((commit "d305108f9520e196b533f05d1dcc284cf535faaf")
+        (tag "1.1.0")
+        (revision "0"))
+    (package
+      (name "emacs-mixed-pitch")
+      (version (git-version tag revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://gitlab.com/jabranham/mixed-pitch.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0yx89is3g2m8af8vfsz5rgjmfmx7mfrxlffb1x6y4b8lh9l0k6dj"))))
+      (build-system emacs-build-system)
+      (home-page "https://gitlab.com/jabranham/mixed-pitch")
+      (synopsis "Mix variable- and fixed-pitch fonts in the same Emacs buffer")
+      (description
+       "@code{mixed-pitch-mode} is a minor mode that enables mixing
 variable-pitch and fixed-pitch fonts in the same buffer.  The list
 @code{mixed-pitch-fixed-pitch-faces} defines the faces that are kept
 fixed-pitch,everything else becomes variable-pitch.")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public emacs-visual-regexp
   (package
-- 
2.28.0

[bug#43972] [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.

[Nicolas Goaziou]

Hello,

Joseph LaFreniere <joseph@lafreniere.xyz> writes:

> Patch file is attached.

Thank you.

> There have been a couple of bugfix commits
> since the tagged 1.1.0, so I went ahead and just grabbed the current
> latest master.

AFAICT, there are 3 commits since 1.1.0 release. One is about updating
copyright years, the other two are adding faces to a list. Is there
a strong reason to use a non-tagged commit instead of a regular release?
If you think so, could you explain it in a comment at the beginning of
the package?

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou

[bug#43972] [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.

[Joseph LaFreniere]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]


Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> AFAICT, there are 3 commits since 1.1.0 release. One is about 
> updating
> copyright years, the other two are adding faces to a list. Is 
> there
> a strong reason to use a non-tagged commit instead of a regular 
> release?
> If you think so, could you explain it in a comment at the 
> beginning of
> the package?

Given that this package is about faces, both of the two commits 
about adding faces consitute bug fixes for this ticket.  In 
particular, both of those commits address visual misalignment 
caused by the faces used for org-indent and line numbers being 
rendered in variable pitch faces.

I have added a single-sentence comment to the start of the recipe. 
If it would be appropriate to reference the specific issue 
tickets' URLs I can do that instead or in addition to.

Thanks for the review!

--
Joseph LaFreniere

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-emacs-mixed-pitch-Update-to-1.1.0.patch --]
[-- Type: text/x-patch, Size: 2629 bytes --]

From 1022214b8fbb2c0dcb91ee335ab0c7a6721d782e Mon Sep 17 00:00:00 2001
From: Joseph LaFreniere <joseph@lafreniere.xyz>
Date: Tue, 13 Oct 2020 01:20:49 -0500
Subject: [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.

* gnu/packages/emacs-xyz.scm (emacs-mixed-pitch): Update to 1.1.0.
---
 gnu/packages/emacs-xyz.scm | 41 +++++++++++++++++++++-----------------
 1 file changed, 23 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5909016422..939b38ebac 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -16377,27 +16377,32 @@ decreasing the default font size in all GUI Emacs frames.")
       (license license:gpl3+))))
 
 (define-public emacs-mixed-pitch
-  (package
-    (name "emacs-mixed-pitch")
-    (version "1.0.1")
-    (source
-     (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://gitlab.com/jabranham/mixed-pitch.git")
-             (commit version)))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "1458sy5b6bis1i0k23jdqk6hfqg0ghk637r3ajql2g19ym48rf58"))))
-    (build-system emacs-build-system)
-    (home-page "https://gitlab.com/jabranham/mixed-pitch")
-    (synopsis "Mix variable- and fixed-pitch fonts in the same Emacs buffer")
-    (description
-     "@code{mixed-pitch-mode} is a minor mode that enables mixing
+  ;; This commit contains fixes for visual alignment of line numbers and
+  ;; org-indent-mode.
+  (let ((commit "d305108f9520e196b533f05d1dcc284cf535faaf")
+        (tag "1.1.0")
+        (revision "0"))
+    (package
+      (name "emacs-mixed-pitch")
+      (version (git-version tag revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://gitlab.com/jabranham/mixed-pitch.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0yx89is3g2m8af8vfsz5rgjmfmx7mfrxlffb1x6y4b8lh9l0k6dj"))))
+      (build-system emacs-build-system)
+      (home-page "https://gitlab.com/jabranham/mixed-pitch")
+      (synopsis "Mix variable- and fixed-pitch fonts in the same Emacs buffer")
+      (description
+       "@code{mixed-pitch-mode} is a minor mode that enables mixing
 variable-pitch and fixed-pitch fonts in the same buffer.  The list
 @code{mixed-pitch-fixed-pitch-faces} defines the faces that are kept
 fixed-pitch,everything else becomes variable-pitch.")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public emacs-visual-regexp
   (package
-- 
2.28.0

bug#43972: [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.

[Ludovic Courtès]

Hi,

Joseph LaFreniere <joseph@lafreniere.xyz> skribis:

> Given that this package is about faces, both of the two commits about
> adding faces consitute bug fixes for this ticket.  In particular, both
> of those commits address visual misalignment caused by the faces used
> for org-indent and line numbers being rendered in variable pitch
> faces.
>
> I have added a single-sentence comment to the start of the recipe. If
> it would be appropriate to reference the specific issue tickets' URLs
> I can do that instead or in addition to.

I think this addresses Nicolas’ concerns.

>>From 1022214b8fbb2c0dcb91ee335ab0c7a6721d782e Mon Sep 17 00:00:00 2001
> From: Joseph LaFreniere <joseph@lafreniere.xyz>
> Date: Tue, 13 Oct 2020 01:20:49 -0500
> Subject: [PATCH] gnu: emacs-mixed-pitch: Update to 1.1.0.
>
> * gnu/packages/emacs-xyz.scm (emacs-mixed-pitch): Update to 1.1.0.

So I went ahead and committed it, thanks!

Ludo’.