From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QOTuANBw41+QSAAA0tVLHw (envelope-from ) for ; Wed, 23 Dec 2020 16:31:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mCR+OM9w41+iHAAAB5/wlQ (envelope-from ) for ; Wed, 23 Dec 2020 16:31:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 40DD49404C5 for ; Wed, 23 Dec 2020 16:31:11 +0000 (UTC) Received: from localhost ([::1]:44910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ks72c-000059-1S for larch@yhetil.org; Wed, 23 Dec 2020 11:31:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ks72U-00004z-R1 for guix-patches@gnu.org; Wed, 23 Dec 2020 11:31:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42411) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ks72U-00077a-Ih for guix-patches@gnu.org; Wed, 23 Dec 2020 11:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ks72U-0000rA-FJ for guix-patches@gnu.org; Wed, 23 Dec 2020 11:31:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44457] [PATCH]: gnu: Add hunspell-dict-it-it. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 23 Dec 2020 16:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44457 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: paul Received: via spool by 44457-submit@debbugs.gnu.org id=B44457.16087410183236 (code B ref 44457); Wed, 23 Dec 2020 16:31:02 +0000 Received: (at 44457) by debbugs.gnu.org; 23 Dec 2020 16:30:18 +0000 Received: from localhost ([127.0.0.1]:53957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks71a-0000ow-RM for submit@debbugs.gnu.org; Wed, 23 Dec 2020 11:30:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ks71Z-0000nv-5e for 44457@debbugs.gnu.org; Wed, 23 Dec 2020 11:30:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52484) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ks71S-0006hv-ON; Wed, 23 Dec 2020 11:29:58 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=46258 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ks71R-0004a6-Mw; Wed, 23 Dec 2020 11:29:58 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <79f0de78-4d1f-7cae-3081-2581cafb51ee@autistici.org> Date: Wed, 23 Dec 2020 17:29:55 +0100 In-Reply-To: <79f0de78-4d1f-7cae-3081-2581cafb51ee@autistici.org> (paul's message of "Sat, 7 Nov 2020 02:20:02 +0100") Message-ID: <87tuscv62k.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44457@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.83 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 40DD49404C5 X-Spam-Score: -2.83 X-Migadu-Scanner: scn1.migadu.com X-TUID: rc0v8sQ53Gpk Hi! paul skribis: > From 17a476dd234fa4a128eb90ccc8ac9a565045bfa1 Mon Sep 17 00:00:00 2001 > From: Giacomo Leidi > Date: Thu, 5 Nov 2020 02:04:20 +0100 > Subject: [PATCH] gnu: Add hunspell-dict-it-it. > > * gnu/packages/hunspell.scm: New file; > (hunspell-dictionary): New variable; > (hunspell-dict-it-it): New variable. > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. I=E2=80=99m picking up this patch as it seems to have fallen through the cracks. :-) Overall it LGTM; a couple of comments below. Apparently this is different from the Hunspell dictionaries made from Aspell word lists that appear in (gnu packages aspell), right? Should we name the packages differently to avoid collisions with the existing =E2=80=98hunspell-dict-*=E2=80=99 packages? [...] > + (synopsis > + (string-append "Hunspell dictionary for " full-name " (" dict-name = ")")) This is recommended against as this prevents i18n: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html You can work around it by writing the string in full, as in: (define-public hunspell-dict-it-it (let ((synopsis identity)) (hunspell-dictionary "it_IT" "Italian" #:synopsis (synopsis "Hunspell dictionary for It= alian") #:home-page "https://libreitalia.org/" #:license license:gpl3))) > + #:license license:gpl3)) It wondered whether this might be =E2=80=98gpl3+=E2=80=99, but confirms that this is =E2=80=9Cversion 3 only=E2=80=9D; all good! :-) Could you send an updated patch? Thanks, Ludo=E2=80=99.