From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CJBmEDhm5V9EbAAA0tVLHw (envelope-from ) for ; Fri, 25 Dec 2020 04:10:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8Jw+DDhm5V/eAQAA1q6Kng (envelope-from ) for ; Fri, 25 Dec 2020 04:10:32 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B5ACF9402D6 for ; Fri, 25 Dec 2020 04:10:31 +0000 (UTC) Received: from localhost ([::1]:55480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kseQw-0007yG-Km for larch@yhetil.org; Thu, 24 Dec 2020 23:10:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kseQV-0007y3-UF for guix-patches@gnu.org; Thu, 24 Dec 2020 23:10:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44882) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kseQV-0007Nc-1l for guix-patches@gnu.org; Thu, 24 Dec 2020 23:10:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kseQU-0002E2-Tt for guix-patches@gnu.org; Thu, 24 Dec 2020 23:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 25 Dec 2020 04:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45403 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: raid5atemyhomework@protonmail.com, 45403@debbugs.gnu.org X-Debbugs-Original-To: raid5atemyhomework , raid5atemyhomework via Guix-patches X-Debbugs-Original-Cc: "45403@debbugs.gnu.org" <45403@debbugs.gnu.org> Received: via spool by 45403-submit@debbugs.gnu.org id=B45403.16088693918513 (code B ref 45403); Fri, 25 Dec 2020 04:10:02 +0000 Received: (at 45403) by debbugs.gnu.org; 25 Dec 2020 04:09:51 +0000 Received: from localhost ([127.0.0.1]:56424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kseQJ-0002DE-Dj for submit@debbugs.gnu.org; Thu, 24 Dec 2020 23:09:51 -0500 Received: from tobias.gr ([80.241.217.52]:52192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kseQF-0002D2-AM for 45403@debbugs.gnu.org; Thu, 24 Dec 2020 23:09:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=/2UOoYukUUIcZOVSU/WGPT4YLYmG6QvXWhR/OLQfUCk=; h=date:in-reply-to: references:subject:cc:to:from; b=pxn0tcW1hphj1bGvf+StfLP3Ucm5/enPoX1n0 BVYT/WaPQgjqr3i5KvdCFcbVGBvvu/TliMBO+49jR6vYbLTtgqXxET3kzKKVt6M3H2ha2t lRlVSn9mOEcnzvgeCalLuikmh25zmVhh9gJVOn88zo2zc4IputqftEASOTBN37BB2vknMO DjojGL6P4ynXRgejmd6TAqIRs0845PMwK3MOf50d6cP7aesqzY6e2gN0z53ucoyKsm8CPW +c/6UTo6akxUVBOE4XLDSCWjCWpWHtXCLgb/d5PjrVwwFIU+ApQkWuc0Fh5wOkp6edNGxa ZoB1WWeb2qUJ2Ens6mse8QrdQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id f45fccc9 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Fri, 25 Dec 2020 04:10:09 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; References: In-reply-to: Date: Fri, 25 Dec 2020 05:09:44 +0100 Message-ID: <87tusaa5mf.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.42 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=tobias.gr header.s=2018 header.b=pxn0tcW1; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B5ACF9402D6 X-Spam-Score: -4.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: I5vFRzLIypBp --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hullo RAIDperson! Thanks for working to improve Guix's currently broken ZFS package! raid5atemyhomework via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > What it changes is that it compiles kernel modules for all=20 > guix-provided kernel versions that ZFS currently is rated to=20 > support, However, I oppose this (and not because =E2=80=98rated=E2=80=99 sets off my= =20 corpo-speak alarms :-). It makes your system.scm tedious to=20 maintain, especially if we'd do this for all modules (and why=20 not?). Worse, there's no such thing as =E2=80=98a 5.10=E2=80=99 Linux module that = loads=20 on =E2=80=98a 5.10=E2=80=99 Linux kernel. We still need an easy generic me= thod to=20 build modules against their chosen kernel and configuration. As your patch illustrates, that already exists: > (define (make-linux-zfs linux-libre) > (package > (inherit zfs-base) > (arguments > `(#:linux ,linux-libre) > ,@(package-arguments zfs-base)) It just belongs in your system.scm, not in Guix itself. Kind regards, T G-R P.S.nitpick: unfortunately this breaks localisation and can't be=20 done: > + (string-append (package-description zfs-base) > + " > + > +This package is deprecated, use linux-VERSION-zfs packages=20 > instead.")))) Descriptions need to be simple self-contained strings, even if it=20 means duplicating entire paragraphs. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX+VmCA0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW150G4BAO4HZvoshtDSsDWogXhVuVycBUzD9VQtk6ueOOLr oFl6AP9Md2WvxjqXvMfauMLocsJrl5e+fNTCSvm/TR9JzfLHBg== =w6WA -----END PGP SIGNATURE----- --=-=-=--