From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uCLbCA/X+F+jSgAA0tVLHw (envelope-from ) for ; Fri, 08 Jan 2021 22:05:03 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sJe9BA/X+F9pcwAA1q6Kng (envelope-from ) for ; Fri, 08 Jan 2021 22:05:03 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 636439404E4 for ; Fri, 8 Jan 2021 22:05:02 +0000 (UTC) Received: from localhost ([::1]:40890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxzsT-0002zM-5g for larch@yhetil.org; Fri, 08 Jan 2021 17:05:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxzsI-0002zF-Do for guix-devel@gnu.org; Fri, 08 Jan 2021 17:04:50 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21159) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxzsG-0005oY-JI for guix-devel@gnu.org; Fri, 08 Jan 2021 17:04:50 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1610143485; cv=none; d=zohomail.com; s=zohoarc; b=CHDxpCbv8xBuab09diqw2E1ypJbYiE9hpvvqXHr5kHr4G/ci2YFbq48w7OSnVDOC8m/LxK4t91cxIX7eoU7zBpdC+gr+9fnH7LWSU4Bii+1fL+64W5geuwed3Q1I+vaNXhivtnHkxueDD4JfHQ8QLDiRaPQdEjBUejn2C5/T8FU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610143485; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=BENxB0hnHSA0bwIUFtTqt1wZ+aRTcfnxW3D8/mcDjAY=; b=Jre7DYq5cMvGm6GjlDMxD8Bdfu9YZXM57DvcTH+01uybutc+4UQja5U8DEp7z2iSNt002V2rhvmXi3uTDW15F0+ILtLsoSEKZAdlTZH1vI15aSdNctDd2don2mwI05Jh2VihGqXuLIFsBotkZJOMqY6khj6LZf3g4XNZ7wjZtIM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1610143485; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type; bh=BENxB0hnHSA0bwIUFtTqt1wZ+aRTcfnxW3D8/mcDjAY=; b=dW+dlGWLgeRhfpiHwlRJU0JRBzSjmWFV8vvfLAMeIg/ptiaBPfRFNnUEudxzTnhe ZfUb37SKovYPrEFMfuofRuwUbke/dtt9OpwdErPl6kB0BC3OIScWTURLmzLv9cn95gR LVr5pfjEa9oePpjJM2AGw53RcNBwazL8V7yMXqyg= Received: from localhost (p54ad4ca5.dip0.t-ipconnect.de [84.173.76.165]) by mx.zohomail.com with SMTPS id 1610143483761534.8436387863406; Fri, 8 Jan 2021 14:04:43 -0800 (PST) References: <671cd289-5c83-3673-34f9-8287ff7c30a8@raghavgururajan.name> <5a6392cd-b478-846a-beda-4f97e46cbdd0@raghavgururajan.name> <87sg7bfwt0.fsf@elephly.net> <874kjr15vp.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Ricardo Wurmus To: Mark H Weaver Subject: Re: [Telegram-Desktop]: Help with packaging In-reply-to: <874kjr15vp.fsf@netris.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Fri, 08 Jan 2021 23:04:39 +0100 Message-ID: <87turrdr0o.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.51; envelope-from=rekado@elephly.net; helo=sender4-of-o51.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, Raghav Gururajan Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.65 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=elephly.net header.s=zoho header.b=dW+dlGWL; arc=reject (signature check failed: fail, {[1] = sig:zohomail.com:reject}); dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 636439404E4 X-Spam-Score: 0.65 X-Migadu-Scanner: scn1.migadu.com X-TUID: rcvfk5M4rmJJ Hi Mark, > It's more appropriate to use 'for-each' here. 'map' collects all of the > results into a list and returns that list, which is not needed here, and > is slightly less readable. Also, the second argument to 'find-files' is > optional; omitting it does what's needed more efficiently. So, in the > interest of promoting better practices, I would recommend this instead: > > --8<---------------cut here---------------start------------->8--- > (add-after 'unpack 'make-writable > (lambda _ > (for-each make-file-writable > (find-files ".")) > #t)) > --8<---------------cut here---------------end--------------->8--- Thank you for this better variant. I copied it from an existing instance in our code. We should clean those up at some point :) -- Ricardo