From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: branch core-updates updated: packages: Fix 'base32' used before definition warning.
Date: Mon, 11 Jan 2021 08:16:30 -0500 [thread overview]
Message-ID: <87turnobpt.fsf@gmail.com> (raw)
In-Reply-To: <87wnwjg8oq.fsf@gnu.org> ("Ludovic Courtès"'s message of "Mon, 11 Jan 2021 09:49:09 +0100")
Hi Ludovic!
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Maxim,
>
> guix-commits@gnu.org skribis:
>
>> commit 31ebecf73dadb51ccc72053f54dee36c93a2d0ab
>> Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> AuthorDate: Sun Jan 10 08:42:42 2021 -0500
>>
>> packages: Fix 'base32' used before definition warning.
>>
>> Before this change, compiling the module would emit the following message:
>> "guix/packages.scm:213:25: warning: macro `base32' used before definition".
>>
>> * guix/packages.scm (define-compile-time-decoder)
>> (base32, base64): Move definitions to the top of the module.
>
> To avoid merge conflicts down the road, could you apply it to ‘master’
> as well? (It’s fine to have it on ‘master’ as it doesn’t trigger any
> rebuild.)
Thanks for letting me know; I was under the impression that the
guix/packages.scm module as a whole would be used in the computation of
any package's derivation hash. I'm happy to learn it's actually smarter
than this :-).
Cherry-picked to master with commit
8152fd1af551f4bcec2ef59243264c10ff48daea.
Thank you,
Maxim
prev parent reply other threads:[~2021-01-11 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210110222441.10557.47179@vcs0.savannah.gnu.org>
2021-01-11 8:49 ` branch core-updates updated: packages: Fix 'base32' used before definition warning Ludovic Courtès
2021-01-11 13:16 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87turnobpt.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.