From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UHdSLCeM+mAd9AAAgWs5BA (envelope-from ) for ; Fri, 23 Jul 2021 11:30:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YD0SKCeM+mAoVgAAB5/wlQ (envelope-from ) for ; Fri, 23 Jul 2021 09:30:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3BA91418F for ; Fri, 23 Jul 2021 11:30:15 +0200 (CEST) Received: from localhost ([::1]:42180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6rVU-0005Yr-KP for larch@yhetil.org; Fri, 23 Jul 2021 05:30:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6rVK-0005W7-U0 for guix-patches@gnu.org; Fri, 23 Jul 2021 05:30:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6rVK-0001ua-KG for guix-patches@gnu.org; Fri, 23 Jul 2021 05:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6rVK-00075M-Fq for guix-patches@gnu.org; Fri, 23 Jul 2021 05:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49670] [PATCH] gnu: gnome-maps: Unregister from DBus when asked to. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Jul 2021 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49670 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Cc: 49670@debbugs.gnu.org Received: via spool by 49670-submit@debbugs.gnu.org id=B49670.162703256627162 (code B ref 49670); Fri, 23 Jul 2021 09:30:02 +0000 Received: (at 49670) by debbugs.gnu.org; 23 Jul 2021 09:29:26 +0000 Received: from localhost ([127.0.0.1]:42311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6rUj-000742-NF for submit@debbugs.gnu.org; Fri, 23 Jul 2021 05:29:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6rUg-00073p-0W for 49670@debbugs.gnu.org; Fri, 23 Jul 2021 05:29:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55702) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6rUZ-0001G2-2x; Fri, 23 Jul 2021 05:29:15 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=42906 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6rUY-00068M-RF; Fri, 23 Jul 2021 05:29:15 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210720223452.9471-1-leo.prikler@student.tugraz.at> <87fsw7hhce.fsf@gnu.org> <5af9faa539c916abf3fce795e1e127614456fa43.camel@student.tugraz.at> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 Thermidor an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 23 Jul 2021 11:29:12 +0200 In-Reply-To: <5af9faa539c916abf3fce795e1e127614456fa43.camel@student.tugraz.at> (Leo Prikler's message of "Thu, 22 Jul 2021 10:31:21 +0200") Message-ID: <87tuklbcpj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627032615; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=b/AzYw2AHp4vuwrijbYtIzYRmgjaG3i+Q02foVjyk90=; b=EstpZucLW3ip0fuPOUPEu1r3D1t22OhYqyuGbutuFQSdvhW+eDrVPw08Sg6Q0qrlzl7e6A 29ibT7FZIAYXjQGZUBIeJhqTGPxHSNb603lO54cwML+3sT5csljVmWrHcZBQA3A9hLhSA7 n8N6tnbrXi3Ac8N96luTQRV/wOKZ2eKwrZZoTEGMzUXItGnmIYPw3FqZU43CqyFcH3Nkye 7roAOs3lLF6S8HhPRKWQcDUpcNeSLDvJX/XVLygmERcAN/EstiUah7XIuqDyp9Jni+qUBI aDB+h11a7GrYCKJy5YuVmD/uHNsueW+rkkuj7bLHkuaDs0lTGsKrruakNavd4w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627032615; a=rsa-sha256; cv=none; b=AQjr6ZqfzqomwvKxXPBs6NhA6NbPbyqmFfS8fv1wTvAdFxnHcRMg24F0d9kcQdBpVp7iHz J0cOchEN/z7jjvUjKDjilkvBumwoLjHj3q5QCvVKXKAKjZ4eTMshOofRYIuBjIg4F56PoO VjJ2LVy7hyXQG9zV+vB8qP5Ju8crCeQmh+nFfJShMr4isaKN+lY7tkvpPP27QleJUlbA8b Ag3jSaQvkom0PYDIzjBxeAmzdwqHZgb4rn9h+i1IVkEQg+j3kQjHvUxB1pWnWIQAbRFicS ITZd+2V7T1w3TXQXd5G2qYbrT82BzExLDnLE97xxx+rHZynKa2t3GSw/X7vqLA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3BA91418F X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: AiMkscKTwpQo Hi Leo, Leo Prikler skribis: > Am Mittwoch, den 21.07.2021, 16:28 +0200 schrieb Ludovic Court=C3=A8s: [...] >> > +++ b/gnu/packages/patches/gnome-maps-really-do-unregister.patch >> > @@ -0,0 +1,13 @@ >> > +Index: gnome-maps-3.36.7/src/application.js >>=20 >> Could you add a line at the top of this patch saying what it does >> along with a link to the merge request above? > It turns out a similar fix already exists upstream [1], so if we decide > to backport that to 3.36 instead of bumping the package to 3.38, I > think we should pick the "official" one. Even better. >> Apart from that the two patches LGTM, especially if it allows me to >> use gnome-maps again. :-) > Do "the two patches" refer to this one alone or also to the one bumping > the package to 3.38? Both, but I hadn=E2=80=99t realized there=E2=80=99s was an exclusive choice. > Again, I'm a little unsure what would be the preferred solution here, > as either patch adds additional code that would probably need to be > reverted by Raghav in their GNOME 40 work. I don=E2=80=99t know, I think it=E2=80=99s good to have short-term fixes an= yway and it=E2=80=99s OK if they have to be undone when we eventually upgrade. Your call! Thanks, Ludo=E2=80=99.