From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EHd7DJlwQGG6ywAAgWs5BA (envelope-from ) for ; Tue, 14 Sep 2021 11:51:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EOEuCJlwQGG2XQAAB5/wlQ (envelope-from ) for ; Tue, 14 Sep 2021 09:51:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7887D12CC6 for ; Tue, 14 Sep 2021 11:51:20 +0200 (CEST) Received: from localhost ([::1]:60154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ55y-000157-JR for larch@yhetil.org; Tue, 14 Sep 2021 05:51:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ55j-00014J-Fv for guix-patches@gnu.org; Tue, 14 Sep 2021 05:51:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36046) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQ55j-0006lp-2q for guix-patches@gnu.org; Tue, 14 Sep 2021 05:51:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQ55j-0001Pc-1h for guix-patches@gnu.org; Tue, 14 Sep 2021 05:51:03 -0400 Subject: bug#50428: [PATCH] gnu: Add cryfs Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 14 Sep 2021 09:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 50428 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Brendan Tildesley Cc: 50428-done@debbugs.gnu.org Mail-Followup-To: 50428@debbugs.gnu.org, ludo@gnu.org, mail@brendan.scot Received: via spool by 50428-done@debbugs.gnu.org id=D50428.16316130395371 (code D ref 50428); Tue, 14 Sep 2021 09:51:02 +0000 Received: (at 50428-done) by debbugs.gnu.org; 14 Sep 2021 09:50:39 +0000 Received: from localhost ([127.0.0.1]:47587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ55K-0001OZ-VN for submit@debbugs.gnu.org; Tue, 14 Sep 2021 05:50:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQ55J-0001OM-EO for 50428-done@debbugs.gnu.org; Tue, 14 Sep 2021 05:50:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46500) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQ55D-0006IO-3U; Tue, 14 Sep 2021 05:50:31 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35592 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQ550-0007hW-3u; Tue, 14 Sep 2021 05:50:30 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210906133437.3691-1-mail@brendan.scot> Date: Tue, 14 Sep 2021 11:50:15 +0200 In-Reply-To: <20210906133437.3691-1-mail@brendan.scot> (Brendan Tildesley's message of "Mon, 6 Sep 2021 23:34:37 +1000") Message-ID: <87tuin5vvs.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631613081; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=vR0wJ3Uvpzn8fZqnCvNjazFvDF7uuJI1rLVjXcFmfYg=; b=hfcR4wyW/XywhbAqv2Xz2qE9CJGML24cc7sStIFAe4PGPNwGxMKIr9T/EPOvqNPh5546/X rJC1+8t6TPvZqPBjb/lqAFAlkgMAAXWOklJxXqdytpNABCWukQpwDvFIklw5C5YJTLlNpB fi+tpmRXi6OcVxvb9/FA8Famuh3jeHIW2etNKLR2d1tnwBzHcTQG1tIDqN2s4bV2eDeu1Q hFtjmWDI/FIc+W3A0Gpcja830jtY9RnhnjuYwibajZWz/89dOaxvwwZeUJXpKOk/wu3LJJ gJ7UuVBVKgrQaB1pxSpExQnz/PezV77jczcQcS80SxLzhMLjVqBPhUM3Kks/Sg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631613081; a=rsa-sha256; cv=none; b=aG6AAMe36sudpqFAX7Tup52uMdAlLhQUFELFgadrZZUnCi80xSDDH7K85XbOJPCQrQDkw6 ag4K8mKw2PG1VQrbbEhfEAR2jFsyJD52Vq5h80xLW5sajVud7g4KRza1EBM/WwSUHtj/0r HcRK7A8Y4Dzx6TL42Ss2I7aDpEDOfXkArT2rwpNvPGVPIGCaHHdJgcHaYdgXafpnqjlCBg Mv/vQODm1+Xj3QoK69wdjyX1m53HpUHU2/yatVR8jhHlmTjDRPcmsqUe5anvFt7zi1Vam+ 4UXdtG2dpq3zAFDJLHGYt06xMVeG/KRnhADuAcTWYNiwg00Rq2LVy+eFfEDrPg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.40 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7887D12CC6 X-Spam-Score: -1.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: ef2gi68JRgDF Hi, Brendan Tildesley skribis: > * gnu/packages/crypto.scm (cryfs): New variable. Overall LGTM modulo the minor issues below: > + '(#:configure-flags > + `("-DCRYFS_UPDATE_CHECKS=3DOFF" ;; Note: This also disables check= ing for security issues. > + "-DCMAKE_BUILD_TYPE=3DRelease" ;; Build man pages. Normally this is set by #:build-type. It defaults to =E2=80=9CRelWithDebIn= fo=E2=80=9D, which is nice because then you get debugging symbols if you pass =E2=80=98--with-debug-info=3Dcryfs=E2=80=99. So I=E2=80=99d suggest removi= ng this second flag. > + (replace 'check > + (lambda* (#:key tests? outputs #:allow-other-keys) > + (use-modules (srfi srfi-1)) Please use #:modules ((srfi srfi-1) =E2=80=A6) instead of this non-top-level =E2=80=98use-modules=E2=80=99 form. > + (when tests? > + (with-directory-excursion "/tmp/build/test" > + (let ((tests (find-files "." "-test$")) > + (tests-output (assoc-ref outputs "tests"))) > + ;; Install tests to a separate output so users can ru= n them. > + (copy-recursively "." tests-output) Installing tests is unusual. Do you really think it=E2=80=99s going to be useful? > + ;; XXX: Disable failing tests. Unfortunately there ar= e a > + ;; few. Some only fail in the build environment. ;; b= uild > + ;; environment. Typo. > + (description "CryFS encrypts your files, so you can safely store the= m anywhere. > + It works well together with cloud services like Dropbox, iCloud, OneDri= ve and ^ Extra space. :-) Could you send an updated patch? Thanks! Ludo=E2=80=99.