bug#51447: Guile-gi fails a few tests on core-updates-frozen

bug#51447: Guile-gi fails a few tests on core-updates-frozen

[Vivien Kraus via Bug reports for GNU Guix]

Dear guix,

For my program, I depend on guile-gi. However, the test/string.scm test
contains some characters that are not recognized by guile (I suggest
using (call-with-input-string "<the character>" read-char) instead of
#\<the character>), and once that’s fixed, more tests fail, for which I
have no solution.

Best regards,

Vivien

bug#51447: [PATCH] Re: bug#51447: guile-gi source code has a placeholder for a combining character

[Vivien Kraus via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]


The string failure is due to a dotted circle as a basis for the
combining character, that may have been inserted by a clever source code
editor. Replacing it with the hex value for the character itself, the
test passes.

Vivien


[-- Attachment #2: 0001-guile-gi-fix-a-source-code-encoding-error.patch --]
[-- Type: text/x-patch, Size: 1122 bytes --]

From 308bd116d75861c70f7540890a514b0eb487c2f7 Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Tue, 2 Nov 2021 18:19:03 +0100
Subject: [PATCH] guile-gi: fix a source code encoding error

* gnu/packages/guile-xyz.scm (guile-gi) [phases]: remove the default dotted
circle from the combining character that is tested in test/string.scm.
---
 gnu/packages/guile-xyz.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 3c93779209..6a401cda45 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -3145,6 +3145,10 @@ (define-public guile-gi
                   (ice-9 rdelim))
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'workaround-guile-reader-failure
+           (lambda* _
+             (substitute* "test/string.scm"
+               (("#\\\\◌̀") "#\\x0300"))))
          (add-after 'unpack 'patch-references-to-extension
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((effective (read-line
-- 
2.33.1

bug#51447: there’s no other test failing than string.scm

[Vivien Kraus via Bug reports for GNU Guix]

It turns out that the other failures only happen in a guix shell, not as
a package build in guix.

Vivien

bug#51447: [PATCH] Re: bug#51447: guile-gi source code has a placeholder for a combining character

[Vivien Kraus via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]


Vivien Kraus <vivien@planete-kraus.eu> writes:
> The string failure is due to a dotted circle as a basis for the
> combining character, that may have been inserted by a clever source code
> editor. Replacing it with the hex value for the character itself, the
> test passes.

Sorry, the phase name is not good, because it’s not a problem with the
guile reader but a problem with the source code. So, this should be
better.

Vivien

[-- Attachment #2: 0001-guile-gi-fix-a-source-code-encoding-error.patch --]
[-- Type: text/x-patch, Size: 1136 bytes --]

From ce832d8593413f4a812211f2fbd98ab5086fe2a2 Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Tue, 2 Nov 2021 18:19:03 +0100
Subject: [PATCH] guile-gi: fix a source code encoding error

* gnu/packages/guile-xyz.scm (guile-gi) [phases]: remove the default dotted
circle from the combining character that is tested in test/string.scm.
---
 gnu/packages/guile-xyz.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 3c93779209..8fc37d2069 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -3145,6 +3145,10 @@ (define-public guile-gi
                   (ice-9 rdelim))
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'remove-dotted-circle-from-combining-character
+           (lambda* _
+             (substitute* "test/string.scm"
+               (("#\\\\◌̀") "#\\x0300"))))
          (add-after 'unpack 'patch-references-to-extension
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((effective (read-line
-- 
2.33.1

bug#51447: More explanations for the fix

[Vivien Kraus via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 97 bytes --]


I was told that this issues gives headaches, so I added a short comment
explaining it.

Vivien


[-- Attachment #2: 0001-guile-gi-fix-a-source-code-encoding-error.patch --]
[-- Type: text/x-patch, Size: 1565 bytes --]

From 93224afab672465f3e8e1a6be00def0d5507bb76 Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Tue, 2 Nov 2021 18:19:03 +0100
Subject: [PATCH] guile-gi: fix a source code encoding error

* gnu/packages/guile-xyz.scm (guile-gi) [phases]: remove the default dotted
circle from the combining character that is tested in test/string.scm.
---
 gnu/packages/guile-xyz.scm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 3c93779209..1ef872ffe1 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -3145,6 +3145,16 @@ (define-public guile-gi
                   (ice-9 rdelim))
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'remove-dotted-circle-from-combining-character
+           ;; The test/string.scm files contain ◌̀, which is a dotted circle
+           ;; (U+25cc) followed by an upper combining character (U+0300). The
+           ;; old guile 3.0.2 reader incorrectly ignores the dotted circle,
+           ;; and parses it as the combining character alone, but the new
+           ;; guile reader does not.
+           ;; See https://github.com/spk121/guile-gi/issues/112
+           (lambda* _
+             (substitute* "test/string.scm"
+               (("#\\\\◌̀") "#\\x0300"))))
          (add-after 'unpack 'patch-references-to-extension
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((effective (read-line
-- 
2.33.1

bug#51447: More explanations for the fix

[Tobias Geerinckx-Rice via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

Vivien,

Vivien Kraus via Bug reports for GNU Guix 写道：
> I was told that this issues gives headaches, so I added a short 
> comment
> explaining it.

Thanks, I feel a better already.  Pushed as 
6c39c131b74651e3019cd199061fcfc3607ba198.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]