From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YFPMOZHXqGFcOwAAgWs5BA (envelope-from ) for ; Thu, 02 Dec 2021 15:26:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KDCfNZHXqGGcTwAA1q6Kng (envelope-from ) for ; Thu, 02 Dec 2021 14:26:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A3C420BFC for ; Thu, 2 Dec 2021 15:26:24 +0100 (CET) Received: from localhost ([::1]:60078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msn2V-0001bM-Kr for larch@yhetil.org; Thu, 02 Dec 2021 09:26:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msn2A-0001a7-MM for guix-patches@gnu.org; Thu, 02 Dec 2021 09:26:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35476) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1msn2A-00029d-Ex for guix-patches@gnu.org; Thu, 02 Dec 2021 09:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1msn2A-0007O2-BE for guix-patches@gnu.org; Thu, 02 Dec 2021 09:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52204] [PATCH] guix system vm: Add --no-graphic CLI argument. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Dec 2021 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Attila Lendvai Cc: 52204@debbugs.gnu.org Received: via spool by 52204-submit@debbugs.gnu.org id=B52204.163845510928326 (code B ref 52204); Thu, 02 Dec 2021 14:26:02 +0000 Received: (at 52204) by debbugs.gnu.org; 2 Dec 2021 14:25:09 +0000 Received: from localhost ([127.0.0.1]:47021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msn1I-0007Mo-UB for submit@debbugs.gnu.org; Thu, 02 Dec 2021 09:25:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msn1G-0007MR-TI for 52204@debbugs.gnu.org; Thu, 02 Dec 2021 09:25:07 -0500 Received: from [2001:470:142:3::e] (port=45972 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msn1B-0001pU-Hp; Thu, 02 Dec 2021 09:25:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=L8lOFOzpROU+/f8QhD9IRmFXdWHA9GDhL2K0I0yyK3Q=; b=H031crq/pMBg3Uu73CpW MU4G1xfXzlbHihBIGzOTZdQi1Xgd5I2IUHZJGl2VakSRJz23zND2LJj1YR8ETHVR7a0YNXIru+Af6 atc8GjhA2kU82Fvv25L7hkgShBBuv6KBYiWZJPc5NC9UL6wNa9kWCO5BDeaNBld9+5rYhYkasNbAi fFZYVJWAchwOMLP0C0EeOKqX58QZdNeej8fIJCMHqR4CfSoC+w4Hp1THQjkdd4I9TlXoI5fhRfq0P FpUFGsfXhvPNgy9lgFSLDqAjX7Jbgg2X1bPqgt+EHRkmi5KY+rkwlqO+iXHJberrbI33K6K3joSlQ YVSGiAWEK0/glw==; Received: from [2a01:e0a:19b:d9a0:2ddb:d3d2:32e8:d31a] (port=48720 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msn17-0006c8-2c; Thu, 02 Dec 2021 09:24:59 -0500 From: Mathieu Othacehe References: <20211130191312.32131-1-attila@lendvai.name> Date: Thu, 02 Dec 2021 15:24:55 +0100 In-Reply-To: <20211130191312.32131-1-attila@lendvai.name> (Attila Lendvai's message of "Tue, 30 Nov 2021 20:13:13 +0100") Message-ID: <87tufrw0co.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638455184; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=L8lOFOzpROU+/f8QhD9IRmFXdWHA9GDhL2K0I0yyK3Q=; b=MaPWLACSDeiEBaA3xU0a9rzt/NiCvFYC6yPaoXR5hIkDnSWD7PMCRt0WhNQHxVIAB6yeCz PNtPTCPXyo9VAAthyqv7Ffuccat+AkgtRvyr+MRn/DAWdJx4sM0nFR1CswYCfNIrm9wY0B 5eKrqnkGBsncVbPB4mWZms1Htxt1fstnRqVOAHPKJDinWV9PCtHbfxRk/wCpYyOQ4TmbhN 7T6PwWTOzuddHSBmLu4bVDiDmSyUgXeb9wOUY/GLxNbv1E/XGmF9PtRanrEs9fErFcuYu+ tV2+NP4Py2FXqFco7LLJXhAtpW88DWtvZr6g0xkvgipYd2AlRVGbcLw/p5HN/w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638455184; a=rsa-sha256; cv=none; b=CprKhvBHsj03zfOE+C2wkIQ06p2SrE9Kk29RHJ4M6Jst0qIvg6GLB033pGVrzpugIMg3bL nAjn1erNNMydS2gkC9hHsIAr+ZshnDOYpFhHNAEiKbtjOvP9Xzt+yoHzIDNZ4SiDD34zHL c7GIWrckhzqtiDgcqqokoCdWPO2ryHjwYU4twbr6AMhGqywiMP95CpnuYAhCV7u6JmgnA9 E29ORzITM0guJbYgD8HOjYEDJclS8qUDCLwJw8/xjEniy/FfhR/J6Dbnos0N98C4xG9ore 5AQoOQeYVFKqlCnhdX8IKeTX476ZIb/39eJ6fl3s5bPHdESBfUcrGNIQhksQRQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="H031crq/"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.62 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="H031crq/"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7A3C420BFC X-Spam-Score: -3.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: XrIrvt73/LT6 Hello, > * gnu/system/vm.scm (system-qemu-image/shared-store-script): Also add the > '-nographic' qemu argument when called with #:graphic? #false. > * guix/scripts/system.scm (system-derivation-for-action): Propagate > the #:graphic? keyword arg. > (perform-action): Add and propagate the #:graphic? keyword arg. > (show-help): Add --no-graphic CLI arg. > (%options): Process the new --no-graphic CLI arg. > (process-action): Feed in the CLI arg through the #:graphic? keyword arg. This looks fine. Could you send an updated patch with the associated documentation update? Thanks, Mathieu