all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Attila Lendvai <attila@lendvai.name>
Cc: 52204@debbugs.gnu.org
Subject: [bug#52204] [PATCH] guix system vm: Add --no-graphic CLI argument.
Date: Thu, 02 Dec 2021 15:24:55 +0100	[thread overview]
Message-ID: <87tufrw0co.fsf@gnu.org> (raw)
In-Reply-To: <20211130191312.32131-1-attila@lendvai.name> (Attila Lendvai's message of "Tue, 30 Nov 2021 20:13:13 +0100")


Hello,

> * gnu/system/vm.scm (system-qemu-image/shared-store-script): Also add the
> '-nographic' qemu argument when called with #:graphic? #false.
> * guix/scripts/system.scm (system-derivation-for-action): Propagate
> the #:graphic? keyword arg.
> (perform-action): Add and propagate the #:graphic? keyword arg.
> (show-help): Add --no-graphic CLI arg.
> (%options): Process the new --no-graphic CLI arg.
> (process-action): Feed in the CLI arg through the #:graphic? keyword arg.

This looks fine. Could you send an updated patch with the associated
documentation update?

Thanks,

Mathieu




  reply	other threads:[~2021-12-02 14:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30 19:13 [bug#52204] [PATCH] guix system vm: Add --no-graphic CLI argument Attila Lendvai
2021-12-02 14:24 ` Mathieu Othacehe [this message]
2021-12-02 19:09 ` [bug#52204] [PATCH 2/2] doc: Document guix system --no-graphic Attila Lendvai
2021-12-02 19:18 ` [bug#52204] [PATCH v2] guix system vm: Add --no-graphic CLI argument Attila Lendvai
2021-12-03 10:38   ` [bug#52204] [PATCH] " Mathieu Othacehe
2021-12-03 12:22 ` [bug#52204] [PATCH v3] " Attila Lendvai
2021-12-03 13:34   ` bug#52204: [PATCH] " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tufrw0co.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=52204@debbugs.gnu.org \
    --cc=attila@lendvai.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.