From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GKlnLJ02wmHrSwEAgWs5BA (envelope-from ) for ; Tue, 21 Dec 2021 21:18:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kA7aJ502wmF0XgAAbx9fmQ (envelope-from ) for ; Tue, 21 Dec 2021 20:18:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6D08BE34E for ; Tue, 21 Dec 2021 21:18:37 +0100 (CET) Received: from localhost ([::1]:41478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzlam-0001OW-L3 for larch@yhetil.org; Tue, 21 Dec 2021 15:18:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzlaF-0001Ml-2j for guix-patches@gnu.org; Tue, 21 Dec 2021 15:18:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44239) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzlaE-0001NK-Pd for guix-patches@gnu.org; Tue, 21 Dec 2021 15:18:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mzlaE-0001ze-Iw for guix-patches@gnu.org; Tue, 21 Dec 2021 15:18:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52174] [PATCH v2 1/6] gnu: add crun Resent-From: Timmy Douglas Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Dec 2021 20:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52174 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 52174@debbugs.gnu.org Received: via spool by 52174-submit@debbugs.gnu.org id=B52174.16401178406658 (code B ref 52174); Tue, 21 Dec 2021 20:18:02 +0000 Received: (at 52174) by debbugs.gnu.org; 21 Dec 2021 20:17:20 +0000 Received: from localhost ([127.0.0.1]:55779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzlZY-0001iu-14 for submit@debbugs.gnu.org; Tue, 21 Dec 2021 15:17:20 -0500 Received: from out2.migadu.com ([188.165.223.204]:17534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzlZS-0001eA-5f for 52174@debbugs.gnu.org; Tue, 21 Dec 2021 15:17:19 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timmydouglas.com; s=key1; t=1640117833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3cAGP8ftNPdlq63EmONE8SuZB5L8p1lxBqfQT+V1CVY=; b=dCyxYUkmJUdoni6w1PMR5JNWkJ66ppYZurktl/kgvaoM9OFIHaFLW4FBA6vcR3cms0hIvr 9iZWnkNH23DUjfKr5Dyhw3Ox5Ci8hDMVvy6SRqaXwOxGTalC/iC63VeLrLOXd7gZBUJ0OT Ebr0Vvd5oodGI6h+MaWkCR76AmPtuv0= In-Reply-To: <875yrjl8a5.fsf@gnu.org> References: <874k75pzi7.fsf@gnu.org> <52542aec3c127a893453ac1ecbbd504022d4c8dd.1639889841.git.mail@timmydouglas.com> <875yrjl8a5.fsf@gnu.org> Date: Tue, 21 Dec 2021 12:17:10 -0800 Message-ID: <87tuf1zpa1.fsf@timmydouglas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Timmy Douglas X-ACL-Warn: , Timmy Douglas via Guix-patches From: Timmy Douglas via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640117917; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3cAGP8ftNPdlq63EmONE8SuZB5L8p1lxBqfQT+V1CVY=; b=Co+ddh9zJgBpkJGkp6wmPX2G3JCtJPQLxO3hY3eJoweV5SznS+jvyI2IKMPs/N085rTPri OL3Vt7LsTBAos2JXyScjBO8LE6vCCbgL05f0/KL+i2jYPOdmSW6d1mJl6w1nTo5sqZKl4E 2Rocd0pgF2ljGTvnKfCMeEIQBrbUu4aLAVVeX+yvLZSmKcQgCC1hr/dAW06eBl961uuzbW sZ82T0owALP0a7KcYJ18RFkWzxmQWCOQDYhnsom+W6KxxfCWHnXWGp3KamaGeUmg/6iSc5 1LK1qrF4xrW3W4ZYuCJtZdJ7mMsFFc6GknZGdIdB9voRORdWn5eWygWYtjx2ag== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640117917; a=rsa-sha256; cv=none; b=j4hbmvtIPRhI/0pkFW80kPoKDYBHBcfwp96OAgVUhltsDTpL3jYkFD5lnhTdXbrAdSvAer 96lcVA3Me2WTeMAeDJoACpG636OzbEcI7MQsdjwRPvX0H5f3V3IGwdPgWg6ZWM2sJZgpmR I9i7ibpQ8WBxCQa4zVBgsQG5+lSRoMpLI/iCvM6Accn6KtRpDG1w9Lb14LT+LQw8W09Rhu woRoAwvENRYJPhfOUDM/5HnSNHxxWdzRnBO2r6UEfciuw1SPbG5HqNDGZPAKFvR91WHa1J B+v5bdnuIWsLlvRh3lKvVwYFY79wbcQvMrNxQnzldWEWljrHWQb7Y5yYyuusgg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=timmydouglas.com header.s=key1 header.b=dCyxYUkm; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=timmydouglas.com header.s=key1 header.b=dCyxYUkm; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6D08BE34E X-Spam-Score: -4.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: uIPpJw27yYi0 Ludovic Court=C3=A8s writes: > Hi, > > Timmy Douglas skribis: > >> * gnu/packages/containers.scm: new file >> * gnu/local.mk: add containers.scm > > [...] > >> + (arguments >> + `(#:tests? #f > > Sorry for not noticing earlier: we try hard to run test suites, and only > disable it as a last resort, with a comment explaining why. Often, we > disable specific tests that cannot run in the build environment (for > instance because they assume network access) and run everything else. > > I had a quick go at running crun=E2=80=99s test suite, and there=E2=80=99= s a number of > failures, which is not reassuring. > > Could you investigate a bit with the goal of fixing any actual issues > the test suite reveals and/or skipping individual tests that cannot be > run? are there some docs I could refer to on how Guix sandboxes the build? I tried https://guix.gnu.org/manual/en/html_node/Debugging-Build-Failures.html#Debu= gging-Build-Failures but I think I need to go further than sourcing env vars. I tried modifying `make check` phase to invoking `mount` to see if I could poke around (which didn't exactly work in my quick attempt...) because I'm not sure how to debug some of the issues. I suspect some are due to the fs layout/mounts. Probably could figure it out with some more time but thought it might be best to ask first. With these changes I could get them to pass by manually `make check`ing in the --keep-failed directory: (add-after 'unpack 'fix-tests (lambda _ (substitute* (find-files "tests" "\\.(c|py)") (("/bin/true") (which "true")) (("/bin/false") (which "false")) ; relies on sd_notify which requires systemd? (("\"sd-notify\" : test_sd_notify,") "") (("\"sd-notify-file\" : test_sd_notify_file,") ""))))))) from guix build: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D Testsuite summary for crun UNKNOWN =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D # TOTAL: 73 # PASS: 9 # SKIP: 28 # XFAIL: 0 # FAIL: 36 # XPASS: 0 # ERROR: 0 from cd /tmp/guix-build-crun-1.3.drv-5/source && make check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D Testsuite summary for crun UNKNOWN =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D # TOTAL: 73 # PASS: 40 # SKIP: 33 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 > Nitpick: You can omit the trailing #t now (yay!). great!