From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MEcdNMii5GGZLQEAgWs5BA (envelope-from ) for ; Sun, 16 Jan 2022 23:57:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GOeYMMii5GFvKAAAauVa8A (envelope-from ) for ; Sun, 16 Jan 2022 23:57:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 74FC52199E for ; Sun, 16 Jan 2022 23:57:12 +0100 (CET) Received: from localhost ([::1]:46412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9ESV-0005er-KD for larch@yhetil.org; Sun, 16 Jan 2022 17:57:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59302) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9ESM-0005ch-04 for guix-patches@gnu.org; Sun, 16 Jan 2022 17:57:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51530) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9ESL-0004yO-M4 for guix-patches@gnu.org; Sun, 16 Jan 2022 17:57:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n9ESL-0005dK-IU for guix-patches@gnu.org; Sun, 16 Jan 2022 17:57:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53279] [PATCH] gnu: Add emacs-dtache Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 16 Jan 2022 22:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53279 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Niklas Eklund Cc: 53279@debbugs.gnu.org Received: via spool by 53279-submit@debbugs.gnu.org id=B53279.164237378521607 (code B ref 53279); Sun, 16 Jan 2022 22:57:01 +0000 Received: (at 53279) by debbugs.gnu.org; 16 Jan 2022 22:56:25 +0000 Received: from localhost ([127.0.0.1]:44433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9ERk-0005cR-Rg for submit@debbugs.gnu.org; Sun, 16 Jan 2022 17:56:25 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:41517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9ERi-0005cC-Af for 53279@debbugs.gnu.org; Sun, 16 Jan 2022 17:56:23 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 6C011FF802; Sun, 16 Jan 2022 22:56:15 +0000 (UTC) From: Nicolas Goaziou References: <87pmotpfam.fsf@posteo.net> <87czktkr40.fsf@posteo.net> <877db13p1e.fsf@posteo.net> <87a6fw3fxa.fsf@nicolasgoaziou.fr> <87ee587itt.fsf@posteo.net> Date: Sun, 16 Jan 2022 23:56:14 +0100 In-Reply-To: <87ee587itt.fsf@posteo.net> (Niklas Eklund's message of "Sat, 15 Jan 2022 22:08:46 +0000") Message-ID: <87tue3i92p.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642373832; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=zdjtdrKv0yCzOoWU6e+GydimtbQfr0WgqYix0Ka1yJM=; b=f06A7uEDVoZ7poEelj7shrvGJVzrVtxciLPdD5iIIuZ07fFpv+Ppjn0B2+ilqlfNMhEBe5 jVvk4JSM07BIhkXv9fN+rr9Ekb7ZCvaMtCIUSMwX1NaN6mlTCTenn0UyVlaqya0hHo0uOx S7neixLKd1w7uAEk4g1dMDzi8+8nMyPsc6PCe2SonwqLtxhRksnevBt+RwhFIBgAyBu9e9 1gkix1rd7AUsJQRMLlL+YIgwZCtwMYhLT2tYN+psJJsx8z+9mghO1QpNmcs90S7VUFKCcn GtJz3j8/DoFJjOH0b2rRWX4mgBm6PkbYYFlh2oNHrZnSP8X57hebPmLTve31Hw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642373832; a=rsa-sha256; cv=none; b=YKYbuIraGmtJli3kBseLsW6IIgrNGdd3w13x5lavMKQSP+AykEOGyCWls4TnM1azW6Y7aD x9ihe4RRc139cAaU76J+ZuiSZDmmhmscysYk1A/cjxqPU5hXeBDCtOD+wGI3awfUUiJsOX FQj6LBNc6jaxq6KtPphVcgPRBKr7lwkDzxsAKUHHfTqix/6St5cNvQsZVWq3jwoVBrWZAA cJbiquz8+rAoYvNjEjhR4E4mV/xH0e9Z+SL0p0t6/B8Z+aO9KvV1rz+WNHEglOdkbmCO8x 4GK27CJSrXJl1iIT0AMcicOy8Vpm90+gILYYxbZ+Vfwd241OjWI48wDQmRvgtA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.22 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 74FC52199E X-Spam-Score: -3.22 X-Migadu-Scanner: scn1.migadu.com X-TUID: 89kH+Js5pUrD Hello, Niklas Eklund writes: > Ah good to know, I have updated that part now. Thanks for the update. I merged the consecutive phases with emacs-substitute-variables for clarity, and enabled tests with "#:tests? #true". I'm sending the package definition in its current state: --8<---------------cut here---------------start------------->8--- (define-public emacs-dtache (package (name "emacs-dtache") (version "0.3") (source (origin (method git-fetch) (uri (git-reference (url "https://gitlab.com/niklaseklund/dtache") (commit version))) (file-name (git-file-name name version)) (sha256 (base32 "0f2yxrqfkslif2y88x9vlpshadifppxw6yl1rrf1qzfjy6cv144n")))) (arguments (list #:tests? #true #:test-command #~(list "ert-runner") #:phases #~(modify-phases %standard-phases (add-before 'install 'install-dtache-env (lambda _ (install-file "dtache-env" (string-append #$output "/bin")))) (add-after 'unpack 'locate-dtach (lambda* (#:key inputs #:allow-other-keys) (make-file-writable "dtache.el") (emacs-substitute-variables "dtache.el" ("dtache-env" (string-append #$output "/bin/dtache-env")) ("dtache-dtach-program" (search-input-file inputs "/bin/dtach")) ("dtache-shell-program" (search-input-file inputs "/bin/bash")))))))) (build-system emacs-build-system) (native-inputs (list emacs-ert-runner)) (inputs (list dtach)) (home-page "https://gitlab.com/niklaseklund/dtache") (synopsis "Run and interact with detached shell commands") (description "The dtache package allows users to run shell commands detached from Emacs. These commands are launched in sessions, using the program dtach.") (license license:gpl3+))) --8<---------------cut here---------------end--------------->8--- Unfortunately, one test is failing with the following output: --8<---------------cut here---------------start------------->8--- .......Test dtache-test-dtach-command backtrace: Test dtache-test-dtach-command condition: (ert-test-failed ((should (equal expected-concat (dtache-dtach-command session t))) :form (equal "dtach -c /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.socket -z bash -c \\{\\ dtache-env\\ ls\\\\\\ -la\\;\\ \\}\\ 2\\>\\&1\\ \\|\\ tee\\ /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.log" "/gnu/store/prhk20g1yp8qbn4rj5h25cdpimxynq3d-dtach-0.9/bin/dtach -c /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.socket -z bash -c \\{\\ dtache-env\\ ls\\\\\\ -la\\;\\ \\}\\ 2\\>\\&1\\ \\|\\ tee\\ /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.log") :value nil :explanation (arrays-of-different-length 268 326 "dtach -c /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.socket -z bash -c \\{\\ dtache-env\\ ls\\\\\\ -la\\;\\ \\}\\ 2\\>\\&1\\ \\|\\ tee\\ /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.log" "/gnu/store/prhk20g1yp8qbn4rj5h25cdpimxynq3d-dtach-0.9/bin/dtach -c /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.socket -z bash -c \\{\\ dtache-env\\ ls\\\\\\ -la\\;\\ \\}\\ 2\\>\\&1\\ \\|\\ tee\\ /tmp/guix-build-emacs-dtache-0.3.drv-0/dtache7Dw27E/sessions/7695240f5262181009a25db676161039.log" first-mismatch-at 0))) F................ --8<---------------cut here---------------end--------------->8--- Do you think this can be fixed? Or shall we skip that test? Regards, -- Nicolas Goaziou