From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 54668-done@debbugs.gnu.org
Subject: bug#54668: [PATCH 0/3] Turn diagnostic locations into hyperlinks
Date: Sat, 09 Apr 2022 00:02:15 +0200 [thread overview]
Message-ID: <87tub38c9k.fsf_-_@gnu.org> (raw)
In-Reply-To: <875ynpuk0t.fsf_-_@gnu.org> ("Ludovic Courtès"'s message of "Mon, 04 Apr 2022 14:10:10 +0200")
Hi,
Pushed as 13307c198bcd1fbd9364bcb7ef4c6d19d287cf2c!
Ludovic Courtès <ludo@gnu.org> skribis:
> Maxime Devos <maximedevos@telenet.be> skribis:
>
>> Ludovic Courtès schreef op vr 01-04-2022 om 17:01 [+0200]:
>>>
>>> +(define (hyperlink uri text)
>>> + "Return a string that denotes a hyperlink using an OSC escape sequence as
>>> +documented at
>>> +<https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda>."
>>> + (string-append "\x1b]8;;" uri "\x1b\\"
>>> + text "\x1b]8;;\x1b\\"))
>
> (This code was already there.)
>
>> What if 'uri' contains the character #\x1b, e.g.
>> "file://home/foo/\x15.scm"? Does it need to be escaped?
>
> Good question. I checked the spec linked above and it reads:
>
> URI is the target of the hyperlink in URI-encoded form.
>
> So I guess we should pass ‘uri’ through ‘uri-encode’. I’ll do that in a
> separate patch.
Actually this is already done by ‘file-hyperlink’ a few lines below, so
we’re fine.
Thanks,
Ludo’.
next prev parent reply other threads:[~2022-04-08 22:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 14:59 [bug#54668] [PATCH 0/3] Turn diagnostic locations into hyperlinks Ludovic Courtès
2022-04-01 15:01 ` [bug#54668] [PATCH 1/3] ui: Move hyperlink facilities to (guix colors) Ludovic Courtès
2022-04-01 15:01 ` [bug#54668] [PATCH 2/3] ui: Move 'location->hyperlink' to (guix diagnostics) Ludovic Courtès
2022-04-01 15:01 ` [bug#54668] [PATCH 3/3] diagnostics: Turn diagnostic locations into hyperlinks Ludovic Courtès
2022-04-01 15:44 ` [bug#54668] [PATCH 1/3] ui: Move hyperlink facilities to (guix colors) Maxime Devos
2022-04-04 12:10 ` [bug#54668] [PATCH 0/3] Turn diagnostic locations into hyperlinks Ludovic Courtès
2022-04-08 22:02 ` Ludovic Courtès [this message]
2022-04-09 9:27 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tub38c9k.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=54668-done@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.