From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aGLzI3/geGKTCQAAbAwnHQ (envelope-from ) for ; Mon, 09 May 2022 11:35:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yPccI3/geGJTpQAAG6o9tA (envelope-from ) for ; Mon, 09 May 2022 11:35:59 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 328253D633 for ; Mon, 9 May 2022 11:35:59 +0200 (CEST) Received: from localhost ([::1]:37862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnzo4-0000kI-Kp for larch@yhetil.org; Mon, 09 May 2022 05:35:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnziO-0007D4-6y for guix-patches@gnu.org; Mon, 09 May 2022 05:30:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33958) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nnziM-0001QD-Li for guix-patches@gnu.org; Mon, 09 May 2022 05:30:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nnziM-0008W1-Hd for guix-patches@gnu.org; Mon, 09 May 2022 05:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55188] [PATCH] gnu: Add python-vitables. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 09 May 2022 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55188 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Peter Polidoro Cc: 55188@debbugs.gnu.org Received: via spool by 55188-submit@debbugs.gnu.org id=B55188.165208858832681 (code B ref 55188); Mon, 09 May 2022 09:30:02 +0000 Received: (at 55188) by debbugs.gnu.org; 9 May 2022 09:29:48 +0000 Received: from localhost ([127.0.0.1]:56083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnzi8-0008V0-D8 for submit@debbugs.gnu.org; Mon, 09 May 2022 05:29:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnzi7-0008Uj-3w for 55188@debbugs.gnu.org; Mon, 09 May 2022 05:29:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnzi1-0001Mt-KF; Mon, 09 May 2022 05:29:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=2ByNRVoTQA52eZc9ExERtd4/M/XZwFo3c/1FyOmer2s=; b=DSp7+rtSOrfdzrdlWsxQ MoA3AtnJPYrVI4yhA2juiiQxDo2k2VwGJQc+OlGwXSSH2FTwmqcDcPigUA7F+hJQFOftC0VevEx1U 9+Mkuqg32pMztg+jlHaHG9SPBmui3ZbVkCHzYUM9a3I8357ClaZaW27JX+QYO2Pp057M23V6eQPOh Ht1h0iGX2oHGMaZnYDi7DmWcqVi73gS+SfJqdkLRZsJWKqjC/OPPut6lh5RxjsqjpvsezUSAm/TBX OKpFTtBEGGA6akmrPfTARQIKtUlZ3uEeMeSe6GqO90rlrH5IjL5GhSae/8OI1Uu/trnAQtfxc6ugA dffcZlwqwT26rg==; Received: from 71.125.192.77.rev.sfr.net ([77.192.125.71]:34014 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnzi0-0003Oy-SQ; Mon, 09 May 2022 05:29:41 -0400 From: Mathieu Othacehe References: <86levnizgk.fsf@polidoro.io> Date: Mon, 09 May 2022 11:29:38 +0200 In-Reply-To: <86levnizgk.fsf@polidoro.io> (Peter Polidoro's message of "Fri, 29 Apr 2022 13:13:38 -0400") Message-ID: <87tu9zjbp9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652088959; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=2ByNRVoTQA52eZc9ExERtd4/M/XZwFo3c/1FyOmer2s=; b=KzUB33azG0DhmGoWPHqIGivYLHK8j1m4uSkk2ZHjf5iAFBqkyogKZg5pdCnbw7XrCzX6Hm 3sYhlo4yHXg9+59n3CHkxx3j13k3PfgXT93C8hgoF5OYkVo/aMlEfOfHVyy/wJL7bABl1A WuH8sF3cUyF4nGrJvtCExa8KYIGImfDgX+PvfCcO/lMScwbAmr2Z+P35l34S4TDOsPklTV IKVnIBr40m3lyNdtgfoW1c1ZT7wL/9u8MJmXL2VFTyVf7OS4h2wqI7puJd69/VLR/lgnUX wdiH07/LhEQtaB/OWEU/9A5ZHHUSKS+GZwovXnFSbMks42Bwqnvzc0gqerK0gw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652088959; a=rsa-sha256; cv=none; b=FBUMaKW8qgXs+m2fa3Uf41H5iU+x/fGB0EknEIYcx2H8boP9QOTkugYVVvauVDE1hncK/+ mzUWeIt9CE1lbLo/RsOIZ7eeccEw6tpMDysoIsSfh2bybEux8pvRdZf5FlqwNl+KVlr3rb E4hy5JVbpyQ3m9SZTliKEbylVUw19S5RB8DctAFMfXbZZ7STjZShQP2F/jDX0T2vnhHK4Y lzIIKVrAmy8G8BvyST9w5pl/1vSL1n/BMpdW2rdm4+JphuhYbabWoonT4/65mqK9Gslqe6 Xfr0CqShpzlgt3kxcK+mfOl+2vxjxNrMeB3H0FkmszMa+VQLufuUgX3oOrDdwA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=DSp7+rtS; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.70 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=DSp7+rtS; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 328253D633 X-Spam-Score: -4.70 X-Migadu-Scanner: scn0.migadu.com X-TUID: PczYwf8nq4nb Hello Peter, > + (arguments > + `(#:tests? #f)) You should add a comment stating why the tests are disabled. Because there are no tests or because they are failing, and if so why? > + (description "ViTables is a GUI for browsing and editing files in both > +PyTables and HDF5 formats. ViTables capabilities include easy navigation > +through the data hierarchy, displaying of real data and its associated > +metadata, a simple, yet powerful, browsing of multidimensional data and much > +more. As a viewer, one of the greatest strengths of ViTables is its ability to > +display very large datasets.") > + (license license:gpl3))) The description could be more neutral: you could remove the "yet powerful" and "much more" parts. The last sentence could also be reworded: "As a viewer, ViTables is able to display very large datasets." feels more factual. Could you send an updated patch :) ? Thanks, Mathieu