From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8AtNEb4AnWKQHwEAbAwnHQ (envelope-from ) for ; Sun, 05 Jun 2022 21:15:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CElXEb4AnWKt+gAA9RJhRA (envelope-from ) for ; Sun, 05 Jun 2022 21:15:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DD0B73E92A for ; Sun, 5 Jun 2022 21:15:08 +0200 (CEST) Received: from localhost ([::1]:43748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxviN-0004ra-Mn for larch@yhetil.org; Sun, 05 Jun 2022 15:15:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxviI-0004rP-8I for guix-patches@gnu.org; Sun, 05 Jun 2022 15:15:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39596) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nxviH-0007NK-Uq for guix-patches@gnu.org; Sun, 05 Jun 2022 15:15:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nxviH-0004AJ-OI for guix-patches@gnu.org; Sun, 05 Jun 2022 15:15:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55545] [PATCH] Get ~emacs-promise~ to build in emacs 28 Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 05 Jun 2022 19:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55545 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Patterson Cc: 55545@debbugs.gnu.org Received: via spool by 55545-submit@debbugs.gnu.org id=B55545.165445649415985 (code B ref 55545); Sun, 05 Jun 2022 19:15:01 +0000 Received: (at 55545) by debbugs.gnu.org; 5 Jun 2022 19:14:54 +0000 Received: from localhost ([127.0.0.1]:33493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxvi9-00049i-T4 for submit@debbugs.gnu.org; Sun, 05 Jun 2022 15:14:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxvi2-00049O-Kq for 55545@debbugs.gnu.org; Sun, 05 Jun 2022 15:14:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49090) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxvhx-0007M7-8K; Sun, 05 Jun 2022 15:14:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=XYTlrNKKqayMnCztvJdOuBNCKDSG9CcdOYp+WTFrllE=; b=TIne1Xr+ff8m8k3HQWUy ueBTwtn5k++2o8WtSbrQfAJLC7LpHxtCx/i/Gm54zUo8EnA+ArsKXmDN3XS9VYxkrvenEsIOjOAMS Knfh5bOLWvZcK0mBmXuIQG1HsySIJ3knERo2T67n5NRrnjq1PMLNBIYME0ldr6JXuNzo2kX/8JGtB Kkemc+Jihb0qhLVQe70wjUUQhi6arRIyY0NfygzKfvbZSXn459bOm9+r1U1Myoe5h49tgMOqebxQ+ RaZWPek/DANygirbq2LRBkeFdfLfjT+IxB8pNTxNvIxe/Qpw9tAUueNphevWb7VpaKMap4QRovoJp NfHUSZjEJYTolQ==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2774.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2774]:36904 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxvhw-0005sb-LE; Sun, 05 Jun 2022 15:14:41 -0400 From: Mathieu Othacehe References: <87fsl4x9hy.fsf@gmail.com> Date: Sun, 05 Jun 2022 21:14:38 +0200 In-Reply-To: <87fsl4x9hy.fsf@gmail.com> (Andrew Patterson's message of "Fri, 20 May 2022 15:55:10 -0400") Message-ID: <87tu8yncrl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654456508; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=XYTlrNKKqayMnCztvJdOuBNCKDSG9CcdOYp+WTFrllE=; b=KvNRCtGmqKUAT/6CsqzVRK4LpyKVR2OK5Sc+rrnHNOyVpqCQw0UqGhFE9aqn1Le5KQK3EP dB6g6ZZxcNfGYRA/3+S/j0IvIrvasqhB1R5dkpicvIUD9HRdRXKB5/MJH3EfxYoPwQMdoF SkaCdeuuTOojHQzr/y3vp6dyFmzYLH5s63laM/9+1GqTeOyxWf03c3Y4SqWt1LgGRlAlYJ WTwIZAljItszpR1UC7sXaWP77Wt0DN0aOU1L7dAO1lL3okkmx50LsLSLNLTcCwn896zAHA zV0XSCvc5CwbR0+7YmUgkrASqAYZnfipAgN0ZQy50KhCQoe1iQPVhFQNFlnIkw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654456508; a=rsa-sha256; cv=none; b=Ky62jr8t0nBTwL72/4KB+QJjyiBkbPbgC87INdfF9e7v80MTtIQyVlZ8mo2wOVn6MoQcIG q39hMcGcdwPP+x6NpdQJDe99mMj4/KKpr3a9neKaegaUuJWCq4fiEtM2Oo+KOpslJPtPzG nUjjWexd4/zeJzQH5KNz7krKZNz+orGm50NcXbaTzE1WYxJoV7AQRCPpvZZTv2E+YVMC2y NGo8HPacMCw4Z+wRoUcumbFx4xWAJ/r1gTL1ioIIuXx6qjnYhYUBGc47H4qdA29Z6ysYnQ bBFID0stWlFrjUXWjmjWj3oqUBwYvcllSkH3CxGHd4N1cpqEgMCwjjKwEmPCmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=TIne1Xr+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=TIne1Xr+; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DD0B73E92A X-Spam-Score: -2.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: +1/muB3sh3+I Hello Andrew, > - (source > - (origin > - (method git-fetch) > - (uri (git-reference > - (url "https://github.com/chuntaro/emacs-promise") > - (commit version))) > - (file-name (git-file-name name version)) > - (sha256 > - (base32 "1xb34zdbwjvahfhycjphdkm925kgd22dr298c57hwxza4ljc2hxj")))) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/chuntaro/emacs-promise") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1xb34zdbwjvahfhycjphdkm925kgd22dr298c57hwxza4ljc2hxj")))) This change is not related to the build fix, it shouldn't be part of this commit. > (build-system emacs-build-system) > + (arguments > + `(#:phases (modify-phases %standard-phases > + (add-after 'unpack 'patch-obsolete > + (lambda* _ > + (substitute* "promise.el" > + (("\\(define-obsolete-function-alias (.*) (.*)\\)" _ > + obsolete cur) (format #f > + "(define-obsolete-function-alias ~a ~a ~a)" > + obsolete cur "\"2020-01-10\"")))))))) This has been fixed upstream, so you could also update the package to the latest commit, see how it's done in the emacs-libgit package for instance. > (home-page "https://github.com/chuntaro/emacs-promise") > (synopsis "Promises/A+ for Emacs") > - (description "This is a simple implementation of Promises/A+. > + (description > + "This is a simple implementation of Promises/A+. > > This implementation ports the following Promises/A+ features > faithfully. See @url{https://github.com/then/promise}. > @@ -30371,7 +30381,8 @@ (define-public emacs-promise > @item It supports \"thenable\". > @item It supports \"Inheritance of Promise\". > @item It supports \"rejection-tracking\". > -@end itemize\n") > +@end itemize > +") > (license license:gpl3+))) Those changes also shouldn't be part of this patch. Could you please send an update version? Thanks, Mathieu