From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yNh4GB3F8mLcGQAAbAwnHQ (envelope-from ) for ; Tue, 09 Aug 2022 22:35:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uKSVFx3F8mKaCAEAG6o9tA (envelope-from ) for ; Tue, 09 Aug 2022 22:35:41 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E3C333CCF2 for ; Tue, 9 Aug 2022 22:35:40 +0200 (CEST) Received: from localhost ([::1]:47952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLVwy-0008IX-4j for larch@yhetil.org; Tue, 09 Aug 2022 16:35:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLVwM-0008IL-Te for guix-patches@gnu.org; Tue, 09 Aug 2022 16:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55452) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLVwM-00018U-HD for guix-patches@gnu.org; Tue, 09 Aug 2022 16:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLVwM-0004Dq-Cu for guix-patches@gnu.org; Tue, 09 Aug 2022 16:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56858] [PATCH] gnu: libcgroup: Update to 2.0.2. Resent-From: muradm Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Aug 2022 20:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56858 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: "\(" , 56858@debbugs.gnu.org Received: via spool by 56858-submit@debbugs.gnu.org id=B56858.166007728316202 (code B ref 56858); Tue, 09 Aug 2022 20:35:02 +0000 Received: (at 56858) by debbugs.gnu.org; 9 Aug 2022 20:34:43 +0000 Received: from localhost ([127.0.0.1]:45201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLVw2-0004DE-NK for submit@debbugs.gnu.org; Tue, 09 Aug 2022 16:34:43 -0400 Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:34288 helo=nomad-cl1.muradm.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLVvx-0004Cz-OO for 56858@debbugs.gnu.org; Tue, 09 Aug 2022 16:34:40 -0400 Received: from localhost ([127.0.0.1]:41150) by nomad-cl1.muradm.net with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1oLVvH-0002Qf-1t; Tue, 09 Aug 2022 20:33:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; s=mail; h=Content-Type:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc:To :From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uocannNtvB5N16c6CRJj1wAoZIlZDKML/ByY61La+rI=; b=ID5LaBZCXv4Z27/k5235C+TOS2 a6JfTQQ3LRHsIFK4ZZaxwalCAt/IoD57YL/pIvkDefwqYMDWsrana0Ikl1vff/JjIgHYuiYoZD0x1 /HAWdjCDzQgJyU7C398YW69ELuS1qOCEH3LVd/UuxhKT793P/QAE0Ka5PO217D89n7/aeA4BNUga0 Nu+OpQrXx73WFSjWbOyYKmu7Bw/gZ+Gtd4P5IbuCgnRtOYvum5bksrM9wchf8YtOg4w0LhHbF49Gw Hh1A4SucYTEpNMmcHXgavzLPrlKR8FFSo0p17mE6UQz+jATx3EI1ZyvSJ34lNZTwEzXuBZnEv1CRT GrWcUVbLf9T8IGz5kQX+y7JxuRWAsaMrASvkRYZ5xFwgmc96JtApbonRdWhFVURIqxEhLG/goJUnr pQp9CrUILhqw2i76BgCkBY+4VY95MAQiBulHolCeZpXjqWFZZjzoItdEyNpC2zz1+uM5ewwkYVe8W cEm6r67na5tHjGXbMZLBpi/p; Received: from muradm by localhost with local (Exim 4.96) (envelope-from ) id 1oLVvk-0007uk-2P; Tue, 09 Aug 2022 23:34:24 +0300 References: <20220731152938.28770-1-mail@muradm.net> <87sfmgplez.fsf@muradm.net> <87bkst5syp.fsf_-_@gnu.org> User-agent: mu4e 1.8.7; emacs 29.0.50 From: muradm Date: Tue, 09 Aug 2022 23:29:09 +0300 In-reply-to: <87bkst5syp.fsf_-_@gnu.org> Message-ID: <87tu6lxijz.fsf@muradm.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660077341; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=uocannNtvB5N16c6CRJj1wAoZIlZDKML/ByY61La+rI=; b=hal9MZ8+pv5jLVZnnVK0HfEf8QKDesaFt5tFfL+SJgjAa1KDozx7iiEyoG/fvkGTYDc7GD Y8P37tYxp7fUB+l2loT/+nRf2Ty3KZmUIE7fkvDPOqG6wNhXC2899Xl/pmqLSyCUXvquLC iAb77CREHCtfqT/hbH2wKC9xs7lAQs1XnPdm+tHzunQpzceeQHIo90EjlVy5CBBU7Z4h2g 3fP++Z2Q/9acW6LxvHJJD0PJizJbRTXWeoxF02d+75fLkJ8F6bepoB1kLTySvhbjCQCpqj R19gREJUFcQi0Pl8+ih6RAryOhLAL+MsgtpOspANh5ZelMXy4iq2nIwSr4TcnQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660077341; a=rsa-sha256; cv=none; b=HChNq7Kvo6wCiSTkXoUziaxSgOPI1yjzr5LD/RznDLgawRDSW3s8PW3peFm7myr3I4UOzN C/VGdCkOnwLaJPIlohA09qEZptgphH0OnccZ2SzFviYb5IreXduK2d7BtmsR0+SU95RJEE 77E9uudnRxApR+lYTujDEFbkXlvIvGZZNs68h1VSnHnKII0gJfzgQUCT8HoObW/ynO5Nb2 ONMWJjPuRGINjeyBBGbsZT9v9XA5Wyf8ySVazRwxyEbfoZLytIhnK1MXQowx41NlsamjxP Cc5wDnEdAq7jwZ4ikDeXAJyaicoLTDBVcSckTnfUeHiHbTuBCztS3z8xHmt7hg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=muradm.net header.s=mail header.b=ID5LaBZC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.59 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=muradm.net header.s=mail header.b=ID5LaBZC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E3C333CCF2 X-Spam-Score: -1.59 X-Migadu-Scanner: scn0.migadu.com X-TUID: LkWNETE+++XG --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi, > > "(" skribis: > >> On Mon Aug 1, 2022 at 6:42 AM BST, muradm wrote: >>> Is there a guideline where home-page should be? I find it more >>> DRY when reusing. >> Almost every package in Guix puts it directly above synopsis,=20 >> though >> you do have a point about DRY. > > Yeah IMO it=E2=80=99s a good idea to reuse =E2=80=98home-page=E2=80=99 li= ke this patch=20 > does. > >>> Their repo is not suitable for building from, instead >>> they release sources manually. >> Looks okay to me:=20 >> >> But there is a problem with vendoring googletest, it seems.=20 >> You'll want >> to use the system's googletest, and (recursive? #t) in the=20 >> git-reference >> to clone the tests repo. Also, the tarball seems to contain=20 >> pregenerated >> autotools files, which are discouraged by Guix. > > So, first things first. The priority should be to run tests and=20 > remove > the bundled googletest, which I tried with the patch below. > > Now, tests won=E2=80=99t run because apparently they try to use =E2=80=98= sudo=E2=80=99=20 > (!): > > Traceback (most recent call last): > File=20 > "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/./f= tests.py",=20 > line 353, in > sys.exit(main(config)) > File=20 > "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/./f= tests.py",=20 > line 337, in main > setup(config, record_time=3DTrue) > File=20 > "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/./f= tests.py",=20 > line 170, in setup > Run.run(['sudo', 'lxd', 'init', '--auto']) > File=20 > "/tmp/guix-build-libcgroup-2.0.2.drv-0/libcgroup-2.0.2/tests/ftests/run= .py",=20 > line 38, in run > subproc =3D subprocess.Popen(command, shell=3Dshell_bool, > File=20 > "/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9= /subprocess.py",=20 > line 951, in __init__ > self._execute_child(args, executable, preexec_fn, close_fds, > File=20 > "/gnu/store/65i3nhcwmz0p8rqbg48gaavyky4g4hwk-python-3.9.9/lib/python3.9= /subprocess.py",=20 > line 1821, in _execute_child > raise child_exception_type(errno_num, err_msg, err_filename) > FileNotFoundError: [Errno 2] No such file or directory: 'sudo' > FAIL ftests.sh (exit status: 1) > > Could you check whether they can run at all without root=20 > privileges, and > if not, document it in a comment above #:tests? #f? unfortunately, tests are executed virtualized with lxc/lxd, while technically it seems to be possible to execute them, but it will=20 require fixing (but probably rewriting) python test runner code. Possible=20 but not feasible i think. On the other hand, as far as it is mentioned in their release=20 process, sources release tarball is releaced after tests passing. ;; tests are virtualized with lxc/lxd, it is not very feasible ;; to make them executable under guix build Will this commend do the work? > Thanks, > Ludo=E2=80=99. > > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm > index e70d8d1a90..7eb309dfa5 100644 > --- a/gnu/packages/linux.scm > +++ b/gnu/packages/linux.scm > @@ -8177,14 +8177,18 @@ (define-public libcgroup > (uri (string-append home-page "/releases/download/v" > version "/" name "-" version=20 > ".tar.gz")) > (sha256 > - (base32=20 > "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")))) > + (base32=20 > "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf")) > + (modules '((guix build utils))) > + (snippet > + ;; Delete the bundled copy of googletest, that even=20 > includes a .so. > + '(delete-file-recursively "googletest")))) > (build-system gnu-build-system) > - (arguments > - `(#:tests? #f)) > + ;; (arguments > + ;; `(#:tests? #f)) > (native-inputs > - (list bison flex)) > + (list bison flex python-wrapper)) > (inputs > - (list linux-pam)) > + (list linux-pam googletest)) > (synopsis "Control groups management tools") > (description "Control groups is Linux kernel method for=20 > process resource > restriction, permission handling and more. This package=20 > provides userspace --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAmLyxNAACgkQ6M7O0mLO BeK3fw//XYfbkJlA9cP8IF8G/v4F9ev+26AwIG7YHjM45qMK7Pa3CeK3a2MNI5O9 v2PzHaPmsyaz7Sb1H9rz+RqWkuGalsbakxsTfDLFu3a6i4fuK4zElktzyTdpyRCc jo5u4GofX0Dkb5OuRs65frDdaAdtxaL6deQdfpbZEjDY+a3q8Mt/huMnKHUV7GHQ rpd0q9hSMVpUiYIaMYG7Ojp8CO7q3rm8r+IAMsiIBu08PjnSYgu6BunKl8TTj3lI GU3mRCdkPxModztTULf41g5jL1vH6AtXlv5a27bocwTzXTAlX7dP3dnUIEBsKG3s UP5cpZej8sHRJvbiYoMTnKeP5G3H8aBVKWXJQ/rpKSVI58Tm7uySySpSaFKAZeeB 1xwja9Pq55/tlxkE2iqPT6NQldIem1NRAsXdolcXtqvzlU7Tn6fyB984QbpHY3W3 XMXrkui5AW40ehLv9F5rZvLkuTXKfJBuJyO6etZ18QwQuEJG0OYFBglmA7XyNrBa 64M/3kK8DHieOImVjDVHBUffHrw/U/kdAE5kEAznFFrDZwlmFX2U2JdUkhojiy3D i352GL6NdLAeueWcH8w9XBklE5ETaXQigAnVs55x2z8a2S/yJ42BcPrFBMEcV9s1 +i/VH+ujGxH7F8rPPReoORzaWy8zqCXoIBi+UzDPrpjlDiMdl8o= =bggf -----END PGP SIGNATURE----- --=-=-=--