From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GKRlKeWBEGNqqwAAbAwnHQ (envelope-from ) for ; Thu, 01 Sep 2022 11:56:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CEQwKeWBEGMHGAAAauVa8A (envelope-from ) for ; Thu, 01 Sep 2022 11:56:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4EF3C3DEA7 for ; Thu, 1 Sep 2022 11:56:53 +0200 (CEST) Received: from localhost ([::1]:33182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTgwO-0003I3-Al for larch@yhetil.org; Thu, 01 Sep 2022 05:56:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTgD5-0000S3-8Y for guix-patches@gnu.org; Thu, 01 Sep 2022 05:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51472) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTgD4-0006fK-UR for guix-patches@gnu.org; Thu, 01 Sep 2022 05:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oTgD3-00009n-NE for guix-patches@gnu.org; Thu, 01 Sep 2022 05:10:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56604] [PATCH 0/8] Update Clojure to 1.11.1. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Sep 2022 09:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56604 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Roman Scherer Cc: 56604-done@debbugs.gnu.org Received: via spool by 56604-done@debbugs.gnu.org id=D56604.1662023362546 (code D ref 56604); Thu, 01 Sep 2022 09:10:01 +0000 Received: (at 56604-done) by debbugs.gnu.org; 1 Sep 2022 09:09:22 +0000 Received: from localhost ([127.0.0.1]:41221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTgCQ-00008k-0i for submit@debbugs.gnu.org; Thu, 01 Sep 2022 05:09:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oTgCN-00008T-Cg for 56604-done@debbugs.gnu.org; Thu, 01 Sep 2022 05:09:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34760) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTgCH-0006bX-VS; Thu, 01 Sep 2022 05:09:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=UWdnYB2xMNg2fjJ78e2+8Uv6M53jshOv5i/9en0koMA=; b=DnHvVwMjo7zqVBUkUPsb m8QYlPmVP9r5nSJ3/xhGr9NyuBsqK45eNU63TMz7i7p5k6tySc2r0CB8g/KJuqWZWLs+3f0TC0Yni UeQhDpkNSNkwsB1g/bHhFlBoNW3BSuERTCEEunAoNBfKC/HYuFJJIKwffFMzyfdELyfFIxjDCDo2n 0IAqbyC8ApHssg9p2CpORIhR4240pBzRP9r4hSJx6lnIF3TWor73CCOm6xQfvKqDc9YPYBZrBQkdm KaiPpJe9e87Nfi1NgkyowVp268EClYz7PZ8HjkW3WEtYNS6DWq+OCtFvk7xGmwx2ebrA9TYHzxTZ6 dpX/VY+BsQPGlw==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40696 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTgCH-0002Dr-Hy; Thu, 01 Sep 2022 05:09:13 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87fsisg5mu.fsf@gnu.org> <87zgg55wyq.fsf@burningswell.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 15 Fructidor an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de la Truite X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 01 Sep 2022 11:09:11 +0200 In-Reply-To: <87zgg55wyq.fsf@burningswell.com> (Roman Scherer's message of "Mon, 15 Aug 2022 15:36:32 +0000") Message-ID: <87tu5r4g20.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662026213; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UWdnYB2xMNg2fjJ78e2+8Uv6M53jshOv5i/9en0koMA=; b=dggDLN7N50NjL3ErGqodmdmj1IaCHNbBc6s964rIS9ZJPmrY62CovCVAsRLdG/EIAUp8Cu LMMX8aS1QSBwTandpH3AqqSmnQITgV5t+wE9Ofae8vTgugZC2IDmtz98BOUwsrznpOXCK7 1kC6I27nWUX90ZmYW+6DxjmygOCtz9hgpx/eD/hN2zfj29spFEXOMrKx0PIxpcgODvOWe2 teovPwv1I6K+YrbXi3yHPkGEjpgeEn/RBauS1ds6nfhhOGaYwzWIp4QQb//NbKdR+DjzNN Ig92F7DpWYRgK8z/f5dkWTF4D8wNUeRLiisWO11sbgtJY838/lsqV1a8+ijQCQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662026213; a=rsa-sha256; cv=none; b=aVXGGzAEhU6luvd7FK28FwJ+P2fcI5fASBov+9qyB2d/+uokRTH1AGp17U7Wmk6ORRtOiO 0fSUpjJJyNdVXSUsLivI6eGPQhzuocv2rib/ELtdoNKcXkLlQm9MhZMXSflsmQ8sw/RTB/ g2EJLBtXraVh3ehtPCobYbS7nqRqaPZloi0OkSvbwFpcWPMjLfks5Xh/2z4KunUN+lglfZ tu3xCUObld8DJUMWDu6eRMpYl5NEByn5Q1393hkWVev4Nw9vnKxExLq0rVA+nXC087cXfg deZyooeqx+ReisiYI1DlbPWMz8L7C2hHQR+StruHls+fv6xJ17OgoPIjFuMUsg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=DnHvVwMj; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.48 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=DnHvVwMj; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4EF3C3DEA7 X-Spam-Score: -4.48 X-Migadu-Scanner: scn0.migadu.com X-TUID: CGdPA2l2a/1h Hi Roman, (Catching up after vacation=E2=80=A6) Roman Scherer skribis: > here's the promised patch to follow up with the code duplication I > introduced in my previous patch. Awesome. > When I run the following commands after modifying the build systems they > run for quite some time, because they were compiling a ton (the jdk, > jetty) of things. > > ./pre-inst-env guix build clojure > ./pre-inst-env guix build clojure-tools > > I guess this is expected, since a change in a build system might affect > all packages being built with it. But I was wondering if there is a way > to force only building the packages specified on the command line. Does > such a thing exists? No, it doesn=E2=80=99t exist, because that would be building something different. In this case, building everything that depends on =E2=80=98ant-build-system.scm=E2=80=99 is unavoidable. > I was wondering what is the most efficient way to quickly iterate on > changes to a build system, without recompiling the whole world for that > build system. How would you do that? There=E2=80=99s no ideal solution as you=E2=80=99ll have to recompile the w= orld anyway. When changing build systems, I=E2=80=99d usually stare at my changes for qu= ite some time first, to make sure I don=E2=80=99t have to rebuild the world on = the next day because of a typo. :-) Then, for small local changes, I=E2=80=99d build just the bottom of the dependency graph to check for breakage (in this case, making sure the =E2=80=98strip-jar-timestamps=E2=80=99 phase still works as intended). The= n we can let ci.guix build the whole thing afterwards, and make sure nothing goes wrong. > From 756bfd3458ded38e1041ebb255c6b6ffe737732d Mon Sep 17 00:00:00 2001 > From: Roman Scherer > Date: Mon, 15 Aug 2022 15:29:25 +0000 > Subject: [PATCH] build-system: Add repack-jar and use it in Ant & Clojure > build systems > > * guix/build/ant-build-system.scm: Add repack-jar and use it in strip-jar= -timestamps > * guix/build/clojure-build-system.scm: Use repack-jar in reset-class-time= stamps Please use the ChangeLog format, specifying procedure/variable names and their actual changes. [...] > +(define-public (repack-jar outputs repack-fn) > + "Unpack all jar archives, invoke repack-fn for each JAR with the direc= tory > +it has been unpacked to, and pack them again." Instead of =E2=80=98define-public=E2=80=99, I=E2=80=99d move =E2=80=98repac= k-jar=E2=80=99 to #:export at the top, like the other procedures. But=E2=80=A6 > @@ -206,13 +205,7 @@ (define (repack-archive jar) > (with-directory-excursion dir > (invoke "jar" "xf" jar)) > (delete-file jar) > - ;; XXX: copied from (gnu build install) > - (for-each (lambda (file) > - (let ((s (lstat file))) > - (unless (eq? (stat:type s) 'symlink) > - (utime file 0 0 0 0)))) > - (find-files dir #:directories? #t)) > - > + (repack-fn dir) Looking at the code, the only difference between the two repack functions is the timestamp, right? In that case, I=E2=80=99d lean towards adding a #:jar-timestamp parameter to =E2=80=98strip-jar-timestamps=E2=80= =99 (rather than this =E2=80=98repack-fn=E2=80=99 argument) that=E2=80=99d be passed to =E2= =80=98utime=E2=80=99. The default for #:jar-timestamp would be '(0 0 0 0); for Clojure we=E2=80=99d set the defau= lt #:jar-timestamp in (guix build-system clojure) to: #:jar-timestamp (list early-1980 early-1980) WDYT? Thanks, Ludo=E2=80=99.