From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 57513-done@debbugs.gnu.org
Subject: [bug#57513] [PATCH] installer: Fix segfault on double logical partition removal.
Date: Thu, 01 Sep 2022 21:16:02 +0200 [thread overview]
Message-ID: <87tu5qzz0t.fsf@jpoiret.xyz> (raw)
In-Reply-To: <87y1v32g7g.fsf@gnu.org>
Hey Mathieu,
Mathieu Othacehe <othacehe@gnu.org> writes:
> I was able to reproduce the issue by creating an extended partition
> containing a single logical partition using the manual partitioning tool
> then, the automatic one right after.
>
> It resulted in a segfault, which is fixed by your patch, that's a very
> nice catch!
I have to thank KE0VVT on IRC, who provided a core dump file! This was
surprisingly easier to debug than I thought, for those interested, I
built the installer using the same Guix commit, and loaded the guile
core dump file in gdb. I then used `guix build parted
--with-debug-info=parted` and loaded the resulting libparted.so library
using `info sections` to find out where the .text of libparted.so was
loaded in the core file, and `add-symbol-file
/gnu/store/path/to/libparted.so 0xaddress` to load the symbols. That
way, I could see that ped_disk_remove_partition was invoked for a disk
that had an empty partition list, hence leading me to this double remove
problem!
> Pushed as 4989f6acff3b3fcfbd9dde3e3c2767bd2cd6d49e.
>
> Thanks,
>
> Mathieu
Thank you for reviewing this so fast!
Best,
--
Josselin Poiret
next prev parent reply other threads:[~2022-09-01 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 21:22 [bug#57513] [PATCH] installer: Fix segfault on double logical partition removal Josselin Poiret via Guix-patches via
2022-09-01 16:48 ` bug#57513: " Mathieu Othacehe
2022-09-01 19:16 ` Josselin Poiret via Guix-patches via [this message]
2022-09-02 7:50 ` [bug#57513] " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu5qzz0t.fsf@jpoiret.xyz \
--to=guix-patches@gnu.org \
--cc=57513-done@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.