bug#57543: emacs-telega is broken

bug#57543: emacs-telega is broken

[André A. Gomes]

Hi Guix,

The latest emacs-telega raises the following warning:

--8<---------------cut here---------------start------------->8---
Warning (emacs): TDLib version=1.8.4 > 1.8.0 (max required), please downgrade TDLib and recompile ‘telega-server’ Disable showing Disable logging
--8<---------------cut here---------------end--------------->8---

Please revert the following commit:

--8<---------------cut here---------------start------------->8---
80df3ffb4fba19c9711ca912503df01cd2c9dc96
Author:     Zhu Zihao <all_but_last@163.com>
AuthorDate: Sat Aug 6 23:12:17 2022 +0800
Commit:     Ludovic Courtès <ludo@gnu.org>
CommitDate: Thu Sep 1 00:57:10 2022 +0200
--8<---------------cut here---------------end--------------->8---

Thanks.


-- 
André A. Gomes
"You cannot even find the ruins..."

bug#57543: emacs-telega is broken

[Giovanni Biscuolo]

[-- Attachment #1: Type: text/plain, Size: 1662 bytes --]

Hello André and Ludo`

André A. Gomes <andremegafone@gmail.com> writes:

> The latest emacs-telega raises the following warning:
>
> --8<---------------cut here---------------start------------->8---
> Warning (emacs): TDLib version=1.8.4 > 1.8.0 (max required), please downgrade TDLib and recompile ‘telega-server’ Disable showing Disable logging
> --8<---------------cut here---------------end--------------->8---

I can confirm this bug

> Please revert the following commit:
>
> --8<---------------cut here---------------start------------->8---
> 80df3ffb4fba19c9711ca912503df01cd2c9dc96
> Author:     Zhu Zihao <all_but_last@163.com>
> AuthorDate: Sat Aug 6 23:12:17 2022 +0800
> Commit:     Ludovic Courtès <ludo@gnu.org>
> CommitDate: Thu Sep 1 00:57:10 2022 +0200
> --8<---------------cut here---------------end--------------->8---

Currently packaged emacs-telega is v.0.8.03, the
telega-tdlib-max-version defined for that version is "1.8.0" [1]

The latest version of telega.el in master (defined as Version 0.8.44 in
metadata) [2]: it does support tdlib 1.8.4, but unfortunately uspream is
not releasing (via git tag) since v.0.8.03: should we use the commit
hash c547477be39298eabf8e67f0116a115771f2ee0b to upgrade emacs-telega to
the last upstream version?

Meanwhile, since tdlib now is only used by emacs-telega[-server] we
should temporary revert this commit, unless there are security concerns.

WDYT?

Thanks! Gio'


[1] https://github.com/zevlg/telega.el/blob/v0.8.03/telega.el

[2] https://github.com/zevlg/telega.el/blob/master/telega.el

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

bug#57543: emacs-telega is broken

[André A. Gomes]

Giovanni Biscuolo <g@xelera.eu> writes:

> Currently packaged emacs-telega is v.0.8.03, the
> telega-tdlib-max-version defined for that version is "1.8.0" [1]
>
> The latest version of telega.el in master (defined as Version 0.8.44 in
> metadata) [2]: it does support tdlib 1.8.4, but unfortunately uspream is
> not releasing (via git tag) since v.0.8.03: should we use the commit
> hash c547477be39298eabf8e67f0116a115771f2ee0b to upgrade emacs-telega to
> the last upstream version?
>
> Meanwhile, since tdlib now is only used by emacs-telega[-server] we
> should temporary revert this commit, unless there are security concerns.
>
> WDYT?

Hi Giovanni,

Thanks for investigating.  I think you're right.  Either reverting or
updating the emacs-telega package definition (needs to be tested still).

I'd revert it right away, since it's broken as of now.  I don't have
commit access.  Ludovic, could you please do it?

Thanks.


-- 
André A. Gomes
"You cannot even find the ruins..."

bug#57543: emacs-telega is broken

[Giovanni Biscuolo]

[-- Attachment #1: Type: text/plain, Size: 2318 bytes --]

Hi Andrè

André A. Gomes <andremegafone@gmail.com> writes:

[...]

> Hi Giovanni,
>
> Thanks for investigating.  I think you're right.  Either reverting or
> updating the emacs-telega package definition (needs to be tested
> still).

I also updated the related bug#57017: tdlib v.1.8.4 has not been
released yet (see bug#57017 for details), the last stable release of
tdlib is still 1.8.0, and consequently the last stable release of
emacs-telega is still 0.8.03 [1] that is compatible with thed tdlib
version

> I'd revert it right away, since it's broken as of now.  I don't have
> commit access.  Ludovic, could you please do it?

unfortunately the bug is worst than I imagined: I was (easily) able to
switch my dedicated emacs profile to a previously running version (via
--switch-generation=) and started a new emacs named server

running "M-x telega" I get this in the **Messages** buffer:

--8<---------------cut here---------------start------------->8---

[6]telega-server: annullato
Error running timer ‘telega-server--idle-timer-function’: (error "telega-server is not running")

--8<---------------cut here---------------end--------------->8---

("annullato" means aborted)

this is the error I get in ~/.telega/telega-server.log:

--8<---------------cut here---------------start------------->8---

[ 0][t 4][1662729492.673026323][LogEvent.h:135][#1][!Td][&version() < static_cast<int32>(Version::Next)]	Wrong version 41

--8<---------------cut here---------------end--------------->8---

AFAIU when I ran telega with the new tdlib verson, the database got
upgraded and the new database version is not compatible with the old
tdlib library; there is an old (Mar 2021) telega.el issue that helped me
understand this one: https://github.com/zevlg/telega.el/issues/276

If I'm not getting it wrong, reverting the "offending" patch and
restoring tdlib to 1.8.0 is not enough for people like us who already
upgraded tdlib (and started telega), we need to restore from backups.

WDYT?

Happy hacking! Gio'


[1] I had a quich chat with Zajcev Evgeny on the telaga Telegram channel
and he confirmed that he is still not releasing a new version since he
is wating a new official tdlib release

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

bug#57543: emacs-telega is broken.

[Zhu Zihao]

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

What about update emacs-telega to
0.8.44(https://github.com/zevlg/telega.el/commit/2d77c131856c9387a28dd6e4a15cef87029c3055)
?

I know the guidelines of Guix is package the stable release of software.
But I found that the telega in current Guix is partially broken(e.g.
messages with reactions is displayed as "TODO: messageUnsupported")

But the author of telega doesn't tag a release frequently. If we only
use the official release, it will be outdated.
-- 
Retrieve my PGP public key:

  gpg --recv-keys B3EBC086AB0EBC0F45E0B4D433DB374BCEE4D9DC

Zihao

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 255 bytes --]

bug#57543: emacs-telega is broken

[André A. Gomes]

Giovanni Biscuolo <g@xelera.eu> writes:

> AFAIU when I ran telega with the new tdlib verson, the database got
> upgraded and the new database version is not compatible with the old
> tdlib library; there is an old (Mar 2021) telega.el issue that helped me
> understand this one: https://github.com/zevlg/telega.el/issues/276
>
> If I'm not getting it wrong, reverting the "offending" patch and
> restoring tdlib to 1.8.0 is not enough for people like us who already
> upgraded tdlib (and started telega), we need to restore from backups.

Hi Giovanni,

Great investigation, thanks.

I'm a bit confused when you say "restore from backups".  Are you saying
that, for those who have already upgraded tdlib, it's not sufficient to
simply switching to an older generation?


-- 
André A. Gomes
"You cannot even find the ruins..."

bug#57543: emacs-telega is broken

[Giovanni Biscuolo]

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

Hi André

André A. Gomes <andremegafone@gmail.com> writes:

> Giovanni Biscuolo <g@xelera.eu> writes:

[...]

>> If I'm not getting it wrong, reverting the "offending" patch and
>> restoring tdlib to 1.8.0 is not enough for people like us who already
>> upgraded tdlib (and started telega), we need to restore from backups.
>
> Hi Giovanni,
>
> Great investigation, thanks.
>
> I'm a bit confused when you say "restore from backups".  Are you saying
> that, for those who have already upgraded tdlib, it's not sufficient to
> simply switching to an older generation?

I did it: i switched (--switch-generation=) my profile to a previous
generation (when emacs-telega was running) and telega-server
(automatically started by telega) is not starting anymore, with the
error I reported in my previous message

André please could you try to switch back to a previous profile
generation and test it, reporting the errors you get in Emacs *Messages*
buffer in ~/.telega/telega-server.log (unless you configured another
telega directory)?

Thanks, Gio'

[...]

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

bug#57543: emacs-telega is broken.

[Giovanni Biscuolo]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

Hi Zhu,

Zhu Zihao <all_but_last@163.com> writes:

> What about update emacs-telega to
> 0.8.44(https://github.com/zevlg/telega.el/commit/2d77c131856c9387a28dd6e4a15cef87029c3055)
> ?
>
> I know the guidelines of Guix is package the stable release of software.
> But I found that the telega in current Guix is partially broken(e.g.
> messages with reactions is displayed as "TODO: messageUnsupported")

I understand your needs but, as I already mentioned in a previous
message:

>> [1] I had a quich chat with Zajcev Evgeny on the telaga Telegram
>> channel and he confirmed that he is still not releasing a new version
>> since he is wating a new official tdlib release

so 0.8.44 is "unstable", as is "unstable" tdlib 1.8.4 as also reported
in bug#57017

> But the author of telega doesn't tag a release frequently. If we only
> use the official release, it will be outdated.

what about to have emacs-telega /and/ tdlib packages using a stable
relase and adding emacs-telega-unstable and tdlib-unstable packages
using newer commits?

WDYT?

Happy hacking! Gio'

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

bug#57543: emacs-telega is broken.

[Giovanni Biscuolo]

[-- Attachment #1: Type: text/plain, Size: 2051 bytes --]

Hello,

Giovanni Biscuolo <g@xelera.eu> writes:

[...]

> [1] I had a quich chat with Zajcev Evgeny on the telaga Telegram
> channel and he confirmed that he is still not releasing a new version
> since he is wating a new official tdlib release

for archival purposes, this is a transcript (via telega running on
another machine of mine) of the chat I had with Evgeny:

--8<---------------cut here---------------start------------->8---

(G) Giovanni Biscuolo @gbiscuolo edited at Fri ⮪4                                   
    Please do you plan to make an officiale release (git tag) soon?
    Last git tag is for 0.8.03.                                              Fri✔
⸨E⸩ Evgeny Zajcev @zevlg                                                             
    | Reply: @gbiscuolo> Please do you plan to make an officiale re...
    Release will be made only after TDLib release and all essential
    features of newly released TDLib being implemented                       Fri
(G) Giovanni Biscuolo @gbiscuolo                                                     
    | Reply: @zevlg> Release will be made only after TDLib release ...
    OK, so the last stable release is still 0.8.03 using Tdlib 1.8.0,
    correct?                                                                 Fri✔
⸨E⸩ Evgeny Zajcev @zevlg                                                             
    | Reply: @gbiscuolo> OK, so the last stable release is still 0....
    right, that is how we get it stable                                      Fri
(G) Giovanni Biscuolo @gbiscuolo                                                     
    | Reply: @zevlg> right, that is how we get it stable
    Thanks!                                                                  Fri✔

--8<---------------cut here---------------end--------------->8---

This means that telega.el releases are done after (in sync?) tdlib
releases.

Happy hacking! Gio'

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

bug#57543: emacs-telega is broken

[André A. Gomes]

Giovanni Biscuolo <g@xelera.eu> writes:

> I did it: i switched (--switch-generation=) my profile to a previous
> generation (when emacs-telega was running) and telega-server
> (automatically started by telega) is not starting anymore, with the
> error I reported in my previous message
>
> André please could you try to switch back to a previous profile
> generation and test it, reporting the errors you get in Emacs *Messages*
> buffer in ~/.telega/telega-server.log (unless you configured another
> telega directory)?

Hi Giovanni,

I switched back to a previous profile generation and I was able to start
the telega server only after deleting all database files located at
~/.telega/.  Before doing that I was also getting errors.

Some things look off in in *Telega Root* buffer tough, and I can't use
emacs-telega as before.  I can't say it's working properly.

Does this make sense?  Can you reproduce what I've detailed?

Thanks.

-- 
André A. Gomes
"You cannot even find the ruins..."

bug#57543: emacs-telega is broken

[Giovanni Biscuolo]

[-- Attachment #1: Type: text/plain, Size: 1569 bytes --]

Hi André

I was able to swith back to a previous profile generation and use
emacs-telega again, see below

current emacs-telega is still broken, AFAIK

André A. Gomes <andremegafone@gmail.com> writes:

> Giovanni Biscuolo <g@xelera.eu> writes:

[...]

>> André please could you try to switch back to a previous profile
>> generation and test it, reporting the errors you get in Emacs *Messages*
>> buffer in ~/.telega/telega-server.log (unless you configured another
>> telega directory)?
>
> Hi Giovanni,
>
> I switched back to a previous profile generation and I was able to start
> the telega server only after deleting all database files located at
> ~/.telega/.  Before doing that I was also getting errors.

the last few lines of ~/.telega/telega-server.log could have been
useful so we could compare them with mine, but nevermind

AFAIU just deleting the database files could not be enough since there
could be some "status" (other files in ~/.telega) giving problems

> Some things look off in in *Telega Root* buffer tough, and I can't use
> emacs-telega as before.  I can't say it's working properly.

have you tryed renaming the whole ~/.telega folder to ~/.telega.BACKUP?

> Does this make sense?

Yes it makes sense

> Can you reproduce what I've detailed?

Yes, I renamed the telega folder as suggested above and started
emacs-telega;  I had to authenticate my desktop client again and now
AFAIU all is working as before

[...]

Happy hacking! Gio'

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

bug#57543: emacs-telega is broken

[André A. Gomes]

Giovanni Biscuolo <g@xelera.eu> writes:

> Hi André
>
> I was able to swith back to a previous profile generation and use
> emacs-telega again, see below

Hi Giovanni!

It's working for me too, following your steps!

So, I believe we're agreeing that the commit we referred to should be
reverted.  Correct?

Thanks.


-- 
André A. Gomes
"You cannot even find the ruins..."

bug#57543: emacs-telega is broken

[Giovanni Biscuolo]

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

Hi André and Ludovic,

André A. Gomes <andremegafone@gmail.com> writes:

[...]

> It's working for me too, following your steps!

Fine, so we have an easy procedure to "roll back" the telega-server
status folder; this means a new desktop application authentication that
will appear as a new "device" (probably followed by old "device"
deletion, for security) in Telegram, but AFAIU this is not a problem for
most of the users

> So, I believe we're agreeing that the commit we referred to should be
> reverted.  Correct?

IMHO yes, we should revert the tdlib upgrade /or/ keep a packaged
tdlib@1.8.0 used by emacs-telega v. 0.8.3

AFAIU soon (TM) a new release of emacs-telega should be published
(tagged) so eventually the next step could be to upgrade emacs-telega
(as soon as it is released)

Anyway, IMHO both tdlib and emacs-telega should be built from official
releases and not from specific commits, for users who wish to run
emacs-telega/tdlib from specific commits more recent than current
"stable", I propose to create tdlib-next and emacs-telega-next

[...]

If I don't get it wrong, I still have commit access to the guis repo so
I could revert the commit on tdlib, but I'd like to have an OK.

Ludo' WDYT please?

Thanks, Gio'

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

bug#57543: emacs-telega is broken

[Ludovic Courtès]

Hello,

Giovanni Biscuolo <g@xelera.eu> skribis:

> IMHO yes, we should revert the tdlib upgrade /or/ keep a packaged
> tdlib@1.8.0 used by emacs-telega v. 0.8.3

[...]

> If I don't get it wrong, I still have commit access to the guis repo so
> I could revert the commit on tdlib, but I'd like to have an OK.
>
> Ludo' WDYT please?

I think we can reintroduce tdlib 1.8.0 (in addition to the latest
version currently available) for use by emacs-telega; we’ll remove it
eventually when it becomes unnecessary.

Could you send a patch?

Note that I don’t use tdlib and emacs-telega, so I’ll apply whatever
seems appropriate to you.  :-)

Thanks,
Ludo’.

bug#57543: emacs-telega is broken

[Giovanni Biscuolo]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

Hello,

Ludovic Courtès <ludo@gnu.org> writes:

[...]

> I think we can reintroduce tdlib 1.8.0 (in addition to the latest
> version currently available) for use by emacs-telega; we’ll remove it
> eventually when it becomes unnecessary.

OK

> Could you send a patch?

I just sent a patch: bug#58003

unfortunately I'm not able to compile emacs-telega, see the patch cover
letter for details

[...]

Thanks, Gio'

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

bug#57543: Update

[André A. Gomes]

Fixed in the mean time.

-- 
André A. Gomes
"You cannot even find the ruins..."