From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6LyoDIXAJGN1KAEAbAwnHQ (envelope-from ) for ; Fri, 16 Sep 2022 20:29:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eDqrC4XAJGOpuAAAG6o9tA (envelope-from ) for ; Fri, 16 Sep 2022 20:29:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A98001E36C for ; Fri, 16 Sep 2022 20:29:24 +0200 (CEST) Received: from localhost ([::1]:60682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZG5b-0004Nd-7j for larch@yhetil.org; Fri, 16 Sep 2022 14:29:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58878) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZG5G-0004Mv-QY for guix-patches@gnu.org; Fri, 16 Sep 2022 14:29:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45230) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZG5F-0001FA-RX for guix-patches@gnu.org; Fri, 16 Sep 2022 14:29:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZG5F-00075t-Ln for guix-patches@gnu.org; Fri, 16 Sep 2022 14:29:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57774] [PATCH v2] Add qucs-s. Resent-From: Garek Dyszel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Sep 2022 18:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57774 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "(" , 57774@debbugs.gnu.org Received: via spool by 57774-submit@debbugs.gnu.org id=B57774.166335288327195 (code B ref 57774); Fri, 16 Sep 2022 18:29:01 +0000 Received: (at 57774) by debbugs.gnu.org; 16 Sep 2022 18:28:03 +0000 Received: from localhost ([127.0.0.1]:44307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZG4I-00074Z-L6 for submit@debbugs.gnu.org; Fri, 16 Sep 2022 14:28:03 -0400 Received: from knopi.disroot.org ([178.21.23.139]:45272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZG4F-000748-R2 for 57774@debbugs.gnu.org; Fri, 16 Sep 2022 14:28:00 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 5858740107; Fri, 16 Sep 2022 20:27:58 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X_oqlWXEI9PM; Fri, 16 Sep 2022 20:27:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1663352877; bh=ySV/m58UXW06b3hNdzK2oifN9BHCsiLa0lnpS5wFVv8=; h=From:To:Subject:In-Reply-To:References:Date; b=LZkv921AgVs4gmOXV8kMRT1cYWFwCygmuGO3P9FgiYdQlmBcWVtPEKTP181Kk9IZ8 drBFyy3ewsc/MenUt5GU5lXjzJRCFECN2ykmoWd2oGWEbZPFXZ2w2aHv0dQOFPMrVS 3FDoPtbGmU3VGRp3ZGjZdZ1M30TIDefsKETxhWO2RjJ29h53aK3IatFbclHv/Vtbq0 6M9q8km4Kxo5K+hvMUnsM4VGSU471Wm0kxP/RXg+3gxDO4sC74SkmhJr0HP9XZd633 Mu41476+CadwnCuu1xUkSKX6q8nOMwgAUY+TUK/bA088ZxlJUFXLbDULNMbkRAcpce XglOjaPPgt6cw== In-Reply-To: References: <87fsgvm12r.fsf@disroot.org> Date: Fri, 16 Sep 2022 14:27:47 -0400 Message-ID: <87tu57uqcc.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Garek Dyszel X-ACL-Warn: , Garek Dyszel via Guix-patches From: Garek Dyszel via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663352965; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=JvFukSNcBu+VJ7sj+7vLeXe0ZqiUKAhCQVdp+9T5GU8=; b=BZIzfaP/+pN803gnu/AZFfSFxjicuesIeg6/hT6bitNWsIrvP8x3dqj4dy6Y+/4CivEqWf KVK8JLxpaa9oACi49Hv9wA9sKk1xWEIHmL7UR32S+4tJjbmWac2qSupGhgee7chupe7gPl KKlwUUMRNWEXO42j07lDSMcMZAv1hssXylUQa2LVlmYPYeSh05rbxwH9Ltzm1QPxV/+DM5 sAfvTYnLOzcK3Ph9JznauokuezvgwsGTpUXh/DvWGoTyaF8EwHShYR+ekMokCw6zGZsOmt 9dUv9r5TscBSEU7wQC2XuwSVtLvxmgkV/JRtRkbRGltz5TG47I561+E/T+JgoQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663352965; a=rsa-sha256; cv=none; b=M7Wz+tN+68AEywEyYSlv71aNG38GhWoEntkdQjNsRMtU2mmRHLkFf9qmGIl9I5SjPlkQ8K DhtZd+YJGy141iXOxsGa4b03/TVymVSmX/p9hAQKHxNEKo/cE6ALSilGbnz4fEtp5Hv+JP BDFg6NpasokImZgb6n+7rJHXJUgEGLbqArFsouSu+gErL2Kra8XNNyoh9iYYk90szMrGyx OVX074gLOWEo5OFX+Z4rewcIf83I5YXXwiJvydoaP5Y2nOud2Ub/K3ny2FKN66gPyVskWF ldKfPw3kVaPW7vHlZnI5sI9rM4frPhKuSp649ukFM7IqBYdmIMEqrW+tSu1yJg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=LZkv921A; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=LZkv921A; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A98001E36C X-Spam-Score: -0.33 X-Migadu-Scanner: scn1.migadu.com X-TUID: 3GSmaUqJXRLS Hi (, I applied your fixes, but in the process found that qucs-s had already been successfully added before by looking at the package definition for libngspice. This led to the following bug link: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27344#236. It looks like support was later dropped because qucs-s still depended on Qt4 at the time, mentioned in this thread: https://lists.gnu.org/archive/html/guix-devel/2016-02/msg00596.html. This suggested it would be a good idea to start from the commit where qucs and qucs-s were removed. Now I'm hacking those old package definitions to work with Qt6. qucs-s 0.0.24 still depends on qt5 (which is already out of date), and I don't want to have to update it right away when this Qt security issue comes up again this year. I'll send an updated patch when that's done. Sorry for jumping around among existing package sources; I suppose how it worked out this time. - Garek At 07:26 2022-09-14 UTC+0100, "(" wrote: > Hey, > > On Tue Sep 13, 2022 at 10:11 PM BST, Garek Dyszel wrote: >> + #:phases #~(modify-phases %standard-phases > > To conserve lots of horizontal space, consider moving the ``modify-phases'' > to a new line: > >> + #:phases >> + #~(modify-phases %standard-phases > >> + (search-input-file inputs "/bin/ngspice") >> + [...] >> + (search-input-file inputs "/bin/octave") > > You can just do ``(search-input-file inputs "bin/octave")'', no need for the > leading slash. Also, wouldn't you want to patch in the paths for Xyce, > SpiceOpus, and Qucsator, too? > >> + (synopsis "GUI for different circuit simulation kernels") > > s/different/various/, perhaps? > >> + >> +@itemize >> +@item Ngspice (recommended) >> +@item Xyce >> +@item SpiceOpus >> +@item Qucsator (non-spice) >> +@end itemize") >> + (home-page "https://ra3xdh.github.io/") >> + (license license:gpl2+))) >> + >> (define-public freehdl >> (package >> (name "freehdl") >> -- >> 2.37.2 > > > -- (