From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sEEpJnncY2P9uwAAbAwnHQ (envelope-from ) for ; Thu, 03 Nov 2022 16:21:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 0D0NJnncY2OeHwEAauVa8A (envelope-from ) for ; Thu, 03 Nov 2022 16:21:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 651747A8B for ; Thu, 3 Nov 2022 16:21:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqc1l-0004TQ-49; Thu, 03 Nov 2022 11:21:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqc1S-0004Kt-Pe for guix-devel@gnu.org; Thu, 03 Nov 2022 11:20:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqc1R-0008ML-Lq; Thu, 03 Nov 2022 11:20:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=t/0ddQDJqW0yYP9OeUQLrZVv4NGJ9nMKaVogbjXBskM=; b=V1QNHfjSEaVYPass6W30 gwZdQmUgljFcjPxFAYuFjLgVyZ5wUiPzUFXRcQKXaLqVJl4O9QkpmwZ5Jrof9smZtCTRICk94/6gb I9vUu/dbxcpYwnHElT8Y/+RqJaLn9KJKhzp7EN60MvbNtdMXEdHUKKSnI83c3RDn4H2GO4Bl4oT3U V+cZWgskkB0/K8DdZcjOGbSlOf/RxXUGRCFlk7wiAwLUCUasY5e+8oF4PvJVir7H53y32GaB+rdHV Lvj8ks9+ARnW1UOIf4sXa0hi85EM4RZDNaYMR5xm5+b4OqCY9wWtgkzo/PVT/ZeAVk9ecnVwL8zaI iohZw3QC9G/fFg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqc1Q-0006SH-0K; Thu, 03 Nov 2022 11:20:49 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Vagrant Cascadian Cc: guix-devel@gnu.org Subject: Re: guix lint false positives and RFC patch References: <87leosd8bg.fsf@contorta> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 13 Brumaire an 231 de la =?utf-8?Q?R=C3=A9volu?= =?utf-8?Q?tion=2C?= jour du Topinambour X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 03 Nov 2022 16:20:45 +0100 In-Reply-To: <87leosd8bg.fsf@contorta> (Vagrant Cascadian's message of "Wed, 02 Nov 2022 20:29:39 -0700") Message-ID: <87tu3goyia.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-devel" Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667488889; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=t/0ddQDJqW0yYP9OeUQLrZVv4NGJ9nMKaVogbjXBskM=; b=lOhifLEwVS9dHPmTqyYlaYsYmxBbZuM3dP6nrr315KYsqsvgw++e7XgH1gSf5yeyAYtAZg iuzHkU+XzvfNgecw1dpdtRfMfWb9ivsBn+Lo+/krsgemUnAOMQbuD6qrtIfF0JfjPn7Vov +mKV/h3ynXeugmBJdlxIbapnpUpUhwrBjRojfHGd1IMLT3NT3lRrzgK6pBPCi7rXxFAZgO IO68qavE6t7b85syr17I9gPUmz3RhAN7cD8ZoJqgrA14dbZXyWGkxEer3ffzTQReqIc0Ka UikD/C7Qtl39rcaRvRE8nQI6tPHthYDbLr3Ircpp3QmUtYKyYRDJkLNhcS/yJQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667488889; a=rsa-sha256; cv=none; b=fMzaacnCFiumQ5B4ijtQnuAOZ2WQuc+IuA19Wpjc0j0a4EgY8hY+AWDcPmbd4mo1wuRLZW eGjTReJ1W6FiRkXDvVFQhraFVGMrJhCLLX9zY5ZrVgLmsFjdhXedH1pav9APw8qlkFYcJ2 NrV6LzRnonDLyNYYDzPb4zcjSeGMfR4Q3bMgng6h3kBMaaHfgp9HaFwj1vPrCT8wHD1o8k dFjrx8EGKSnTnl/3PYvt8FnDCebm/e/TBkO2pLAOKGN/yTNuimHhb79wOr3Zri9CoGf5Sr 3FAqv4gafONPufyJNOIEG6diVtGiCgD0fgFkuD6U3rj9upz+o2zszp4TlqVKGg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=V1QNHfjS; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.19 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=V1QNHfjS; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 651747A8B X-Spam-Score: -5.19 X-Migadu-Scanner: scn0.migadu.com X-TUID: rVcAtyzDM/dN Vagrant Cascadian skribis: > --- a/guix/lint.scm > +++ b/guix/lint.scm > @@ -313,7 +313,8 @@ (define (tests-explicitly-enabled?) > '())) >=20=20 > (define (properly-starts-sentence? s) > - (string-match "^[(\"'`[:upper:][:digit:]]" s)) > + (string-match "^[(\"'`[:upper:][:digit:]]" > + (string-replace-substring s "@code{" ""))) An identifier in @code or file name in @file may legitimately start with a lower-case letter so I don=E2=80=99t think we should try to prevent that. However, maybe we could change the regexp above to something that accepts @ or some other non-letter character at the start? Ludo=E2=80=99.