From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ILTEG29nmGMkkgAAbAwnHQ (envelope-from ) for ; Tue, 13 Dec 2022 12:52:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ni/QG29nmGO/DAEAauVa8A (envelope-from ) for ; Tue, 13 Dec 2022 12:52:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 02120FD7D for ; Tue, 13 Dec 2022 12:52:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p53pP-00009R-1q; Tue, 13 Dec 2022 06:52:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p53pK-00008c-W2 for guix-patches@gnu.org; Tue, 13 Dec 2022 06:52:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p53pK-0006Fh-Mv for guix-patches@gnu.org; Tue, 13 Dec 2022 06:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p53pK-0003zP-3X for guix-patches@gnu.org; Tue, 13 Dec 2022 06:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60013] [PATCH 1/3] gnu: Add libmodule Resent-From: Florian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Dec 2022 11:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60013 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60013@debbugs.gnu.org Received: via spool by 60013-submit@debbugs.gnu.org id=B60013.167093230415327 (code B ref 60013); Tue, 13 Dec 2022 11:52:02 +0000 Received: (at 60013) by debbugs.gnu.org; 13 Dec 2022 11:51:44 +0000 Received: from localhost ([127.0.0.1]:59849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p53p1-0003z9-Jm for submit@debbugs.gnu.org; Tue, 13 Dec 2022 06:51:44 -0500 Received: from mout02.posteo.de ([185.67.36.66]:34005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p53oy-0003z2-ND for 60013@debbugs.gnu.org; Tue, 13 Dec 2022 06:51:41 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 62236240104 for <60013@debbugs.gnu.org>; Tue, 13 Dec 2022 12:51:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1670932294; bh=zZ2hMB497/YxhEH2RBz0gavjepY8cB+e9z+jX308hX8=; h=From:To:Subject:Date:From; b=pFxgCmXovV5jYvU3YIHJ/wy9wmZAZK/4azYJcX+20JW0qGHPmpHXi11esq/lz0CAA WWC7cipWGjDx7mTeU7sIppJxIpaqoN5ashLGfObPngBSF9gw75wA94DHAuXwFRMG/f G2eeeckfKy5iR/Li3d3qWBUubhZ0Ah4oqZZ5G//VauWoSixBhUu6N0aE5OroeM/suG AyaJoYd/UezrTUGbRmAkwaWNhQ8wUvT6091Vja44xUB9AwDahR6JOK0R0p/GfVGGA6 WYZsLhFN7B28rpv3uiRYHAlrEGe/+nsCFdA33PH5xXbgygHHSLq8ZxnNyoUmr63f2y BbOJbFVvDqZBA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NWcKJ5xN5z6tmF for <60013@debbugs.gnu.org>; Tue, 13 Dec 2022 12:51:30 +0100 (CET) From: Florian In-Reply-To: <86tu20b2uu.fsf@gmail.com> References: <87edt47ecz.fsf@posteo.net> <91575b0f95b5a71b18108b57fa1a366e0f6044c9.1670876889.git.florhizome@posteo.net> <86tu20b2uu.fsf@gmail.com> Date: Tue, 13 Dec 2022 11:51:29 +0000 Message-ID: <87tu1zr072.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670932335; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=R+M+iA+2yqkk6Y3U9FrhfcLERwDhS/FvwOhDYRodtzc=; b=hL45BqHnaDmutDQ/WfywvpeYF/BZLaWqbWzjOOa4lmjfJMm9qW51g0PbCtJh3ww/0CNh8j NLDMC5ARToynQpqP4ZhnokuOMsRt7QI0Cy2ogc2jBuuMAifZOaYsTUH7l/tX0NAQEWkUNU AOtVCa+RgndrCq3+rlaIDIAMgUYoWfISSdR+7eyRfvvLg2MMf7jvXK6FhgffKmyHVMevVv stVbW8GDirTwQ9pZZGdlh3KDM8bC/QbNXN8vwe/SihkAOJ8TTvM0HY9z3AWJ5ontQwFjU/ UncJGCSrKtknh8JhMIX6j6nKYcUVsqYO7+jBeihfVYkCdo1ut4fxMB7vfHPZXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=pFxgCmXo; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670932335; a=rsa-sha256; cv=none; b=crEBr9zq/2eGq6rJIC63+D/cOlljbCXuhgqTGsQXVYwC6sqoUbJYIwlQsxO80gAp/h4sAz a+IOh7e7XLo4uYswZltQfZ7KizHNUw0itASUkm9iQuYwZmNf1fIQjlLLZ5vvfx9IPEM0XQ PS1R671eRdVJlkA190lADezO3xIM1bIbtWqQWYnD2VUg20BMWJfd95ZtPOJvIxQyyzBkWq aSGicdieq9K9S0b78ZIXl+yGQ4mTcwmU9LWGDOR9/QlYeMD04oM0hgd24Buhmy+IHMGfkt n69+47FQycB8J8ielwUTg7JjqIIn1w4/J6CrqbzgRjoI9Vwuoe4/5mJRs0ahlQ== X-Migadu-Spam-Score: -0.57 X-Spam-Score: -0.57 X-Migadu-Queue-Id: 02120FD7D X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=pFxgCmXo; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) X-TUID: sd03ceyBhaId Hi all, thanks for your comments. A revamped patch-set should be on the way soon, depending mostly on your's truly input on how to go on with the tests, but see below :) T B-R: That's how it was! Although these days my mails were as fast as a couple hours to appear on the mailing list, who could complain ;) unmatched-paren: I checked the projects for configure flags before I sent them. Unfortunately I am pretty sure, the remaining patches are not avoidable, since the variables are set by cmakes pkg-config queries, but correct me if wrong! I am no expert in any build system, but these things are often detectable I think :). (btw if there was an effort to write a blog post to document problems for nix/guix packaging, the use of pkg-config queries those should be explicitly mentioned, it's a pest!). About tests: I also can't find any tests in clight and clightd's repos. At least for libmodule I found how to build and enable tests https://github.com/FedeDP/libmodule/tree/16435d57b7600610313dc21301f3b5717480a3a8/tests So by setting this flag and packing valgrind and cmocka into 'native-inputs', two tests will be built and run. The one using valgrind will fail though: starting phase `check' Running tests... /gnu/store/j65q3aw414010gdfvmsynwpzfb2jyyd3-cmake-minimal-3.21.4/bin/ctest --force-new-ctest-process Test project /tmp/guix-build-libmodule-5.0.1.drv-0/build Start 1: ModuleTest 1/2 Test #1: ModuleTest ....................... Passed 1.21 sec Start 2: ModuleTest_valgrind 2/2 Test #2: ModuleTest_valgrind ..............***Failed 0.02 sec ==258== Memcheck, a memory error detector ==258== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al. ==258== Using Valgrind-3.17.0 and LibVEX; rerun with -h for copyright info ==258== Command: ./ModuleTest ==258== valgrind: Fatal error at startup: a function redirection valgrind: which is mandatory for this platform-tool combination valgrind: cannot be set up. Details of the redirection are: valgrind: valgrind: A must-be-redirected function valgrind: whose name matches the pattern: strlen valgrind: in an object with soname matching: ld-linux-x86-64.so.2 valgrind: was not found whilst processing valgrind: symbols from the object with soname: ld-linux-x86-64.so.2 valgrind: valgrind: Possible fixes: (1, short term): install glibc's debuginfo valgrind: package on this machine. (2, longer term): ask the packagers valgrind: for your Linux distribution to please in future ship a non- valgrind: stripped ld.so (or whatever the dynamic linker .so is called) valgrind: that exports the above-named function using the standard valgrind: calling conventions for this platform. The package you need valgrind: to install for fix (1) is called valgrind: valgrind: On Debian, Ubuntu: libc6-dbg valgrind: On SuSE, openSuSE, Fedora, RHEL: glibc-debuginfo valgrind: valgrind: Note that if you are debugging a 32 bit process on a valgrind: 64 bit system, you will need a corresponding 32 bit debuginfo valgrind: package (e.g. libc6-dbg:i386). valgrind: valgrind: Cannot continue -- exiting now. Sorry. 50% tests passed, 1 tests failed out of 2 Total Test time (real) = 1.23 sec And I'm not sure how to help with that. including (list glibc "debug") didn't do it. Do we need really need this test? The next question is then if the tests that are automatically run are those mentioned in the README on the projects wiki (see url above). Chime-in! zimoun: I think I have been leaving that indentation after (description in everything I contributed so far. I seriously hope I don't need to rework all of those just for that. But for the future, I know now ;) These also would be those "prerequisite-patch-ids" hanging around, that are generated by the --base=auto flag I use with git send-email like a good manual follower. I don't want to operate on multiple guix repos or branches, I find the workflow to keep one updated time-consuming enough so far... So I guess, to be frank, what can I actually do about that? Side Note: Of course this list would become smaller the more previous patches are actually merged *cough cough* most of whom are simple, one-hunk patches that should require the least amount of time :)