From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id DfVUKz1FX2T9zwAASxT56A (envelope-from ) for ; Sat, 13 May 2023 10:07:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SCOIKj1FX2ROHwAA9RJhRA (envelope-from ) for ; Sat, 13 May 2023 10:07:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 716F831279 for ; Sat, 13 May 2023 10:07:25 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxkHQ-0002F4-HC; Sat, 13 May 2023 04:07:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxkHO-0002DY-Ot for guix-patches@gnu.org; Sat, 13 May 2023 04:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxkHO-0005Ja-Ga for guix-patches@gnu.org; Sat, 13 May 2023 04:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxkHN-0003xa-Sx for guix-patches@gnu.org; Sat, 13 May 2023 04:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62827] [PATCH] image: Add partition type-uuid support. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 13 May 2023 08:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62827 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Aleksandr Vityazev , 62827@debbugs.gnu.org Received: via spool by 62827-submit@debbugs.gnu.org id=B62827.168396516615151 (code B ref 62827); Sat, 13 May 2023 08:07:01 +0000 Received: (at 62827) by debbugs.gnu.org; 13 May 2023 08:06:06 +0000 Received: from localhost ([127.0.0.1]:35694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxkGU-0003wI-Cs for submit@debbugs.gnu.org; Sat, 13 May 2023 04:06:06 -0400 Received: from jpoiret.xyz ([206.189.101.64]:37968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxkGT-0003wB-50 for 62827@debbugs.gnu.org; Sat, 13 May 2023 04:06:05 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id B2805184F27; Sat, 13 May 2023 08:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1683965164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CASfY7A0X10HvxJZR4Bgq5hQsN+3byz87b/FYrCBef0=; b=Dlp9OsHSnFq3Y8rs75md7gxe0LqXB2wHm1ncf5RYxhwh+nt7OLqg3u3gm3sNhWlh/6kEyJ ZJ7nGD2ZDEfonjYgalDR8Ou73JaQK/CLt57n3kZblt+WOtNQ/LROUOqktdwRcOCdY+8WUY cDAg6CNBAIrQq3Dy3rD9qAnyrmPNQ2tpK3EXVARIKqrzUt7Bfx3XKhpTqOLrPslwuXnbSr LZ07sRlhWispy19rq6nLk1HHc31Mj1dXYdn9CLgml5HaOe+ZRSM500TkiaMC8dLDGMI4pN ImDkb8snCt30CjF9vYrWcoJ0aPuEqi6UX+NgrF/IfbOOg1389eXbXHb/PkpDPA== In-Reply-To: <87pm87j6p1.fsf@gmail.com> References: <87pm87j6p1.fsf@gmail.com> Date: Sat, 13 May 2023 10:06:01 +0200 Message-ID: <87ttwgac5y.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683965245; a=rsa-sha256; cv=none; b=j8YDZveK6XRfEdkpasn/rb6yza7wCuZqUUGy0js+zaSP3cjWpqP218z8m6zgRXJC1KCvJm 7fPIkB+A/bInDo02kx7wFEmXn1iukVhPNq24R21oR2hFk8oZJAA8O8PDZTygNsxAXX8nz/ QlYNDkwJDs2ESUuuJj33dbJiHsgRB1YEAuYX/AayDmgScAzli3340Rz15wkj0OVXhMkgFd AfmkrUmfOxEnKSJyG/V/aTAD+6x29ufel0sbLoUastnagzws/egQGHJH0XCsNPBqNCDJgl Z5EhfujKif8I6u26FwK7SMQLUCc1DN7uz55Rs5i+is/4jsb2WVcJfm145Mae+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=Dlp9OsHS; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683965245; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=CASfY7A0X10HvxJZR4Bgq5hQsN+3byz87b/FYrCBef0=; b=rDjJLpx1/q0nFvrMf26IJPHCvnOB/qEk2QN/8HoCKAR0DvhR16RVLv7D0/XV08eg7E6Maa /NrIygIyhHzq/kVQ32hmAdmERQFFgU+piM7LUengKqcZOH2a8ej7C45qbkW80YwTyfjzJ4 jqh8jLkRfx1CUM7MfumwqY7b7eX2TvuQkiCtrlz0o/9yqWP2OdJUNanqjVl7i6zg421B9u XVS8/R0FW8YCVsSWcbv29zK1SG/G9mxg2RRB8TpGOxLjG9ngPMXLZPjSi5z1LToYnlyTTF t1eZYqRxmQqtCD3M6dZRGvv0f4vfOyOwAEzVL6xGSAUdnb/QWaCUDflhSJtT4Q== X-Migadu-Spam-Score: -5.78 X-Spam-Score: -5.78 X-Migadu-Queue-Id: 716F831279 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=Dlp9OsHS; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: Csrj8gly8+sb --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Aleksandr, Aleksandr Vityazev writes: > @@ -364,8 +365,10 @@ (define (partition->dos-type partition) > ;; Return the MBR partition type corresponding to the given PARTIT= ION. > ;; See: https://en.wikipedia.org/wiki/Partition_type. > (let ((flags (partition-flags partition)) > - (file-system (partition-file-system partition))) > + (file-system (partition-file-system partition)) > + (type-uuid (partition-type-uuid partition))) > (cond > + (type-uuid (uuid->string type-uuid)) > ((member 'esp flags) "0xEF") > ((string-prefix? "ext" file-system) "0x83") > ((or (string=3D? file-system "vfat") MBR partitions use a single byte to represent the type, and we don't have any corresponding uuid type for that, so this wouldn't work. Adding a UUID type for MBR should be the way forward. The GPT partition side seems good to me, but it would be nice if the description in the manual included the expected formats of the UUIDs, depending on the partition table type. Examples would be welcome there as well. Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCgAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmRfROkQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5FhcaipnuC/9G7Vr9qyfWBhFHuusXcZn78eskgzDGHebx 5Av7niB/zYvSeSTGV++7Dv8T2ubrWXMnll9fkyHyIcd6BUO2Jf/H4cdzcVvmJquV /oE65i5Z345h1b9UOHsamE5/kxVUsRACUoeD6L3nSVRGecGVW/BuLVtbyHMP3Qma G9TUS5NHlhYHUuQU6SB9BJWP9R+6XY39eg2kcuqPVD0mDIH6CnWMF9sONE2ZyBn/ ouNCNP6xBs4juVMLvegkM+lt2AbRYuDU2IVobdbpLjhN0MvYpW6LSit2jav1TnaT Lg8RzNlshabLfwQAsDoymUGPpdUNIS8j556KCJS/UKOntMqxHL0jxdxqaMmuYJdA IHRAgg5VUNGE0nYVsB5y9veXzGSxC52RJtDXqKH0sgITZZSaq+Xk01mFqOAOR0Zh E0mKyrd3Njm/QNJdIX3eXMF1ZprpxzeyXr9xoWzYb63oIJN6wiBERX1V++djD3Y+ HDWOqKXm/VO7FYGpUwppQ2GeAf/xcZ4= =x5zA -----END PGP SIGNATURE----- --=-=-=--