all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Guillaume Le Vaillant <glv@posteo.net>
To: Ahmad Draidi <a.r.draidi@redscript.org>
Cc: 63615@debbugs.gnu.org
Subject: [bug#63615] [PATCH v2 0/2] Restyle and update xmrig to 6.19.2
Date: Sun, 21 May 2023 11:23:06 +0000	[thread overview]
Message-ID: <87ttw5538x.fsf@kitej> (raw)
In-Reply-To: <7a61dcd0-4257-6376-2f70-b236b6dbfd9e@redscript.org>

A <a@redscript.org> skribis:

> Hello,
>
> On 5/21/23 12:30, Guillaume Le Vaillant wrote:
>> I didn't apply patch 1, as the restyling doesn't seem necessary in this
>> case.
> Out of curiosity, when would it be appropriate to send a "restyle" patch?
>> Patch 2 applied as 7b3f571fc8e3fbb3fefc30ebe53ad074c30653a8 with
>> a complete commit message.
>> Thanks.
> Thanks!

Restyling is usually done when a package is still using the old style
with labels for inputs, when it is using quasiquote forms for arguments
and using gexps would simplify things, or when it has very long lines
(more than 80 characters).




      reply	other threads:[~2023-05-21 11:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-20 19:50 [bug#63615] [PATCH 0/2] Restyle and update xmrig to 6.19.2 Ahmad Draidi via Guix-patches via
2023-05-20 19:55 ` [bug#63615] [PATCH 1/2] gnu: xmrig: Run 'guix style' over the package Ahmad Draidi via Guix-patches via
2023-05-20 19:55 ` [bug#63615] [PATCH 2/2] gnu: xmrig: Update to 6.19.2 Ahmad Draidi via Guix-patches via
2023-05-21  5:48 ` [bug#63615] [PATCH v2 0/2] Restyle and update xmrig " Ahmad Draidi via Guix-patches via
2023-05-21  5:48   ` [bug#63615] [PATCH v2 1/2] gnu: xmrig: Run 'guix style' over the package Ahmad Draidi via Guix-patches via
2023-05-21  5:48   ` [bug#63615] [PATCH v2 2/2] gnu: xmrig: Update to 6.19.2 Ahmad Draidi via Guix-patches via
2023-05-21  8:30   ` bug#63615: [PATCH v2 0/2] Restyle and update xmrig " Guillaume Le Vaillant
2023-05-21  8:53     ` [bug#63615] " A via Guix-patches via
2023-05-21 11:23       ` Guillaume Le Vaillant [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttw5538x.fsf@kitej \
    --to=glv@posteo.net \
    --cc=63615@debbugs.gnu.org \
    --cc=a.r.draidi@redscript.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.