From: Ricardo Wurmus <rekado@elephly.net>
To: Jelle Licht <jlicht@fsfe.org>, guix-devel@gnu.org
Subject: Re: npm has irreproducible install behavior
Date: Thu, 13 Jul 2023 10:41:14 +0200 [thread overview]
Message-ID: <87ttu8gpxs.fsf@elephly.net> (raw)
In-Reply-To: <877cr4i9u8.fsf@elephly.net>
Ricardo Wurmus <rekado@elephly.net> writes:
> Hi Jelle,
>
>>> I’ve tested this little addition to the build phases of node-lts on an
>>> affected system:
>>>
>>> --8<---------------cut here---------------start------------->8---
>>> (add-after 'install 'do-not-ignore-links
>>> (lambda* (#:key outputs #:allow-other-keys)
>>> (with-directory-excursion
>>> (string-append (assoc-ref outputs "out")
>>> "/lib/node_modules/npm/node_modules")
>>> (substitute* "pacote/lib/fetcher.js"
>>> (("\\/Link\\$\\/.test\\(entry.type\\)") "false")
>>> (("\\/File\\$\\/.test\\(entry.type\\)")
>>> "/(File|Link)$/.test(entry.type)"))
>>> --8<---------------cut here---------------end--------------->8---
>>
>> The proposed change seems fine to me, provided our QA shows a pretty
>> green button at some point. Could you send a patch that also includes a
>> comment referencing the upstream bug report?
>
> I changed it to patch node-tar instead, because the patch to fetcher.js
> would cause *some* files to be copied to the wrong location.
>
> I’ll send the updated patch to guix-patches today.
Here’s the patch set:
https://issues.guix.gnu.org/64592
The first patch is to clean up the snippet while we’re at it. The
second changes the behavior of node-tar, so that files with hardlinks
are not treated any different from files without.
--
Ricardo
prev parent reply other threads:[~2023-07-13 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 5:47 npm has irreproducible install behavior Ricardo Wurmus
2023-07-07 12:38 ` Jelle Licht
2023-07-13 6:48 ` Ricardo Wurmus
2023-07-13 8:41 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttu8gpxs.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=jlicht@fsfe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.