From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SIXHAW1+A2Wx/QAAG6o9tA:P1 (envelope-from ) for ; Thu, 14 Sep 2023 23:43:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id SIXHAW1+A2Wx/QAAG6o9tA (envelope-from ) for ; Thu, 14 Sep 2023 23:43:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F06FF4E9E6 for ; Thu, 14 Sep 2023 23:43:07 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="rUe/J+It"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694727788; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Jw9jP6CH2Eb0tDmj+DVYdbpfz2KM+E+eVxvIsx/kNrI=; b=lfYyaRcio0jQsJPgNr1VxCs/1iZZvjrThQIBRUMuKAGtcv/Dru3dtygqd7Lll2B0ejIUhP t7k9UUU0BK3wfJL4RxzHEgAokT+ouW+3/06VRGHEHU+jqkJsY4+9/TPin865BUuI0yngT7 LLmlX/4rht/cQFbedL4XQa1i2D79O+abZO4ff2oqucuGVrgA9a0E6NMPbhR12qndG8maa/ //k/RK6M7pxxIM4FW/6LbzNKaJvr6O8XGaMPP9WBYO0BUZaGk/r4yHATL95vBZQDTCcrNA a0FGSNCsQnqm6ncFPHbaY5UcUkZjl1chbAyKw3w2fVxoiY0tHOguzhUxg+Ltzw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="rUe/J+It"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694727788; a=rsa-sha256; cv=none; b=TOfGVliaouyopiPt6HR8JFjVKPuCyZw7c5u0JroSR+iIpHf/ju3owgh8bhITW7+9phlNoe zgvV0zFXgFNATUb0wX/6S6IXafpEfsvr1U7HarWJUOZe5Lld97WT/r+QKf8WN0XQDX6Yra nNWw4KpLIsFU9JoxN7BWU7HAs3FUdMaUeRu8xJ9pHgLObCpXq+KER1WBz/O9vhhkSU3os9 kBrUb/2Iz5XXeFPAssn15jIvtentIn3i/Y6SuC8uU/dTJZASiSeSlQpsNLKOXLMF7b6MLw P9rokWl/a58X4EPxDhKvkrsQ8zZrKHmubSGvAVFR6RzddhbM65ZYUItI931edg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgu6z-0003RG-NH; Thu, 14 Sep 2023 17:42:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgu6y-0003R7-OM for guix-patches@gnu.org; Thu, 14 Sep 2023 17:42:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgu6y-0003ZO-8E for guix-patches@gnu.org; Thu, 14 Sep 2023 17:42:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qgu74-0002qf-7r for guix-patches@gnu.org; Thu, 14 Sep 2023 17:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65835] [PATCH] gnu: tensorflow-lite: Update to 2.13.0 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 14 Sep 2023 21:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65835 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai Cc: 65835@debbugs.gnu.org Received: via spool by 65835-submit@debbugs.gnu.org id=B65835.169472777710935 (code B ref 65835); Thu, 14 Sep 2023 21:43:02 +0000 Received: (at 65835) by debbugs.gnu.org; 14 Sep 2023 21:42:57 +0000 Received: from localhost ([127.0.0.1]:41377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgu6z-0002qI-75 for submit@debbugs.gnu.org; Thu, 14 Sep 2023 17:42:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qgu6v-0002q2-D5 for 65835@debbugs.gnu.org; Thu, 14 Sep 2023 17:42:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgu6h-0003YB-Lq; Thu, 14 Sep 2023 17:42:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Jw9jP6CH2Eb0tDmj+DVYdbpfz2KM+E+eVxvIsx/kNrI=; b=rUe/J+ItRyAOSAKb1dNj ytQeoKRH+QxDXE4c8/SELRYxMdEWTisaNjFk9YtktfowH5zwA3O/twmD1w3mbYWAMnY4nmud8Z9sC X0Wf3G3mXcn6iuZayi4VJdsiWEZXJyoJedlh4thMvw0p3kA5JX/rwfUgh0DGmC0G8znc8EJ90ke+x dyhWnePsb0NUlAUFPNuHuluUWsq43Hb+77c53IrHthilErCx0YCnUEAyF51RT5uZd8ekeIRfd+94e sxB9ZnoxA+7vwWfhvT5nNi01bV66DoRhq8tRfuUHSk7U95zWdyu1Br2LyxoQ4QjyQc5Sfw/MvfvKk u5qp1OzHlKocEw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Thu, 14 Sep 2023 23:42:18 +0200 In-Reply-To: (Andy Tai's message of "Sun, 10 Sep 2023 00:23:42 -0700") Message-ID: <87ttrw3005.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -0.61 X-Spam-Score: -0.61 X-Migadu-Queue-Id: F06FF4E9E6 X-TUID: oIlPcsgZ+AFV Hi, Andy Tai skribis: > * gnu/packages/machine-learning.scm: (tensorflow-lite): > Update to 2.13.0 > [inputs]: Add gemmlowp > [native-inputs]: Remove gemmlowp-src > * gnu/packages/patches/tensorflow-lite-disable-local-cmake-3rdparty-compo= nents.patch: > New file Overall LGTM. Some comments=E2=80=A6 Could you add the patch to =E2=80=98gnu/local.mk=E2=80=99? > + (patches > + (search-patches > + ;; patch to disable local cmake build code for 3rdparty > + ;; componentas > + "tensorflow-lite-disable-local-cmake-3rdparty-components= .patch")))) Please add the comment at the top of the patch itself, as reported by =E2=80=98guix lint=E2=80=99; also adjust indentation here as in the other f= iles. > + (string-append "-Dgemmlowp_ROOT=3D" #$(this-package-input "gemm= lowp")) > + ) Please move paren to the previous line. > (invoke "tar" "--strip-components=3D1" > "-xf" (assoc-ref inputs "fft2d-src"))) >=20=20 > - (copy-recursively (assoc-ref inputs "gemmlowp-src") > - "/tmp/gemmlowp/"))) > + ;(copy-recursively (assoc-ref inputs "gemmlowp-src") > + ; "/tmp/gemmlowp/") > + > + )) Leftover? You can remove these two lines. Could you send an updated patch? Thanks in advance, Ludo=E2=80=99.