all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#66072: Duplicate/conflicting definitions for ocl-icd
@ 2023-09-18 12:34 Guillaume Le Vaillant
  2023-09-18 14:23 ` Lars-Dominik Braun
  0 siblings, 1 reply; 4+ messages in thread
From: Guillaume Le Vaillant @ 2023-09-18 12:34 UTC (permalink / raw)
  To: 66072; +Cc: Tobias Geerinckx-Rice, Lars-Dominik Braun

[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]

Hi.
There are currently two conflicting definitions of ocl-icd in
"opencl.scm":

--8<---------------cut here---------------start------------->8---
(define-public ocl-icd
  (deprecated-package "ocl-icd" opencl-icd-loader))
--8<---------------cut here---------------end--------------->8---

and

--8<---------------cut here---------------start------------->8---
(define-public ocl-icd
  (package
    (name "ocl-icd")
    (version "2.3.2")
    (source
     (origin
       (method git-fetch)
       (uri (git-reference
             (url "https://github.com/OCL-dev/ocl-icd")
             (commit (string-append "v" version))))
       (file-name (git-file-name name version))
       (sha256
        (base32 "0y0lnxb6zlhfb5vxxib5n1vvxa4b23qc0j3lsih6yjz9j37mj7wz"))))
    (build-system gnu-build-system)
    (native-inputs
     (list autoconf automake libtool ruby))
    (home-page "https://github.com/OCL-dev/ocl-icd")
    (synopsis "Generic OpenCL @acronym{ICD, Installable Client Driver} loader")
    (description
     "This package provides an OpenCL @acronym{ICD, Installable Client Driver}
loader.  It maintains a YAML database of all known and guessed function pointers
from vendor-specific drivers.  It also delivers a skeleton of bindings to
incorporate inside an OpenCL implementation to give it ICD functionalities.")
    (license license:bsd-2)))
--8<---------------cut here---------------end--------------->8---

Which is the good one?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#66072: Duplicate/conflicting definitions for ocl-icd
  2023-09-18 12:34 bug#66072: Duplicate/conflicting definitions for ocl-icd Guillaume Le Vaillant
@ 2023-09-18 14:23 ` Lars-Dominik Braun
  2023-09-18 17:57   ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
  0 siblings, 1 reply; 4+ messages in thread
From: Lars-Dominik Braun @ 2023-09-18 14:23 UTC (permalink / raw)
  To: Guillaume Le Vaillant; +Cc: Tobias Geerinckx-Rice, 66072

Hi,

> Which is the good one?

according to commit 4d1157fca7627c11672df0cd80fae4f4d27e2185 ocl-icd
was dead, which is why I replaced it. I cannot tell which one is better
though. Tobias maybe?

Lars





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#66072: Duplicate/conflicting definitions for ocl-icd
  2023-09-18 14:23 ` Lars-Dominik Braun
@ 2023-09-18 17:57   ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
  2023-09-21 15:44     ` Guillaume Le Vaillant
  0 siblings, 1 reply; 4+ messages in thread
From: Tobias Geerinckx-Rice via Bug reports for GNU Guix @ 2023-09-18 17:57 UTC (permalink / raw)
  To: Lars-Dominik Braun; +Cc: Guillaume Le Vaillant, 66072

Hi Lars, Guillaume,

Thanks for catching the duplicate!  I removed the ‘deprecated’ one in 
commit 71ec12d8bacd3901e8c7853d3c9403f3d09dfb31.

On 2023-09-18 16:23, Lars-Dominik Braun wrote:
>> Which is the good one?
> 
> according to commit 4d1157fca7627c11672df0cd80fae4f4d27e2185 ocl-icd
> was dead, which is why I replaced it.

It's not clear to me how opencl-icd-loader is related to ocl-icd, so I 
can't partake in that discussion.  They look like totally different 
packages to me.

My only motivation was to fix beignet, which was broken by the 
ocl-icd(.h) removal.

Kind regards,

T G-R

Sent from a Web browser.  Excuse or enjoy my brevity.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#66072: Duplicate/conflicting definitions for ocl-icd
  2023-09-18 17:57   ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
@ 2023-09-21 15:44     ` Guillaume Le Vaillant
  0 siblings, 0 replies; 4+ messages in thread
From: Guillaume Le Vaillant @ 2023-09-21 15:44 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: 66072-done, Lars-Dominik Braun

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

As the duplicate has been removed, I'm closing the issue.
If one day we find a conflict between open-icd-loader and ocl-icd, we'll
open a new bug report.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-09-21 15:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-18 12:34 bug#66072: Duplicate/conflicting definitions for ocl-icd Guillaume Le Vaillant
2023-09-18 14:23 ` Lars-Dominik Braun
2023-09-18 17:57   ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2023-09-21 15:44     ` Guillaume Le Vaillant

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.