From: "Ludovic Courtès" <ludo@gnu.org>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: guix-devel@gnu.org, 65866@debbugs.gnu.org,
Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: Re: bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts
Date: Tue, 19 Sep 2023 16:43:34 +0200 [thread overview]
Message-ID: <87ttrqcjft.fsf_-_@gnu.org> (raw)
In-Reply-To: <CAJ3okZ2WSMNQ7vWViMLvGtT4Ku-fR3QKGhMC5DQEQ4w35jCWKA@mail.gmail.com> (Simon Tournier's message of "Mon, 18 Sep 2023 16:45:00 +0200")
Hi Simon,
Simon Tournier <zimon.toutoune@gmail.com> skribis:
> On Mon, 18 Sept 2023 at 15:56, Ludovic Courtès <ludo@gnu.org> wrote:
>
>> Anyhow, how about this plan:
>>
>> 1. Merge <https://issues.guix.gnu.org/65866> with the hard Git
>> dependency.
>
> Is #65866 fixing bug#63331 (Guile-GnuTLS/Git circular dependency) [1]?
Yes, as written in the cover letter.
[...]
>> 2. When libgit2 1.7 with shallow clones is available in Guix, work on
>> a patch to use Guile-Git for clones and evaluate it.
>
> ...we could also suggest to continue and have a complete fix of #63331
> before merging #65866.
Sorry, I don’t understand. As I wrote in the cover letter, this patch
series is the complete fix for <https://issues.guix.gnu.org/63331>.
> It avoids to introduce a hard dependency which will be difficult to
> remove and let the time for this evaluation of libgit-2.1.7, no?
What this patch series sets in stone is “builtin:git-download” and its
semantics.
Its implementation can change over time though: it can switch to
libgit2, to OCaml-Git, or anything that pleases us. These are
implementation details not visible from the outside.
>> As I wrote, as an example, I don’t think that there could be a practical
>> implementation of (guix git-authenticate) shelling out to ‘git’.
>
> [...]
>
>> PS: I don’t buy the “libgit2 will disappear from Guix” argument because
>> it’s not a natural phenomenon that we’re observing but a willful
>> construction.
>
> As I wrote elsewhere, Git-Annex (or Magit) are shelling out to 'git',
> IIRC. Well, personally I do not consider that Git-Annex is slow or
> that Git-Annex does not implement features as complex as (guix
> git-authenticate).
>
> After reading [2],
>
> I cannot imagine a viable implementation of things like ‘commit-closure’
> and ‘commit-relation’ from (guix git) done by shelling out to ‘git’.
> I’m quite confident this would be slow and brittle.
>
> wolf came 3 days later [3] with a first rough implementation for
> 'commit-relation' using Git plumbing which is much more faster than
> the one implemented with Guile-Git.
Yes, point taken. It’s not so much about whether Git-Annex is “less
complex”, it’s about the level of integration needed. But you don’t
have to take my word for it.
We’ve spent lots of words on the issue of a dependency on Git, and yet
this patch series doesn’t actually change much in that regard:
‘git-fetch’ already uses Git.
I suggest that we focus on the various sub-problems we’re trying to
solve without losing sight of the big picture, yet without conflating
them all.
Ludo’.
next prev parent reply other threads:[~2023-09-19 14:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 15:17 hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) Simon Tournier
2023-09-11 17:51 ` wolf
2023-09-11 18:26 ` Maxim Cournoyer
2023-09-11 22:48 ` comparing commit-relation using Scheme+libgit2 vs shellout plumbing Git Simon Tournier
2023-09-12 11:07 ` Attila Lendvai
2023-09-14 10:30 ` Ludovic Courtès
2023-09-14 11:56 ` Simon Tournier
2023-09-11 17:52 ` hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) Simon Tournier
2023-09-11 18:20 ` Maxim Cournoyer
2023-09-12 9:06 ` Josselin Poiret
2023-09-12 12:56 ` Maxim Cournoyer
2023-09-12 14:08 ` wolf
2023-09-14 10:22 ` Ludovic Courtès
2023-09-14 16:51 ` Ludovic Courtès
2023-09-14 17:28 ` Simon Tournier
2023-09-17 2:16 ` Maxim Cournoyer
2023-09-18 13:56 ` [bug#65866] " Ludovic Courtès
2023-09-18 14:45 ` Simon Tournier
2023-09-19 14:43 ` Ludovic Courtès [this message]
2023-09-19 17:09 ` bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts Simon Tournier
2023-09-11 19:35 ` hard dependency on Git? (was bug#65866: [PATCH 0/8] Add built-in builder for Git checkouts) Vagrant Cascadian
2023-09-11 21:23 ` Csepp
2023-09-12 7:44 ` Simon Tournier
-- strict thread matches above, loose matches on Subject: below --
2023-09-21 7:42 [bug#65866] [PATCH 0/8] Add built-in builder for Git checkouts Ludovic Courtès
2023-09-22 22:27 ` [bug#65866] [PATCH v2 " Ludovic Courtès
2023-09-22 22:28 ` [bug#65866] [PATCH v2 7/8] git-download: Use “builtin:git-download” when available Ludovic Courtès
2023-09-25 8:33 ` Simon Tournier
2023-09-25 9:23 ` [bug#65866] [PATCH 0/8] Add built-in builder for Git checkouts Ludovic Courtès
2023-09-25 12:48 ` Simon Tournier
2023-09-26 15:44 ` bug#65866: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttrqcjft.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=65866@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.