From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id yNnsFsJkNmU5gAAA9RJhRA:P1 (envelope-from ) for ; Mon, 23 Oct 2023 14:19:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yNnsFsJkNmU5gAAA9RJhRA (envelope-from ) for ; Mon, 23 Oct 2023 14:19:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 159CA4490F for ; Mon, 23 Oct 2023 14:19:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=lS51KyRt; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698063554; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dgtO4D4yeamTxCK/vp/FjvpyfviP+lymouZqUo3H5Ws=; b=VLBCJbbwwIkQvk8aUZYR39W9YSAmclV09APwf2z9OfdukyqlVfjxaN/rYdatvNUAbRByc7 gcT5zsniGgq5iEMGjHCltO0phS5bP4urxtJQeCtwxRhB3KlheUr9bByzJyC9Iu37mviiOH ySlp4jJCQhqICOyi46OXs7uxJH5wasSyy9PjU5GHmQDL1zSABdxhJyLjmTCqDrIGty9F0t Zt/MsaUBjHc5FoCecTXbM3L+S5Hy4fM5imd/x+C7sTAr/OaXaOfEJqTmPAcfQXvPjcGPFG bw4q7ef1jlfRLinehjqXAUWoiUOrT98ULZFyy8rRzGnFcJZS9l5e7BNHkD1x1A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=lS51KyRt; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698063554; a=rsa-sha256; cv=none; b=XLZ5EG8dfwR+YUUjiKaB21+57ssVUzMvW/P09/68mq4P7Ax4bqe8qffdh6ajssl/GCgJwp hMX+VoW6UgCs7Zw+FWFMQ3szoOc3AF1Lf26WwdlTa8K3XxVw0i1h8kW5Pnog98p9WUPSME 8X9Ir1bsTENPdasR7ko07qAbzSdwUeHZukQqQ93LhNXWAv1QmRuyuInw8BEBbtsHGEln8d LK9lip5v0ZP5GV2srARYDk3iVxgZRdOOSZtv65bDtuBRZq1wow9jvM6BFkR7UO4QzNpPeM 4kY9HrvLEh+nzGWwfS9IdqsM04gf+IciIUSgfmgeK1hnxNcqyxrSFDIFZHF4Sg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quttF-0002Rk-HU; Mon, 23 Oct 2023 08:18:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quttD-0002Ph-U2 for guix-patches@gnu.org; Mon, 23 Oct 2023 08:18:35 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quttD-0005WI-Km for guix-patches@gnu.org; Mon, 23 Oct 2023 08:18:35 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1quttg-0006og-Ic for guix-patches@gnu.org; Mon, 23 Oct 2023 08:19:04 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66618] [PATCH] etc: gitconfig: Remove the default email address to avoid mistakes. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Oct 2023 12:19:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66618 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Maxim Cournoyer Cc: 66618@debbugs.gnu.org, =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Received: via spool by 66618-submit@debbugs.gnu.org id=B66618.169806349326014 (code B ref 66618); Mon, 23 Oct 2023 12:19:04 +0000 Received: (at 66618) by debbugs.gnu.org; 23 Oct 2023 12:18:13 +0000 Received: from localhost ([127.0.0.1]:49268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qutsq-0006lP-LY for submit@debbugs.gnu.org; Mon, 23 Oct 2023 08:18:13 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:38941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qutso-0006kx-K2 for 66618@debbugs.gnu.org; Mon, 23 Oct 2023 08:18:11 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-408423fc784so2401315e9.0 for <66618@debbugs.gnu.org>; Mon, 23 Oct 2023 05:17:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698063456; x=1698668256; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=dgtO4D4yeamTxCK/vp/FjvpyfviP+lymouZqUo3H5Ws=; b=lS51KyRtJzxk2BDGo38pVkBYVw0jhn9VkoxeL9GWgGtEQuhJc0VPh5C4f5igYuvCB/ WL/5jEX6ATDQBWs5MNfCbkXlKa1WgdYio0qc900vU0VsCvfpwHeokzRWKvAF7W5CkLL2 qiftmbS23G2ATPZY82cTHC3srBUMOj0gOWXbCCABFx5Ez6ujuzhT7D+VmclmgVJhBapu U6xhj38e3LWLCGfjuhQf7X9/y0h7QeIY+UR4/ftk+F2kxvO7kIOuyGTqJW+cyRfY/0jw q/ty2G26AQuQJSfwEWUmMdKcgUhbP44kNxZQHLCr94e+5lwX3gaLYrl2AsoNi0VAiWgE ngDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698063456; x=1698668256; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dgtO4D4yeamTxCK/vp/FjvpyfviP+lymouZqUo3H5Ws=; b=CSkBM17YnikuNK/xTcrw1E6yWs2HDylVDicS9Soh6QbQXEUlFQj/pJVd2uxFWwXtag o1OekYQ0atwvzS1UNYa8N3XXKhGcoyXJN8f1Ks3jKUcnO8GXZHyvlkoR9t+vYoeyH3o3 bIDcg8Fgxwd3jN2DTroxIchvHzMlHJoe0HXw0JlQ7U2OP06Xf6wYfoh/VgYdsjld6hpi +niPBz1vB8q7YeojYACEFl6+RhG7VuyShfdWSgUnd6HVnp2mz8kLhoA1focukRaozlrz IIYTuFADm/YjB7CCVQMH9b6BFQwnxz/CKYH5AFyPvr4gRrBpMUkjbeZeEMCRV4x7b2Op CZSQ== X-Gm-Message-State: AOJu0Yzs0MK9R6cYgTiGAbDnkBUMJzvYMa3kQyeLBWrzQt96knFt0Ge/ 5vwFtkUEVrQqu1kxnd7xv88= X-Google-Smtp-Source: AGHT+IEoar55gf7jS1EKiLC5oHcb3d4EcM2/cIrYeSoayOhS9vVFcQ0MWPehyWTFcyXjQ8RW4LwaJQ== X-Received: by 2002:a05:600c:6025:b0:3fe:d637:7b25 with SMTP id az37-20020a05600c602500b003fed6377b25mr6919411wmb.0.1698063455649; Mon, 23 Oct 2023 05:17:35 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id t6-20020a05600c450600b0040535648639sm9319532wmo.36.2023.10.23.05.17.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 05:17:35 -0700 (PDT) From: Simon Tournier In-Reply-To: <87y1fxguxk.fsf@gmail.com> References: <87pm1bqtp1.fsf@gmail.com> <87zg0em529.fsf@gmail.com> <87cyx9mlq4.fsf@gmail.com> <87y1fxguxk.fsf@gmail.com> Date: Mon, 23 Oct 2023 11:49:23 +0200 Message-ID: <87ttqhllcs.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 5.38 X-Spam-Score: 5.38 X-Migadu-Queue-Id: 159CA4490F X-Migadu-Scanner: mx2.migadu.com X-TUID: dzQtL0pOwg3I Hi Maxim, On Fri, 20 Oct 2023 at 11:44, Maxim Cournoyer w= rote: >> Here, the default >> >> [sendemail] >> to =3D guix-patches@gnu.org >> >> makes something implicit =E2=80=93 which is not necessary bad =E2=80=93 = but it hides >> potential errors =E2=80=93 which is not good. > > But that's true for any automation of git. I disagree. The aim of automation is to hide burden without being error-prone. > If we follow that logic we > can remove the other git configurations because they may be surprising, The point is about being able to catch and adjust accordingly. Except this =E2=80=99sendemail.to=E2=80=99 value, all the other values may be surp= rising but if one is surprised, then one is aware of the non-default Git configuration and thus one is able to adjust accordingly. The issue with =E2=80=99sendemail.to=E2=80=99 is that there is no surprise = popping; for being surprised, I need to be aware and here it does it in my back. > and the send-email hook that notifies people, because that can again be > surprising. I disagree. For example, I think =E2=80=99sendemail.headerCmd=E2=80=99 is = a good default. Because it hides the burden and correct my potential mistake. Well, somehow there is =E2=80=9Cgood=E2=80=9D surprise and =E2=80=9Cbad=E2= =80=9D surprise. For me, =E2=80=99sendemail.to=E2=80=99 leads to =E2=80=9Cbad=E2=80=9D surprise and = =E2=80=99sendemail.headerCmd=E2=80=99 leads to =E2=80=9Cgood=E2=80=9D surprise. For me, =E2=80=99sendemail.headerCmd=E2=80=99 helps because it behaves in a= way that most users will expect the system to behave. That=E2=80=99s POLA. However, =E2=80=99sendemail.to=E2=80=99 does not appear to me POLA because it hides = my potential mistake. > The small cost in surprise is > offset by removing manual work for myself and I'd expect/hope other > committers. Well, from my point of view, it is possible to use other means for removing some manual work. For instance, it is possible to have an alias in etc/gitconfig, as =E2=80=9Cgit send-patches=E2=80=9D. Or it is po= ssible to use =E2=80=99sendemail.aliasesFile=E2=80=99 for having a short key to pass. Or= else. You said: OK! I'll leave this opened for a bit longer to allow for others to= tip in, after which I'll do so. and now you have two opinions by two Guix committers :-) =E2=80=93 not git-send-email experts though but having some habits for using it. ;-) That=E2=80=99s said, I do not have a strong opinion either. I can live wit= h the default value since I always explicitly uses =E2=80=99--to=3D=E2=80=99. :-)= And if this default value suits your productivity, it is totally fine with me. Cheers, simon