From: Zheng Junjie <zhengjunjie@iscas.ac.cn>
To: Dariqq <dariqq@posteo.net>
Cc: 71653@debbugs.gnu.org
Subject: [bug#71653] [PATCH] import/github: Honor upstream-name property.
Date: Sun, 23 Jun 2024 14:21:49 +0800 [thread overview]
Message-ID: <87tthkji0y.fsf@iscas.ac.cn> (raw)
In-Reply-To: <9c451854e49750ed14b11b0cee3d4c2ccea51e3a.1718814397.git.dariqq@posteo.net> (dariqq@posteo.net's message of "Wed, 19 Jun 2024 16:26:37 +0000")
[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]
Dariqq <dariqq@posteo.net> writes:
> * guix/import/github.scm (import-release): Use 'upstream-name if available.
>
> Change-Id: I9a4999a01156ce02584270837ceab70996b49106
> ---
> guix/import/github.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/guix/import/github.scm b/guix/import/github.scm
> index c5556d78ee..164fcde458 100644
> --- a/guix/import/github.scm
> +++ b/guix/import/github.scm
> @@ -328,8 +328,9 @@ (define* (import-release pkg #:key (version #f))
> (let* ((original-uri (origin-uri (package-source pkg)))
> (source-uri (github-uri original-uri))
> (name (package-name pkg))
^------------ I think maybe just use "package-upstream-name" on this?
> + (upstream-name (assoc-ref (package-properties pkg) 'upstream-name))
> (newest-version version-tag
> - (latest-released-version source-uri name
> + (latest-released-version source-uri (or upstream-name name)
> #:version version)))
> (if newest-version
> (upstream-source
>
> base-commit: c551e406a75273583ae3fef92f32468f905cc07f
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2024-06-23 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 16:26 [bug#71653] [PATCH] import/github: Honor upstream-name property Dariqq
2024-06-23 6:21 ` Zheng Junjie [this message]
2024-06-23 8:05 ` Dariqq
2024-06-23 8:03 ` [bug#71653] [PATCH v2] " Dariqq
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tthkji0y.fsf@iscas.ac.cn \
--to=zhengjunjie@iscas.ac.cn \
--cc=71653@debbugs.gnu.org \
--cc=dariqq@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.