From: Z572 <zhengjunjie@iscas.ac.cn>
To: Fabio Natali via Guix-patches via <guix-patches@gnu.org>
Cc: 72338-done@debbugs.gnu.org, Fabio Natali <me@fabionatali.com>
Subject: bug#72338: [PATCH] gnu: readymedia: Add coreutils to dependencies.
Date: Thu, 01 Aug 2024 23:55:18 +0800 [thread overview]
Message-ID: <87ttg4w849.fsf@iscas.ac.cn> (raw)
In-Reply-To: <e5efe2bcb63d408f2dd50bc1ac298de164e40a8b.1722336973.git.me@fabionatali.com> (Fabio Natali via Guix-patches via's message of "Tue, 30 Jul 2024 11:58:03 +0100")
[-- Attachment #1: Type: text/plain, Size: 1813 bytes --]
Fabio Natali via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/upnp.scm (readymedia)[inputs]: Add coreutils.
>
> Change-Id: I8f73802bd0d8fecbf5ee20853eccefc2eef82411
> ---
> Hi Zheng,
>
> Thanks for reviewing my patch. Please find below an updated version. Let me know
> should you spot anything else. 🙏
>
> Thanks, cheers, Fabio.
>
> gnu/packages/upnp.scm | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/upnp.scm b/gnu/packages/upnp.scm
> index aab68a6414..d85e1da956 100644
> --- a/gnu/packages/upnp.scm
> +++ b/gnu/packages/upnp.scm
> @@ -26,6 +26,7 @@
> (define-module (gnu packages upnp)
> #:use-module (gnu packages)
> #:use-module (gnu packages autotools)
> + #:use-module (gnu packages base)
> #:use-module (gnu packages check)
> #:use-module (gnu packages compression)
> #:use-module (gnu packages curl)
> @@ -154,12 +155,17 @@ (define-public readymedia
> #:phases
> (modify-phases %standard-phases
> (add-after 'unpack 'patch-source
> - (lambda _
> + (lambda* (#:key inputs #:allow-other-keys)
> (substitute* "Makefile.am"
> - ((".*LIBAVUTIL_LIBS.*") "")))))))
> + ((".*LIBAVUTIL_LIBS.*") ""))
> + (substitute* "minidlna.c"
> + (("rm -rf")
> + (string-append
> + (search-input-file inputs "/bin/rm") " -rf"))))))))
> (native-inputs (list autoconf automake gettext-minimal))
> (inputs
> - (list ffmpeg
> + (list coreutils-minimal
> + ffmpeg
> flac
> libexif
> libid3tag
>
> base-commit: 46a64c7fdd057283063aae6df058579bb07c4b6a
Thanks, push, close.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2024-08-01 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-28 15:20 [bug#72338] [PATCH] gnu: readymedia: Add coreutils to dependencies Fabio Natali via Guix-patches via
2024-07-30 5:17 ` Zheng Junjie
2024-07-30 10:58 ` Fabio Natali via Guix-patches via
2024-08-01 15:55 ` Z572 [this message]
2024-08-01 16:54 ` Fabio Natali via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttg4w849.fsf@iscas.ac.cn \
--to=zhengjunjie@iscas.ac.cn \
--cc=72338-done@debbugs.gnu.org \
--cc=guix-patches@gnu.org \
--cc=me@fabionatali.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.