From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id UK8OGtY3AmewcwEAqHPOHw:P1 (envelope-from ) for ; Sun, 06 Oct 2024 07:10:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id UK8OGtY3AmewcwEAqHPOHw (envelope-from ) for ; Sun, 06 Oct 2024 09:10:14 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=HPA6BFB1; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=key2 header.b=ZrX9W8d8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728198614; a=rsa-sha256; cv=none; b=HDbWh634UqnGT79an3OeIdbHXH+uFwILenRs/EtADP78bl+onQlaf7Iak91LhF5gKY/Pjl ACcm5RoaV14rIEWM3Iq0DHu/7yA99eg9x9VoyFxGDIfuJOKIH0ZMXmN8nsrmGrNCSuLZyC deV0SR9pfmhN9WkztuqBC3o+sNz9XtuHnSSJIWKS1Prf8/0aU+mTAHPq8zdZWyR0mfbMUk EkMq8NfS7zKNmIzgWF/cCJcKgq04pZaIpe89pucoub+wxQgqxNsS4Td9VLcIZq+y8Qjpiq GCbI4194LvhBPFOhIFpr/0YBY4abihdClsKfAs9PkXdO2XY5+CvIE3izxDxRZA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=HPA6BFB1; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=key2 header.b=ZrX9W8d8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728198614; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4WNa7NhaOKydQ6FIn9J86p+I+n2KhaouLgy1qS/jd8A=; b=Q3Nt+f64Zn3Ucs7vmU4/0SB8UGC8/iWZUAI7szbgsHtOaZc/p8GJjFUzpYdhl2ZNcGvZkR gkUklqk8bAwwyffQYaZlv1JXJqPrgmVdWcpF/xnCfVFxkr0mLZ08bXf/ZgmWqnK+tsl7ZK ldAFrC3RXB0Wa3TEa+hpB2yPx1RKa6vBxZmfwfhr0SxybMiTNlZD3OPmRNWnrrDBn2CGj0 jBZD3lOWCl+WdTIJr30T1vaRPuj9AcBQCTgbehvNjpr7VYmxP+eqvU99VIgCot65m9yNXA vGuQlABhXxIHZ6tT7pK92A6NbglLikWV456YdAsAay1LHIQx5bQbRhkrUarAXg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 05BAA5C7D for ; Sun, 06 Oct 2024 09:10:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxLOw-0004DT-Su; Sun, 06 Oct 2024 03:09:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxLOu-0004DJ-SQ for guix-patches@gnu.org; Sun, 06 Oct 2024 03:09:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sxLOu-0006fx-HN for guix-patches@gnu.org; Sun, 06 Oct 2024 03:09:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=4WNa7NhaOKydQ6FIn9J86p+I+n2KhaouLgy1qS/jd8A=; b=HPA6BFB1/SpzPmjuEeFBpxK2pS2itm691hmQeWfgN/UpUWyALIIQOIh8WQEa3pFQlkVvfDgIPy7dHKr3rG4I82ZzAFZoUb9TvKk6PDmZ1yUsg1vVnSu0IOMKE/L80QSrKmki7kYjXiLEcNcQjJl7oSfInp+cg6kHjqCW/U/z2lWLss4jal236acTcyaV31A0QJgAcjQdPS7X6qqsoRgQOueW9kJJlrGjQTXZ5cP41aK/PO8utk/XRWXDQrEc4b+x1glyRZVplCOaacSqmz6xKeKa47Fg9xQlz7OAlrb53LNQGEylnYr7xjl6mMlcOSUJfnwUEOE2Ll2vS6y+oFmwGA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sxLOz-0005UY-WE for guix-patches@gnu.org; Sun, 06 Oct 2024 03:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72867] [PATCH v6] gexp: Make 'local-file' follow symlinks. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Oct 2024 07:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72867 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Nigko Yerden , Christopher Baines , Attila Lendvai , 72867@debbugs.gnu.org Received: via spool by 72867-submit@debbugs.gnu.org id=B72867.172819855621038 (code B ref 72867); Sun, 06 Oct 2024 07:10:01 +0000 Received: (at 72867) by debbugs.gnu.org; 6 Oct 2024 07:09:16 +0000 Received: from localhost ([127.0.0.1]:40020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxLOG-0005TF-Bu for submit@debbugs.gnu.org; Sun, 06 Oct 2024 03:09:16 -0400 Received: from relay.yourmailgateway.de ([188.68.61.103]:54645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxLOE-0005T5-6A for 72867@debbugs.gnu.org; Sun, 06 Oct 2024 03:09:15 -0400 Received: from mors-relay-8403.netcup.net (localhost [127.0.0.1]) by mors-relay-8403.netcup.net (Postfix) with ESMTPS id 4XLtgR1Pmfz7yrB; Sun, 6 Oct 2024 09:09:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pelzflorian.de; s=key2; t=1728198547; bh=HgZN4grH38+h2XBKuv2N5LEThbOi2m2KnTh4HcoHnO4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZrX9W8d87RPzzATj9sbaVPWF74wnSNWuzhvAG7rAaHmMIMDI4jIPizNcyACuR+gK9 kNZ/xpse/Y7hUs05W2H2vaZTIJWpPmYhCnHfJ6V87nkIbqt67BGdwcqikZRYzcjNyP aPllXH+ktygayrjErOlcamj/MaJ4twStZ4ynxu5/QUwYuiIG0OAVnWu+D4W7EPou7z 6zGpueoMotB8R8q8H//RvwAttPvZQFWN1plspUNPjnes/7LXx+dA9/1OreEkgzhz67 msUKTffAMzoCNHZlFKKaOwDaUbECkA3DwAwdY4kn4n+iDOxpFak1o9QtVxN6WUHrGi PH6J90OPI8S2g== Received: from policy02-mors.netcup.net (unknown [46.38.225.35]) by mors-relay-8403.netcup.net (Postfix) with ESMTPS id 4XLtgR11Rxz7yr4; Sun, 6 Oct 2024 09:09:07 +0200 (CEST) Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy02-mors.netcup.net (Postfix) with ESMTPS id 4XLtgN6hdNz8sZg; Sun, 6 Oct 2024 09:09:04 +0200 (CEST) Received: from florianhp (ipb2186896.dynamic.kabel-deutschland.de [178.24.104.150]) by mxe217.netcup.net (Postfix) with ESMTPSA id 5CF1C84277; Sun, 6 Oct 2024 09:08:51 +0200 (CEST) From: "pelzflorian (Florian Pelz)" In-Reply-To: <8734ld5nin.fsf@pelzflorian.de> (pelzflorian@pelzflorian.de's message of "Thu, 03 Oct 2024 15:22:56 +0200") References: <3079fb8aa8eedc06db4c9faae9cd08774636b94d.1727334475.git.nigko.yerden@gmail.com> <87bk02wkem.fsf@gnu.org> <8734ld5nin.fsf@pelzflorian.de> Date: Sun, 06 Oct 2024 09:09:00 +0200 Message-ID: <87ttdpyagj.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5CF1C84277 X-Rspamd-Server: rspamd-worker-8404 X-NC-CID: bdMoev58lUHYtLqmVRUQI3fEXbaxmtlGeemglET28j8VYZBbaHlmKmdR X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.51 X-Spam-Score: -0.51 X-Migadu-Queue-Id: 05BAA5C7D X-Migadu-Scanner: mx12.migadu.com X-TUID: 3L1Gp7fHA/+Q My reply was lacking. I accidentally deleted footnote [1] https://git.savannah.gnu.org/cgit/guile.git/tree/ Ludovic Court=C3=A8s writes: >> --- a/guix/utils.scm >> +++ b/guix/utils.scm >> @@ -1121,11 +1121,7 @@ (define absolute-dirname >> (match (search-path %load-path file) >> (#f #f) >> ((? string? file) >> - ;; If there are relative names in %LOAD-PATH, FILE can be relati= ve and >> - ;; needs to be canonicalized. >> - (if (string-prefix? "/" file) >> - (dirname file) >> - (canonicalize-path (dirname file))))))) >> + (dirname (canonicalize-path file)))))) > > Am I right that we cannot keep the =E2=80=98if=E2=80=99 here, as it would= perform > =E2=80=9Clexical=E2=80=9D dot-dot resolution instead of Unix resolution (= accounting for > symlinks), right? Yes, exactly. Does not the mlambda Ludo had put in absolute-dirname resolve all canonicalize-path concerns? There are many patches, but all have the same file. Regards, Florian