Re: Packaging Proton Bridge: Progress Report #1

[Ian Eure <ian@retrospec.tv>]

Hi Marek,

Marek Paśnikowski <marek@marekpasnikowski.pl> writes:

> I copied and extended the invocation of "make" from the 
> gnu-build-system:
> (arguments
>   (list
>     #:phases '(modify-phases
>                %standard-phases
>                (add-before
>                  'build
>                  'make-project
>                  (lambda*
>                    (#:key (make-flags (list "build-nogui"))
>                           (parallel-build? #t)
>                     #:allow-other-keys)
>                    (invoke "find"
>                            "."
>                            "-name"
>                            "Makefile")
>                    (invoke "ls"
>                            "-al"
>                            "./src/github.com/ProtonMail/proton-bridge/v3")
>
>                    (apply invoke
>                           "make"
>                           "-e"
>                           "-C"
>                           "./src/github.com/ProtonMail/proton-bridge/v3"
>                           "--debug=basic"
>                           `(,@(if parallel-build?
>                                 `("-j" ,(number->string 
>                                 (parallel-job-count)))
>                                 '())
>                            ,@make-flags)))))
>     #:embed-files '(list "children" "nodes" "text")
>     #:unpack-path "github.com/ProtonMail/proton-bridge/v3"
>     #:import-path 
>     "github.com/ProtonMail/proton-bridge/v3/cmd/Desktop-
> Bridge"))
>
> I am getting some kind of progress, pasted below.  Before 
> continuing, I would
> appreciate confirmation whether I am on the right track.
>

You don’t need to copy anything from gnu-build-system, so your 
approach is unnecessarily complicated and duplicates work 
go-build-system needs to do.  Replace the lambda in that phase 
with a (lambda _) which calls:

    (invoke "make" "gofiles")

Or:

    (with-directory-excursion "utils" (invoke "./credits.sh" 
    "bridge"))

...which is what the Makefile runs to generate the credits source.

  -- Ian