all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Guillaume Le Vaillant <glv@posteo.net>
To: GNU Guix Live <cage-dev@twistfold.it>
Cc: 74818@debbugs.gnu.org
Subject: [bug#74818] [PATCH] gnu: cl-nodgui: Update to 0.7.2.0-2.9a1b2c6.
Date: Tue, 17 Dec 2024 10:50:36 +0000	[thread overview]
Message-ID: <87ttb2wpkz.fsf@kitej> (raw)
In-Reply-To: <edeca2d07f416296426137d778ec9490f667c33d.1734005596.git.cage-dev@twistfold.it> (GNU Guix Live's message of "Thu, 12 Dec 2024 12:16:15 +0100")

[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]

GNU Guix Live <cage-dev@twistfold.it> skribis:

> Change-Id: If230ce77603bfc30686a1036908687d461312b75
> ---
>  gnu/packages/lisp-xyz.scm | 25 ++++++++-----------------
>  1 file changed, 8 insertions(+), 17 deletions(-)
>
> diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
> index 16f3fe6b1b..ecbbd125f6 100644
> --- a/gnu/packages/lisp-xyz.scm
> +++ b/gnu/packages/lisp-xyz.scm
> @@ -22844,11 +22844,11 @@ (define-public ecl-nkeymaps
>    (sbcl-package->ecl-package sbcl-nkeymaps))
>  
>  (define-public sbcl-nodgui
> [...]
> +      (propagated-inputs
> +       (list tk tklib))
>        (inputs
>         (list sbcl-alexandria
>               sbcl-bordeaux-threads
> @@ -22878,19 +22880,8 @@ (define-public sbcl-nodgui
>               sbcl-sdl2-ttf
>               sbcl-static-vectors
>               sbcl-trivial-garbage
> -             sbcl-zpng
> -             tk
> -             tklib))
> -      (arguments
> -       (list #:phases
> -             #~(modify-phases %standard-phases
> -                 (add-after 'unpack 'fix-paths
> -                   (lambda* (#:key inputs #:allow-other-keys)
> -                     (substitute* "src/wish-communication.lisp"
> -                       (("#-freebsd \"wish\"")
> -                        (string-append "#-freebsd \""
> -                                       (search-input-file inputs "/bin/wish")
> -                                       "\""))))))))

Hi.
Why did you replace the 'fix-paths' phase by propagated inputs?
We usually try to avoid propagating inputs if possible as it can create
conflicts in profiles.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2024-12-17 10:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 11:16 [bug#74818] [PATCH] gnu: cl-nodgui: Update to 0.7.2.0-2.9a1b2c6 GNU Guix Live
2024-12-17 10:50 ` Guillaume Le Vaillant [this message]
2024-12-17 15:17   ` cage
2024-12-17 19:27   ` cage
2024-12-17 19:19 ` GNU Guix Live
2024-12-19 10:21   ` bug#74818: " Guillaume Le Vaillant
2024-12-19 19:57     ` [bug#74818] " cage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttb2wpkz.fsf@kitej \
    --to=glv@posteo.net \
    --cc=74818@debbugs.gnu.org \
    --cc=cage-dev@twistfold.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.