all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: vivien@planete-kraus.eu, 75167@debbugs.gnu.org
Subject: [bug#75167] [PATCH gnome-team 5/6] gnu: Add libspelling.
Date: Sun, 29 Dec 2024 13:34:08 +0900	[thread overview]
Message-ID: <87ttangla7.fsf@gmail.com> (raw)
In-Reply-To: <976552011b3d876652af1d401b4f1c8cddfb7d84.1735418244.git.liliana.prikler@gmail.com> (Liliana Marie Prikler's message of "Sat, 28 Dec 2024 21:34:59 +0100")

Hello,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> * gnu/packages/gnome.scm (libspelling): New variable.
> ---
>  gnu/packages/gnome.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index fea67718c37..f3568350f79 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -13612,6 +13612,40 @@ (define-public sysprof-3.44
>                              (("gtk-update-icon-cache") "true")
>                              (("update-desktop-database") "true"))))))))))
>  
> +(define-public libspelling
> +  (package
> +    (name "libspelling")
> +    (version "0.4.5")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://gitlab.gnome.org/GNOME/libspelling")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32 "030s821sb9rsr1ysl79x7id1bsin9idy8z7p85qr9cvw1w3f2s7r"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list #:phases
> +           #~(modify-phases %standard-phases
> +               (add-before 'check 'setup-home
> +                 (lambda _
> +                   ;; Tests require a writable HOME.
> +                   (setenv "HOME" (getcwd)))))))
> +    (inputs (list enchant gtk gtksourceview sysprof))
> +    (native-inputs
> +     (list gobject-introspection
> +           gi-docgen
> +           pkg-config
> +           vala

Please sort.

> +           ;; For testing

Please properly punctuate line comments (here, by adding trailing '.').

> +           aspell aspell-dict-en))
> +    (home-page "https://gitlab.gnome.org/GNOME/libspelling/")
> +    (synopsis "Spell-checking library for GTK 4")
> +    (description "This package provides a spell-checker for
> +GtkTextView widgets.")
> +    (license license:lgpl2.1+)))

Other than these two nitpicks, LGTM.

-- 
Thanks,
Maxim




  reply	other threads:[~2024-12-29  4:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-28 20:37 [bug#75167] [PATCH gnome-team 0/6] Update GNOME Builder to 47.2 Liliana Marie Prikler
2024-12-28 19:22 ` [bug#75167] [PATCH gnome-team 1/6] gnu: Add libpeas-2 Liliana Marie Prikler
2024-12-29  3:29   ` Maxim Cournoyer
2024-12-28 19:22 ` [bug#75167] [PATCH gnome-team 2/6] gnu: jsonrpc-glib: Update to 3.44.1 Liliana Marie Prikler
2024-12-28 19:23 ` [bug#75167] [PATCH gnome-team 3/6] gnu: libdex: Update to 0.8.1 Liliana Marie Prikler
2024-12-28 20:34 ` [bug#75167] [PATCH gnome-team 4/6] gnu: gom: Update to 0.5.3 Liliana Marie Prikler
2024-12-28 20:34 ` [bug#75167] [PATCH gnome-team 5/6] gnu: Add libspelling Liliana Marie Prikler
2024-12-29  4:34   ` Maxim Cournoyer [this message]
2024-12-28 20:35 ` [bug#75167] [PATCH gnome-team 6/6] gnu: gnome-builder: Update to 47.2 Liliana Marie Prikler
2024-12-29  4:38   ` Maxim Cournoyer
2024-12-29  4:38 ` [bug#75167] [PATCH gnome-team 0/6] Update GNOME Builder " Maxim Cournoyer
2024-12-29  8:31   ` bug#75167: " Liliana Marie Prikler
2024-12-30  2:49     ` [bug#75167] " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttangla7.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=75167@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.