From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH 1/2] Add (guix build-system cmake).
Date: Tue, 26 Mar 2013 23:09:10 +0100 [thread overview]
Message-ID: <87sj3hu83d.fsf@gnu.org> (raw)
In-Reply-To: <1364333243-27199-2-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Tue, 26 Mar 2013 22:27:22 +0100")
Cyril Roelandt <tipecaml@gmail.com> skribis:
> * guix/build/cmake-build-system.scm, guix/build-system/cmake.scm: New files.
> * Makefile.am (MODULES): Add them.
Overall looks good to me, nice!
> +;; Standard build procedure for packages using cmake. This is implemented as an
Please spell it as “CMake”. Also, two spaces after a period ending a
sentence.
> +(define* (cmake-build store name source inputs
Admittedly these bits look like copy/pasting, but I’m not sure how to
factorize more.
> + (description "The standard cmake build system")
“CMake”.
> +;; XXX Parallel tests are disabled by default because I have no idea how they
> +;; work in cmake.
CMake generates a Makefile, so running ‘make -jX’ just works. Thus you
can leave #:parallel-{build,tests}? to #t by default.
> +(define* (check #:key (tests? #t) (parallel-tests? #f) (test-target "test")
> + #:allow-other-keys)
> + (let ((gnucheck (assoc-ref gnu:%standard-phases 'check)))
s/gnucheck/gnu-check/
Cool!
Please push after fixing these.
Ludo’.
next prev parent reply other threads:[~2013-03-26 22:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 21:27 [PATCH 0/2] Add a cmake build system Cyril Roelandt
2013-03-26 21:27 ` [PATCH 1/2] Add (guix build-system cmake) Cyril Roelandt
2013-03-26 22:09 ` Ludovic Courtès [this message]
2013-03-28 20:16 ` Cyril Roelandt
2013-03-26 21:27 ` [PATCH 2/2] gnu: Add libopenjpeg Cyril Roelandt
2013-03-26 22:11 ` Ludovic Courtès
2013-03-26 22:40 ` Nikita Karetnikov
2013-03-27 8:44 ` Andreas Enge
2013-03-28 20:34 ` Cyril Roelandt
2013-03-27 8:47 ` Andreas Enge
2013-03-28 20:33 ` Cyril Roelandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj3hu83d.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=bug-guix@gnu.org \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.