From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Emacs interface for Guix
Date: Mon, 11 Aug 2014 22:54:17 +0200
Message-ID: <87sil2rbly.fsf@gnu.org>
References: <87k3719v7p.fsf@gmail.com> <87r419fa50.fsf@gnu.org>
	<87fvho9fqm.fsf@gmail.com> <87a97taixl.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44926)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XGwcJ-0002kx-6P
	for guix-devel@gnu.org; Mon, 11 Aug 2014 16:55:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XGwc9-0006a0-US
	for guix-devel@gnu.org; Mon, 11 Aug 2014 16:54:55 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:59316)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XGwc9-0006Zu-NE
	for guix-devel@gnu.org; Mon, 11 Aug 2014 16:54:45 -0400
In-Reply-To: <87a97taixl.fsf@gmail.com> (Alex Kost's message of "Mon, 28 Jul
	2014 14:15:02 +0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

Alex Kost <alezost@gmail.com> skribis:

> - A part of code for installing/upgrading/removing was extracted from
>   =E2=80=98guix-package=E2=80=99 function (from =E2=80=98process-actions=
=E2=80=99 more precisely).  So
>   the new function (I named it =E2=80=98process-package-actions=E2=80=99)=
 can be used in
>   "guix.el".

That looks good, but could you make it a separate patch?

In general, it=E2=80=99s better to send atomic changes, with a commit log, =
in
the format produced by =E2=80=98git format-patch=E2=80=99 (see HACKING.)  T=
hat
facilitates review and incremental changes.

> - A bit of code was placed into "profiles.scm" as =E2=80=98manifest-add=
=E2=80=99.

Good idea.  Could you send a single patch for this change?  I=E2=80=99ll ev=
en
add a couple of test cases in tests/profiles.scm for the new procedure
if you don=E2=80=99t do it yourself.  :-)

> - Also I think you forgot (?) to remove =E2=80=98deduplicate=E2=80=99 fun=
ction in commit
>   4ca0b41, so I did it as well.

Indeed, I=E2=80=99ve just removed it and a couple others.

Somehow I thought we were compiling with -Wunused-toplevel.

Thanks,
Ludo=E2=80=99.