all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/2] gnu: Add gnome-themes-standard.
Date: Mon, 03 Nov 2014 23:11:42 +0100	[thread overview]
Message-ID: <87sii07x41.fsf@gnu.org> (raw)
In-Reply-To: <CAKrPhPNzm7YRPjA98hO=ozc+3ynkb0-4Nb4zvY+hd_EiTWwADA@mail.gmail.com> (Federico Beffa's message of "Sun, 2 Nov 2014 18:21:17 +0100")

Federico Beffa <beffa@ieee.org> skribis:

> From 7439f19c1f2966466da88554478b796c3bfca429 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Sun, 2 Nov 2014 18:09:33 +0100
> Subject: [PATCH 2/2] gnu: Add gnome-themes-standard.
>
> * gnu/packages/gnome.scm (gnome-themes-standard): New variable.

[...]

> +;; The version of this package should be the same as the version of
> +;; gnome-desktop.
> +(define-public gnome-themes-standard
> +  (package
> +    (name "gnome-themes-standard")
> +    (version "3.10.0")

Please use (version (package-version gnome-desktop)) here, and put the
comment just above it.

> +       (uri (string-append "mirror://gnome/sources/" name "/" 
> +                           (string-take version 4) "/" name "-"

Use ‘version-major+minor’ instead of ‘string-take’.

OK to push with these changes.

Thanks!

Ludo’.

  reply	other threads:[~2014-11-03 22:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-02 17:21 [PATCH 2/2] gnu: Add gnome-themes-standard Federico Beffa
2014-11-03 22:11 ` Ludovic Courtès [this message]
2014-11-04 11:15   ` Federico Beffa
2014-11-04 16:52     ` Ludovic Courtès
2014-11-04 17:21       ` Federico Beffa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sii07x41.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=beffa@ieee.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.