From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] gnu: Add gnome-themes-standard.
Date: Tue, 04 Nov 2014 17:52:27 +0100
Message-ID: <87sihyzz5g.fsf@gnu.org>
References: <CAKrPhPNzm7YRPjA98hO=ozc+3ynkb0-4Nb4zvY+hd_EiTWwADA@mail.gmail.com>
	<87sii07x41.fsf@gnu.org>
	<CAKrPhPMi1rrQ7r0PzZHkmkq5vXdtGs953O8Ke6SjXd67iV+0vw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53986)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XlhL1-0000PI-Ix
	for guix-devel@gnu.org; Tue, 04 Nov 2014 11:52:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XlhKv-0006W3-E4
	for guix-devel@gnu.org; Tue, 04 Nov 2014 11:52:11 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:46814)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XlhKv-0006Vx-7Y
	for guix-devel@gnu.org; Tue, 04 Nov 2014 11:52:05 -0500
In-Reply-To: <CAKrPhPMi1rrQ7r0PzZHkmkq5vXdtGs953O8Ke6SjXd67iV+0vw@mail.gmail.com>
	(Federico Beffa's message of "Tue, 4 Nov 2014 12:15:15 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>

Federico Beffa <beffa@ieee.org> skribis:

> On Mon, Nov 3, 2014 at 11:11 PM, Ludovic Court=C3=A8s <ludo@gnu.org> wrot=
e:
>>> +;; The version of this package should be the same as the version of
>>> +;; gnome-desktop.
>>> +(define-public gnome-themes-standard
>>> +  (package
>>> +    (name "gnome-themes-standard")
>>> +    (version "3.10.0")
>>
>> Please use (version (package-version gnome-desktop)) here, and put the
>> comment just above it.
>
> I thought about this, but did not do it because, if the version
> changes, then you also need to change the hash.  So, if someone
> changes gnome-desktop without bothering about gnome-themes-standard,
> then the latter would break.

I think using (package-version gnome-desktop) would make the intent
clear, and the breakage that would occur would give a heads-up and an
incentive to fix it.

How does that sound?

Ludo=E2=80=99.