From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: luajit: Add -fPIC into CFLAGS.
Date: Tue, 16 Dec 2014 18:08:10 +0100
Message-ID: <87sigf7cat.fsf@gnu.org>
References: <1418683961-28525-1-git-send-email-sleep_walker@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48133)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y0vbd-00051F-Lw
	for guix-devel@gnu.org; Tue, 16 Dec 2014 12:08:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y0vbY-0005hl-0g
	for guix-devel@gnu.org; Tue, 16 Dec 2014 12:08:17 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:49868)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Y0vbX-0005hg-PU
	for guix-devel@gnu.org; Tue, 16 Dec 2014 12:08:11 -0500
In-Reply-To: <1418683961-28525-1-git-send-email-sleep_walker@suse.cz>
	(=?utf-8?B?IlRvbcOhxaEJxIxlY2giJ3M=?= message of "Mon,
	15 Dec 2014 23:52:41 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= <sleep_walker@suse.cz>
Cc: guix-devel@gnu.org

Tom=C3=A1=C5=A1 =C4=8Cech <sleep_walker@suse.cz> skribis:

> * gnu/packages/lua.scm (luajit): Add -fPIC into CFLAGS and pass it to mak=
e.

[...]

> --- a/gnu/packages/lua.scm
> +++ b/gnu/packages/lua.scm
> @@ -92,7 +92,8 @@ for configuration, scripting, and rapid prototyping.")
>      (arguments
>       '(#:tests? #f                      ;luajit is distributed without t=
ests
>         #:phases (alist-delete 'configure %standard-phases)
> -       #:make-flags (list (string-append "PREFIX=3D" (assoc-ref %outputs=
 "out")))))
> +       #:make-flags (list (string-append "CFLAGS=3D-fPIC " (or (getenv "=
CFLAGS") ""))
> +                          (string-append "PREFIX=3D" (assoc-ref %outputs=
 "out")))))

Could you add a comment explaining why this is needed?

Normally I would expect the makefiles to already contain that flag if
it=E2=80=99s needed.

Thanks,
Ludo=E2=80=99.