From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: Add SBCL. Date: Sat, 14 Feb 2015 22:45:30 -0500 Message-ID: <87sie7g7mt.fsf@netris.org> References: <878ug0dsif.fsf@taylan.uni.cx> <87iof4gihs.fsf@netris.org> <874mqnevbk.fsf@taylan.uni.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMq99-00045l-Uh for guix-devel@gnu.org; Sat, 14 Feb 2015 22:45:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMq96-0003ic-LE for guix-devel@gnu.org; Sat, 14 Feb 2015 22:45:27 -0500 Received: from world.peace.net ([50.252.239.5]:49556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMq96-0003iY-He for guix-devel@gnu.org; Sat, 14 Feb 2015 22:45:24 -0500 In-Reply-To: <874mqnevbk.fsf@taylan.uni.cx> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Sun, 15 Feb 2015 03:56:47 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Taylan Ulrich =?utf-8?Q?=22Bay=C4=B1rl=C4=B1?= =?utf-8?Q?=2FKammer=22?= Cc: guix-devel@gnu.org taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") writes: > Mark H Weaver writes: > >> It would be preferable to avoid this wrapper. I looked into this a bit. >> It looks like you can pass --prefix=3D to 'make.sh', and that will >> become hardcoded into the executable via SBCL_PREFIX and SBCL_HOME (see >> make-config.sh and runtime.c). It looks like this will also remove the >> need to set INSTALL_ROOT (which will be SBCL_PREFIX by default). [...] > Thanks for looking into it! Using --prefix=3D worked, and I didn't need > to patch the getenv call. One can now still set SBCL_HOME to something > else to override it explicitly, but I guess that would be considered a > feature; the executable runs fine, without a wrapper, when SBCL_HOME is > unset. Excellent :) Your updated patch looks good to me. Please push! Thanks, Mark