Re: [PATCH] gnu: Add audacity.

[ludo@gnu.org (Ludovic Courtès)]

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:

> Several weird issues with this one:
>
> - It tries to find libid3tag and libmad via pkg-config even though they
>   don't install .pc files.  Perhaps we can generate them manually in the
>   install phase of those packages, or maybe they just don't get
>   installed due to a bug.  Perhaps they just need 'pkg-config' as an
>   input?  I might try that next.

That would be surprising.  Perhaps the Audacity developers were using a
distro that adds .pc files for these two libs?

> - Audacity apparently uses PortAudio version 19, but the in-tree one has
>   a function which the upstream one doesn't.  It would be strange if
>   they had an API change without changing the version, so no idea what's
>   going on there.

Could you try to find out what the story of this function is?  It would
be best to avoid using the bundled PortAudio.

> - Dynamic loading of FFmpeg fails and I couldn't figure out why (it
>   didn't print any errors when I ran Audacity and normally it's pretty
>   verbose) so I just passed --disable-dynamic-loading and it was fine.

OK.

> - The test suite fails due to some missing portaudio.h file.  I didn't
>   come far trying to figure out why this happens so I just disabled the
>   test suite.

Perhaps that problem would magically vanish when using system’s
PortAudio because headers would be in $CPATH.

> From 82e8a7f2a708201ea7fd538580485546849347a3 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Fri, 20 Feb 2015 21:52:21 +0100
> Subject: [PATCH 9/9] gnu: Add audacity.
>
> * gnu/packages/audio.scm (audacity): New variable.
> * gnu/packages/patches/audacity-fix-ffmpeg-binding.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.

The rest of the patch looks good to me; just the PortAudio issue needs
to be resolved.

Perhaps Ricardo has an opinion?

Thanks,
Ludo’.