all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: 01/01: services: xorg: Fix file descriptor leak from SLiM/xinitrc.
Date: Mon, 02 Mar 2015 10:58:44 +0100	[thread overview]
Message-ID: <87sidn7maz.fsf@gnu.org> (raw)
In-Reply-To: <87y4ng0z0n.fsf@netris.org> (Mark H. Weaver's message of "Mon, 02 Mar 2015 00:06:00 -0500")

Mark H Weaver <mhw@netris.org> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> commit ec4a4c46efaf2e7373f331654640f1321c0f2e62
>> Author: Ludovic Courtès <ludo@gnu.org>
>> Date:   Sat Feb 28 22:44:31 2015 +0100
>>
>>     services: xorg: Fix file descriptor leak from SLiM/xinitrc.
>>     
>>     Previously processes started from the window manager would have a couple
>>     of leaked file descriptors: writable /var/log/slim.log and readable
>>     /gnu/store/…-xinitrc.
>>     
>>     * gnu/services/xorg.scm (xinitrc)[builder]: Add 'close-all-fdes'.  Use
>>       it in 'exec-from-login-shell'.
>
> This commit broke XFCE, so I've reverted it until we can investigate
> further.

I’ve had a couple of glitches too, which are apparently due to the fact
that this patch closes FDs 0, 1, and 2, which it shouldn’t.

Can you confirm that starting from FD 3 works for you too?

Thanks,
Ludo’.

  reply	other threads:[~2015-03-02  9:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150228232536.11051.24311@vcs.savannah.gnu.org>
     [not found] ` <E1YRqlM-0002tF-RU@vcs.savannah.gnu.org>
2015-03-02  5:06   ` 01/01: services: xorg: Fix file descriptor leak from SLiM/xinitrc Mark H Weaver
2015-03-02  9:58     ` Ludovic Courtès [this message]
2015-03-02 19:27       ` Mark H Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sidn7maz.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.