ludo@gnu.org (Ludovic Courtès) writes:

> Sorry for not being clear: I think we should avoid diverging from
> upstream in this way, especially if there’s just one package that makes
> the incorrect assumption.  So I would rather not add those .pc files.

All clear.  (No worries; it was my idea to copy Debian's patches.)

> If Audacity uses Autoconf and pkg.m4, I guess you could just pass
> PKG_CONFIG=true as a configure flag, or {LIBID3TAG,LIBMAD}_{CFLAGS,LIBS}
> and it will just work.

The latter option seems to work.  (I suppose the former was meant to be
"PKG_CONFIG=false"?  That seems to break the whole library search.)
Updated patch is attached; please tell me if the style is correct.

>> Note also it's in audacity.scm now and not audio.scm, because it depends
>> on ffmpeg, which is in video.scm, which now imports audio.scm, so
>> audio.scm cannot import video.scm.
>
> It actually can, but it’s fine (and safer) the way you propose.  :-)

Does Guile support circular imports?  (video.scm imports audio.scm on
the meanwhile, in case I wasn't clear about that, so I think we'll have
to avoid importing video.scm from audio.scm.)

>> +++ b/gnu/packages/patches/portaudio-audacity-compat.patch
>> @@ -0,0 +1,322 @@
>> +Description: Add features needed to make portmixer work with audacity.
>> +Author: Audacity Team
>> +Last-Update: 2011-12-07
>
> Could you add a link to PortAudio’s bug tracker or list?

Added a link to
<http://music.columbia.edu/pipermail/portaudio/2015-March/016611.html>
in the patch header.

Updated patches: