From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/4] gnu: shadow: User shells point to current profile
Date: Fri, 17 Apr 2015 13:54:43 +0200
Message-ID: <87sibzas1o.fsf@gnu.org>
References: <1429087551.701436.30155@badger> <87k2xbcf5y.fsf@gnu.org>
	<87r3rjghbd.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yj4rC-0001M9-RF
	for guix-devel@gnu.org; Fri, 17 Apr 2015 07:54:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Yj4r8-0001cF-Ge
	for guix-devel@gnu.org; Fri, 17 Apr 2015 07:54:50 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57819)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Yj4r8-0001cB-Et
	for guix-devel@gnu.org; Fri, 17 Apr 2015 07:54:46 -0400
In-Reply-To: <87r3rjghbd.fsf@gmail.com> (=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Fri, 17 Apr 2015 18:49:58 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: Andy Wingo <wingo@pobox.com>, guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:

[...]

>> I think we should instead generate /etc/shells based on the =E2=80=98she=
ll=E2=80=99
>> field of each user account, so that it matches exactly what=E2=80=99s be=
ing
>> used:

[...]

> Totally argee, and I find that my xterm will only work correctly
> when /etc/shell contains '/gnu/store/...-bash-.../bin/bash',
> otherwise launch a new xterm in an opened one will spawn 'sh'
> instead of 'bash'.

Right.  Committed as 8e974b9.  Let us know if you notice a regression!

Thanks for the quick feedback,
Ludo=E2=80=99.