From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] emacs: Improve 'guix-prettify-regexp'.
Date: Sun, 20 Sep 2015 18:43:54 +0200
Message-ID: <87si69jb1x.fsf@gnu.org>
References: <8737yavffm.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55202)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zdhia-0007QG-7T
	for guix-devel@gnu.org; Sun, 20 Sep 2015 12:44:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZdhiX-0005LZ-1g
	for guix-devel@gnu.org; Sun, 20 Sep 2015 12:44:00 -0400
In-Reply-To: <8737yavffm.fsf@gmail.com> (Alex Kost's message of "Sat, 19 Sep
	2015 14:03:57 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

Alex Kost <alezost@gmail.com> skribis:

> Hello, along with:
>
>   /gnu/store/=E2=80=A6-foo-0.1
>
> we have:
>
>   http://hydra.gnu.org/nar/=E2=80=A6-foo-0.1
>   http://hydra.gnu.org/log/=E2=80=A6-foo-0.1
>
> I think it would be good to "prettify" such things as well, so what
> about the attached patch?

Makes sense.

> From 5914f7007d1b27c0fa8594df4c1cff5fdd35e359 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Sat, 19 Sep 2015 13:55:59 +0300
> Subject: [PATCH] emacs: Improve 'guix-prettify-regexp'.
>
> * emacs/guix-prettify.el (guix-prettify-regexp): Modify to handle "nar"
>   and "log".

[...]

>  (defcustom guix-prettify-regexp
> -  (rx "/"
> -      (or "nix" "gnu")
> -      "/store/"
> +  (rx "/" (or "store" "nar" "log") "/"

Maybe explicitly show in a comment the URLs and file names that we
intend to match.

Otherwise LGTM, thanks!

Ludo=E2=80=99.