all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] emacs: Improve 'guix-prettify-regexp'.
Date: Sun, 20 Sep 2015 18:43:54 +0200	[thread overview]
Message-ID: <87si69jb1x.fsf@gnu.org> (raw)
In-Reply-To: <8737yavffm.fsf@gmail.com> (Alex Kost's message of "Sat, 19 Sep 2015 14:03:57 +0300")

Alex Kost <alezost@gmail.com> skribis:

> Hello, along with:
>
>   /gnu/store/…-foo-0.1
>
> we have:
>
>   http://hydra.gnu.org/nar/…-foo-0.1
>   http://hydra.gnu.org/log/…-foo-0.1
>
> I think it would be good to "prettify" such things as well, so what
> about the attached patch?

Makes sense.

> From 5914f7007d1b27c0fa8594df4c1cff5fdd35e359 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Sat, 19 Sep 2015 13:55:59 +0300
> Subject: [PATCH] emacs: Improve 'guix-prettify-regexp'.
>
> * emacs/guix-prettify.el (guix-prettify-regexp): Modify to handle "nar"
>   and "log".

[...]

>  (defcustom guix-prettify-regexp
> -  (rx "/"
> -      (or "nix" "gnu")
> -      "/store/"
> +  (rx "/" (or "store" "nar" "log") "/"

Maybe explicitly show in a comment the URLs and file names that we
intend to match.

Otherwise LGTM, thanks!

Ludo’.

  reply	other threads:[~2015-09-20 16:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-19 11:03 [PATCH] emacs: Improve 'guix-prettify-regexp' Alex Kost
2015-09-20 16:43 ` Ludovic Courtès [this message]
2015-09-21 11:43   ` Alex Kost
2015-09-21 16:01     ` Ludovic Courtès
2015-09-22 10:06       ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87si69jb1x.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.