From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 02/02: gnu: camlp4: Remove extra input.
Date: Thu, 08 Oct 2015 09:54:19 +0200
Message-ID: <87si5lyevo.fsf@gnu.org>
References: <20151007182229.7660.43511@vcs.savannah.gnu.org>
	<E1ZjtME-00020e-Ey@vcs.savannah.gnu.org> <874mi25sbf.fsf@gnu.org>
	<20151007234520.1501a4d0@debian-netbook>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55038)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zk62K-0006Cg-15
	for guix-devel@gnu.org; Thu, 08 Oct 2015 03:55:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Zk61u-0003qT-F8
	for guix-devel@gnu.org; Thu, 08 Oct 2015 03:54:47 -0400
In-Reply-To: <20151007234520.1501a4d0@debian-netbook> (Efraim Flashner's
	message of "Wed, 7 Oct 2015 23:45:20 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Wed, 07 Oct 2015 22:36:52 +0200
> ludo@gnu.org (Ludovic Court=C3=A8s) wrote:
>
>> Efraim Flashner <efraim@flashner.co.il> skribis:
>>=20
>> > commit d04efa0fff908de0f8822a27582b4b1c3dcae553
>> > Author: Efraim Flashner <efraim@flashner.co.il>
>> > Date:   Wed Oct 7 14:44:59 2015 +0300
>> >
>> >     gnu: camlp4: Remove extra input.
>> >=20=20=20=20=20
>> >     * gnu/packages/ocaml.scm (camlp4)[inputs]: Removed duplicate "ocam=
l"
>> >       entry from native-inputs.
>> > ---
>> >  gnu/packages/ocaml.scm |    3 +--
>> >  1 files changed, 1 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
>> > index fc45805..0302c85 100644
>> > --- a/gnu/packages/ocaml.scm
>> > +++ b/gnu/packages/ocaml.scm
>> > @@ -208,8 +208,7 @@ Git-friendly development workflow.")
>> >                  "0icdfzhsbgf89925gc8gl3fm8z2xzszzlib0v9dj5wyzkyv3a342=
"))
>> >                (file-name (string-append name "-" version ".tar.gz"))))
>> >      (build-system gnu-build-system)
>> > -    (native-inputs `(("ocaml" ,ocaml)
>> > -                     ("which" ,which)))
>> > +    (native-inputs `(("which" ,which)))
>> >      (inputs `(("ocaml" ,ocaml)))
>>=20
>> This was probably correct: When cross-compiling, you would both need the
>> compiler (in =E2=80=98native-inputs=E2=80=99) and the run-time support l=
ibrary (thus in
>> =E2=80=98inputs=E2=80=99.)
>>=20
>> Now, this is mostly theoretical in this case because it would probably
>> take more than this to cross-compile OCaml code.
>>=20
>> Ludo=E2=80=99.
>
> Should I go ahead and revert the change?

Yes, please.

Thanks!

Ludo=E2=80=99.